Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2444077rdb; Wed, 21 Feb 2024 07:53:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUpinWyRVNZZ9LKpdJN7KvtLqoXhygrEj8S1JglNUSqbHTWFz48w4J5sSW6Lst6yoQCwt7rWkm6XYNL2H0lEd9N44Elp0THLllcvRvttQ== X-Google-Smtp-Source: AGHT+IEThqiELSbv0nVNmBt/DvvTbjyZ9bk7OmAcK082yCxfjtN2UJrNvt/DKG0IASPKAwwas31a X-Received: by 2002:a05:622a:306:b0:42e:40b0:6d37 with SMTP id q6-20020a05622a030600b0042e40b06d37mr973720qtw.68.1708530838522; Wed, 21 Feb 2024 07:53:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708530838; cv=pass; d=google.com; s=arc-20160816; b=E2BCxxOMUaqZBOUMBgqylCzj3gcNSXFtyNhDrZoO5aCCdFOoVx5CBjLU9am84FXG0d 5f+jflrRcfdN7CSXrnMVikZqfhv1BPb8ZgH2oD2CKJwEzmEZFT23lYxN8fRyfxHRI1wl m6NwzNGnMCueyI2wc3HxSSiu65mpS3DLNY7sC2qJG7ioXEBsIY29oiU2ZrE9ediPX7Ks OUmAm3S8R+m7bpvdKioF/ZRsw9oBBoy2H2qtgzNkL87IJ8B7CvNBpnlCjAOO2r2mKwyg VR5PEPVKqs/iXK/DFKbc20ovkEeJuA7bihDxOwbMFKqqp9AC3zbpbmDvxdk6O03qYpQC Q9Ww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=9VgNrg7E3WxzPLbpdW7b+fQZzMzEpRyOCT/6WT2Sf4Y=; fh=mkNE/wgaLpjmMD8YWajIvPuivMe2NY1JwTlLJKMuZLI=; b=ep6jcQ82hLJiNbTbPZJTsucQfCUw2BQrLQuy67BQVRccIilL45faGRci8EcrdX/b+Q 5iZAb/MUpQi/86aKdL5JgDijnERCS6k0491dVuDVBujd4Qd0QdQS0OtqZT35HEJ5tmt5 8yZgaJLd4BmlCVFIlW3WDSeP90xHgTPewFSdzmnrodcb989lzuGhesRzOfqliD7jF6yd pCYOd7P9p5i0pk9MV8RI9DN9bnreuBMbv31zE13r90xVG0bSAsOIAUzJfKe9el0mkwJD kG9+U79UwhiHqj8thlyDCGj9hRDJgqqysCVAno0Mt+uQ0dBZ1TXHSzs06yWhvYOc5+WS 0VUg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="KPVNGf/J"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-75035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75035-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t16-20020ac87610000000b0042c73ec3866si10621592qtq.530.2024.02.21.07.53.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 07:53:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="KPVNGf/J"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-75035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75035-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4102D1C24351 for ; Wed, 21 Feb 2024 15:53:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2BF2C81AB2; Wed, 21 Feb 2024 15:53:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KPVNGf/J" Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03AF80BFF for ; Wed, 21 Feb 2024 15:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708530785; cv=none; b=IsQOHFpfL+MN3sLLG9vRe2qpaKKk3mYWZDpi1weTSz6CGnxcM6pAEXP43Rb6m/D4CpuKPEH8x4M757R9hNK3Il6uLTtVBdQMvt83p8zyIcVlf1TEHCsQ550bv5N7pikSpKdXoW8RiUbjogK4+KBpHd+aTuRwDSm/nFRVIIus6ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708530785; c=relaxed/simple; bh=9VgNrg7E3WxzPLbpdW7b+fQZzMzEpRyOCT/6WT2Sf4Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=HzdUUKzcSU/QtOUqAazee86C6TQ6J2xi+hrzYz3UU3QQkfHewbrH7yGklB0P/S6rADK0nEDYsamF2+lM7TZH4+mCUlBTFyJReSojt12XlMp+tZuJoMaDGiXUhf5yJniAAB5BdLFdi1AgHvzTusHITrWAv26SWrh9XyKtWF37YG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KPVNGf/J; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5a020f5a4c5so73665eaf.1 for ; Wed, 21 Feb 2024 07:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708530783; x=1709135583; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9VgNrg7E3WxzPLbpdW7b+fQZzMzEpRyOCT/6WT2Sf4Y=; b=KPVNGf/JFzGtwRewRMQg5bShOJa0Dgvza0OeCoUI1GWDo3nuIs/PNoWjuu8dwSGmAf SZPCubx3OIjthO+2MmVHtovqUtncme4JxvyCFCCOmhxRsa6LoP9T/D5mw9loiBQBUzeo HdjFsS431y7wY1GXtpOUY9cN0BW3QNQF26OSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708530783; x=1709135583; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9VgNrg7E3WxzPLbpdW7b+fQZzMzEpRyOCT/6WT2Sf4Y=; b=g08rVR3Q6+aJhtaWIE/y25pHu+O60xqOSJPqLNQYwaIr7cmam2PUzj2f6NgVD95zn0 j2oE6BzZAXakiiS6lbdjrrrkeJZ23NVt1ejVgG12RVXvQZ3FzN8fivGpl4R0QgEWhqNE cRXiJPlELaHNnNeQGu+Ad4HOZKJAm4NHjO6nVZeHUfNxMfVAIPG0yrDZSfncRMJBdInd ChTNqbYo/MOMzwkDQzc9Z7cw3bxPDwZjbPcOgy3Kwcxp5pSehRu/PG/+nRZ6rpP2EaoJ acZ5j2E+1J9s39cfqP6KBo/wtksH5f28NHSXhs2R5yXhwz1tgZ60KbvkJ9H82lfTq6DO 271A== X-Forwarded-Encrypted: i=1; AJvYcCUXOsSyqRpacMXcyOyEf3xXrgIySyxa2vyKDWkqwWDGrCp92X9vURFq5UA1m/Wf1mVtthFWRUVZLV7cyJ/8TifyYfy5Vt+apuM8PXkV X-Gm-Message-State: AOJu0YwrnB3PrQTNAE5cbX5RUHLqLM0U9sL0VnFdQGmfSkVN2t0L5VgQ uMOeSC3Y3oy+L8c6W/RkgeKf5CtqJN/yp6Y7UQ/pM24kQ9yVtois60GwZZK4Hw3X8S7McmSfLxt UKZSnQVUt1UdzQ/lUrVa/++ISn/yR7ld0YQNe X-Received: by 2002:a4a:355a:0:b0:59f:fc30:d3aa with SMTP id w26-20020a4a355a000000b0059ffc30d3aamr5366824oog.3.1708530782898; Wed, 21 Feb 2024 07:53:02 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221114357.13655-2-vbabka@suse.cz> In-Reply-To: <20240221114357.13655-2-vbabka@suse.cz> From: Sven van Ashbrook Date: Wed, 21 Feb 2024 10:52:52 -0500 Message-ID: Subject: Re: [PATCH] mm, vmscan: prevent infinite loop for costly GFP_NOIO | __GFP_RETRY_MAYFAIL allocations To: Vlastimil Babka Cc: Andrew Morton , bgeffon@google.com, cujomalainey@chromium.org, kramasub@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org, perex@perex.cz, stable@vger.kernel.org, tiwai@suse.com, tiwai@suse.de, Michal Hocko , Mel Gorman Content-Type: text/plain; charset="UTF-8" Thanks so much ! We will stress test this on our side. We do this by exhausting memory and triggering many suspend/resume cycles. This reliably reproduces the problem (before this patch). Of course, as we all know, absence of evidence (no more stalls in stress tests) does not equal evidence of absence (stalls are gone in all code paths).