Received-SPF: pass (google.com: domain of linux-kernel+bounces-75028-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 21 Feb 2024 16:51:20 +0100
From: Maxime Ripard <mripard@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Javier Martinez Canillas <javierm@redhat.com>, linux-kernel@vger.kernel.org, 
	Enric Balletbo i Serra <eballetbo@redhat.com>, Erico Nunes <nunes.erico@gmail.com>, 
	Brian Masney <bmasney@redhat.com>, Bjorn Andersson <quic_bjorande@quicinc.com>, 
	Catalin Marinas <catalin.marinas@arm.com>, Geert Uytterhoeven <geert+renesas@glider.be>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, Marek Szyprowski <m.szyprowski@samsung.com>, 
	Neil Armstrong <neil.armstrong@linaro.org>, Will Deacon <will@kernel.org>, 
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: defconfig: Enable zram, xfs and loading
 compressed FW support
Message-ID: <724jnhrbs6r4q6whynr3aon5w7mhfvetlgcnts4nukvtxbuium@mrjv6apjqk7r>
References: <20240221141350.3740488-1-javierm@redhat.com>
 <1f28256c-e436-4add-aa67-2cfb2248b220@linaro.org>
 <6scz7iti3tzzrd4ph3gnuc2pvkcbtuuicgfgujh3pa3c34kdkt@bhfa4xbxeu7t>
 <cb8bf006-57df-494e-80f3-947582ec71f1@linaro.org>
 <fy3wffb2jwv4veo3golfn5olri77clxywbuwuokese7sbobixd@mird5k66cl2w>
 <56625c21-1b34-479b-b5b2-4c4d8b7a11b3@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="b7rp77zy3dqc2xbd"
Content-Disposition: inline
In-Reply-To: <56625c21-1b34-479b-b5b2-4c4d8b7a11b3@app.fastmail.com>


--b7rp77zy3dqc2xbd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 04:41:38PM +0100, Arnd Bergmann wrote:
> On Wed, Feb 21, 2024, at 16:24, Maxime Ripard wrote:
> > On Wed, Feb 21, 2024 at 04:10:12PM +0100, Krzysztof Kozlowski wrote:
> >> On 21/02/2024 15:48, Maxime Ripard wrote:
> >> > On Wed, Feb 21, 2024 at 03:22:38PM +0100, Krzysztof Kozlowski wrote:
> >> >> On 21/02/2024 15:13, Javier Martinez Canillas wrote:
> >> >>> These options are needed by some Linux distributions (e.g: Fedora)=
, so
> >> >>
> >> >> How ZRAM is needed? Why Fedora cannot boot without it? Debian, whic=
h I
> >> >> use on my arm64 boards, does not have any problem.
> >> >=20
> >> > Is it relevant in any way?
> >>=20
> >> Yes, because it is justification why we are doing it. Each commit is
> >> supposed to explain "why" and the explanation here is not enough.
> >
> > There's a why though: it makes Fedora boot. It might not be enough for
> > you, but that's a different story. So, if it's not enough, please state
> > exactly what you expect from that patch description so Javier can
> > provide it.
>=20
> It's definitely enough for me. It makes a lot of sense to have
> a defconfig that boots common and popular distros.
>=20
> I don't use ZRAM either, but I can see that being useful to
> avoid swapping to SD cards or eMMC when that is the only
> available swap device.
>=20
> >> >> I kind of repeat comments from similar patch earlier:
> >> >> https://lore.kernel.org/all/fe1e74a2-e933-7cd9-f740-86d871076191@li=
naro.org/
> >> >>
> >> >> About XFS: I don't think it is needed to boot anything.
> >> >=20
> >> > Just like 9P_FS, NFS or UBIFS.
> >>=20
> >> NFS is often used on targets, e.g. my board farm, but also by other pe=
ople.
> >>=20
> >> UBIFS was added recently because one device was using it - you needed
> >> it. 9P_FS looks unnecessary.
> >
> > So all we need is one person or use case to require it? Sounds like
> > we've checked that mark here.
>=20
> I think we want all of the above. We can probably drop ext2 since
> we already need ext4, but that is a different question.
>=20
> >> I was working in distro so trust me - they do stuff differently
> >> and they not need XFS in our defconfig for anything.
> >
> > Sure, but you're not just arguing for XFS there.
> >
> > What I really don't get is this: this makes the life of people easier.
> >
> > Being able to test an upstream kernel quickly when you have a bug in a
> > downstream distro is super valuable for any distro developper. And on
> > the long run, if we don't make the switch from a kernel distro to a
> > mainline kernel relatively easy, we're the ones that will lose out.
> > Because people just won't bother, or be frustrated and thus super
> > reluctant to do that work.
>=20
> We had previously discussed adding config fragments for common
> distros the way we have kvm_guest.config, but if the Javier's
> patch is all that is actually needed for Fedora, that seems better
> to me than the added complexity of fragments.

Oh, right. Fragments would be a great tool to reconcile the need for
minimal boot time and supporting reasonable use-cases.

I guess it's even more of a struggle with the single arm64 defconfig vs
the minimal vs batteries included defconfig setup we had for arm.

Maxime

--b7rp77zy3dqc2xbd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZdYb+AAKCRDj7w1vZxhR
xfneAP9jK3qR96b/wB2KMaKgrfj0X3cPayFrngbz47ysnllt7QEA1vqkfXuQyvem
rL+P/babebxH6r64YEa6nGgy/UEjDgw=
=XUC6
-----END PGP SIGNATURE-----

--b7rp77zy3dqc2xbd--