Received-SPF: pass (google.com: domain of linux-kernel+bounces-75134-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <67600176-d299-434f-94d1-d6e4f1a5b2b0@intel.com>
Date: Wed, 21 Feb 2024 08:48:24 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/resctrl: Remove lockdep annotation that triggers
 false positive
Content-Language: en-US
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Tony Luck <tony.luck@intel.com>
References: <20240221122306.633273-1-james.morse@arm.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240221122306.633273-1-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm02bmN4NlJFdmhpOS9pZStwV1ZsNDhGQ1hGenR1aC85d3U0ZjRiL05tV3Ft?=
 =?utf-8?B?a1Blb05HVjRVNzl0UUVCK3RQTDRmTlNhV2lTOVNaNUxiKytoMi9LRU1JeDlq?=
 =?utf-8?B?UVlnbFZiNlkvWTFVd1lLT0JWZXVpUjM2K3AyakhxMkZrMTFiU0JYTEpOVkMw?=
 =?utf-8?B?YWs2WTh0czBTWFBZZHJLSDFrV2tTczEycFcxQUoxZmIzZTcvZ2YzUDJySjFw?=
 =?utf-8?B?dVdWWi9MSklGYUluOFJZU0dVdSt5ZHpnQWpmYncwV0tIWXVvL0dHS0YwK3hM?=
 =?utf-8?B?SXRKZTZIeFZwV3dJZldxUmw0bG5zTy9QT09RWjRpbmlOa0dNZG9sbXo2QWh1?=
 =?utf-8?B?UWlJUElzakl2Uk1hQ01yaWdVTmx0NzFRY2lZbFBRNlYwdkczb0QzV29VTlRq?=
 =?utf-8?B?K1Yrdnd1R0xINnFtOGZhNGRITU5xNjh6QmJSTk1yNHdEZzgxaGtabnMzVE1t?=
 =?utf-8?B?Mi9vbUtCU1AwcUt0R0Y0STlVZG5yTHVKSjJHZkd6MmZERjhmWmVqcTh4VVFX?=
 =?utf-8?B?UTBTYWphUW1QTG9MWjBuazRBNm1NeklCL1drNS8yNG1CYURrT3UzTTRSQ0I1?=
 =?utf-8?B?Qmw4aFhWS0g1UWxGQ0N1NzE3L2dOUWVhVGh0aHVQanMyYk9DT1M5UEZCQmtQ?=
 =?utf-8?B?T3M5cE14WDNDS08rWkVFejBqOFRlUE9HRS8xeFhSUFJSQ1B3K0JxZjFxdXl6?=
 =?utf-8?B?QUw0aTdBbzdJd1hWdXI2THJhNmxoTDRHS3JnczVRbFNQanU2aW9vcnpUb3Zy?=
 =?utf-8?B?QkRiMG1vSm1USXdUeWZScnBMc2p0OXEvRTVqaGMrN0svTEg2WmxQZ2d5eTVK?=
 =?utf-8?B?RTZSbHNKRXpCVHIyNzA1TGQrOGlYcUd4QlZCMU00UXR5Ry9Ra05uWUdscWU3?=
 =?utf-8?B?TTYrUG5aeHc2K0Q4eVFUeEpXNnI1RVhFTTZTaWlXbXhUYjNub3hDd3FWdHph?=
 =?utf-8?B?ME5JUVhRVHJWYTQ3M2wrb3FtRUNYRUthNUFQWmhpQVlRWVZ3MUljb00vTGg0?=
 =?utf-8?B?a3BCUFJKa3k3M1lzMEtmcVVQZGNSNzN5NmlOend4WmhzS3pOalpIWFhrRWtM?=
 =?utf-8?B?ZmRIampZSnlUOW1KcGgvMTM3SENsaS9QaTQxOHhaMXdUT0UyYlcwVTNuczZM?=
 =?utf-8?B?MEtDbEtvVTJZM0JOeE40aUZWY1hUcUV1Y3BxaEVPR1dmRTgydG9ubE5va3ZJ?=
 =?utf-8?B?Y2pHQ245UVkrN0lxeXVuUHNsUURweTgwUkY2OHRmSW50OWw3OVlVZFRPWEdV?=
 =?utf-8?B?Y0srSW5yMXpPVXJkcXdUK2pKSnlnT0xGVjJPVUsxMG9FeVlGT3dtYThzaGZX?=
 =?utf-8?B?MHZSTEdteGxhUXd1czIzTVZHV0VSSGlraVh6c0RFOXgydXZPNDVydE1RR3lW?=
 =?utf-8?B?dnV4RFBiZVpDb0gxUnhkazgwY0ZKNjdlL3B1M2pnd2k1bFNLVmpyQlFpRnU4?=
 =?utf-8?B?YVpZckU3TWJOcDBueUZvbWZRdHJEVTBzN1oyNEQwMFB2eUR6WG1la00vSmRK?=
 =?utf-8?B?SVRTNld1TExXM0cwVW1pQUtXdDdtU053Nk1DbUFnTXAxZFpDbmdEZi94Uml3?=
 =?utf-8?B?LzA4Mk9WZFhkeDNJWTh1emgxdnFySzQxODdQcXZycjlOYS9pRUFQa1RDQm5P?=
 =?utf-8?B?V0c5bXlTM0d6cThKNWE3a21GamtxMFo2WWcvbFN0TWFyWnpCb041dUM4Y0Ex?=
 =?utf-8?B?Q2RaUkc3OUpCbGRUSGJSQjI0K0lRSWFMRWwzbUJodFI2bGJTN29MMytudzF1?=
 =?utf-8?B?elJSNmJlUHNReE5qOWZMWkwvbXhJUHR6MnNZY3lnR2lxWVRDNS9ORDM2ZUtB?=
 =?utf-8?B?bVNsclkwNnpoTHphaitKeTUxRGl4elNERU9oMkVjalM3cS9qUHlzZy9jWS90?=
 =?utf-8?B?TklvM0VaMTBqa0ZhZ2xzUUZxcitzSjZIWXdHS0xQUDZORmV5TTJ0MzV5ZXli?=
 =?utf-8?B?OUtqSG9RWmtrRzkwQzVaQkNpdW5mZ05oeFZnMTEzbEkrMkV1SjhEUTk1a0d3?=
 =?utf-8?B?SENuNk5yWDFSWFlBVTRPZmZyS2twcUN0ZFNaOHZITURlcnV3aFowOUxwZmxu?=
 =?utf-8?B?cVdvWWZtdzlHRmFDNFNjMUJBcTNaTGxsTXplaVN6OUJhS09Pa0RpemNPdHZv?=
 =?utf-8?B?K0tNYzM2MlZQMWoveFRXTERzYUpraUdMcVRxcDhkbzNUdzVJV25Xd3hwRDVP?=
 =?utf-8?B?d0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab9f151-2bbc-4803-56e8-08dc32fceca7
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 16:48:26.4796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /ZjoKaD2uIJIhvi5+ncKNpjOjYkkbiSz4bUcgytZ5DHq+QFkwgZWy+NJhC0EGB2vzSoQe5Kh6GMtN+fX2o0jEfIeXCyxeq8M6GV844hPcLM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6112
X-OriginatorOrg: intel.com

Hi James,

On 2/21/2024 4:23 AM, James Morse wrote:
> get_domain_from_cpu() walks a list of domains to find the one that
> contains the specified CPU. This needs to be protected against races
> with CPU hotplug when the list is modified. It has recently gained a
> lockdep annotation to check this.
> 
> The lockdep annotation causes false positives when called via IPI
> as the lock is held, but by another process. Remove it.
> 
> Reported-by: Tony Luck <tony.luck@intel.com>
> Link: https://lore.kernel.org/all/ZdUSwOM9UUNpw84Y@agluck-desk3/
> Fixes: fb700810d30b ("x86/resctrl: Separate arch and fs resctrl locks")
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
>  arch/x86/kernel/cpu/resctrl/core.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 9f1aa555a8ea..83e40341583e 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -362,15 +362,6 @@ struct rdt_domain *get_domain_from_cpu(int cpu, struct rdt_resource *r)
>  {
>  	struct rdt_domain *d;
>  
> -	/*
> -	 * Walking r->domains, ensure it can't race with cpuhp.
> -	 * Because this is called via IPI by rdt_ctrl_update(), assertions
> -	 * about locks this thread holds will lead to false positives. Check
> -	 * someone is holding the CPUs lock.
> -	 */
> -	if (IS_ENABLED(CONFIG_LOCKDEP))
> -		lockdep_is_cpus_held();
> -
>  	list_for_each_entry(d, &r->domains, list) {
>  		/* Find the domain that contains this CPU */
>  		if (cpumask_test_cpu(cpu, &d->cpu_mask))

I agree with this change. Could you please base it on x86/cache
branch of tip? 

Thank you

Reinette