Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2482023rdb; Wed, 21 Feb 2024 08:55:52 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWFQDFKTfrgKXwZus+ThUySVTYrkQeUWu2KgAZ0qoddP1IiIL2B/X6yIbOyE2Xy93y7pRDKNEq9pUwgzjfPmk8I25DG9bLElIM0I9GJaw== X-Google-Smtp-Source: AGHT+IFCHEV18G0bETTeayammdKJxex/9a51I2xlIvCOfFKrru58PAZdcVweDSt5QCDZ1RRatG5C X-Received: by 2002:a05:6358:710:b0:17b:5dd1:a38d with SMTP id e16-20020a056358071000b0017b5dd1a38dmr1802572rwj.1.1708534551967; Wed, 21 Feb 2024 08:55:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708534551; cv=pass; d=google.com; s=arc-20160816; b=Gkj/uk9pduM73MfcaGJFemjFhRzYYECO0G74+g4yHJ9SVAlFw1ZTLPj/qTv6UG7EKp s/7lq3g3TLF/81yVQyQfUGYEEfQ/nS1Ha1LiCtjeRT0jEMPoYfaeafc8bJe56dQgol+l oilWy91KXOt83mUH4HJqfwPiiPyBJrX2ISucAvt0SyUUApdpAAxWW8WgGaq/sOX5Ja9T vchbGW//bApccqoh0BKup+xCo059mQw87IsFTHL61tXNcU+HsRNfPnbXt/IS+xuJoA7M 7rPcR+Oy9aBkr8BENU14cbIEA4R2sz3MnpIg6+CpsFGow1WVzulEy3KcBZGGmGMIakAC i+bg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=uwKolqam8L8bHsbmnM6dTF4FWc4fGvUzQzZlduUQCeA=; fh=9CWJGPdX6SaCLNVxL/uP5MkWvcMhq9rue4kGMkfU540=; b=FvLftQscgf5whBlpHsJYI/euMhbbtoxZhxgKMohpD8qDqe01zCQodZ40uzl6mQZAyw dIbbffTe1qsO5t2d2hL4PdkMNwHH2Z1OJ6NFHcMXjpmNc5e+Z3uy21Uh4KsOukCOUp+P vCE9AsYXxlitUSP58FnmF6nt+d6lDsiy9gM2gj7xqaiqDNgcnvH1Obm9R18dcakbFj2c 7q5k63E2TmyUJooQ7unb8EMgt+WMrXeOmnee4A3S4MsTcbzx8q3YSyC1fGQ7jiKomtmf mV11pCFB1sq+bQKvl344a1bsOosdHTBjf4hBuwX48PpRIDONOhnW58QI4gzOqgzhXVfJ pzVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="k1yVo2a/"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-75145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75145-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z24-20020a637e18000000b005dcbb6b4bffsi8627880pgc.335.2024.02.21.08.55.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 08:55:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="k1yVo2a/"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-75145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75145-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 11BBA285AF4 for ; Wed, 21 Feb 2024 16:55:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 796B8839F9; Wed, 21 Feb 2024 16:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k1yVo2a/" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB9A82D8F for ; Wed, 21 Feb 2024 16:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708534528; cv=none; b=gv4xVkyrMkusyw0MZTTbtAjvyceke9eXSDa/Fh33APaByt0y3U7d5wi73Gkdo1l1mZIVZRWkLCbPI+ql7jvEtH/GZ91tvJ8Z0k3b6IOtWzGTGn7QP8x90up4/3IqSxGJPy9/6tt4KtquYDlVU3dIcJ7Xi6+IIGuUUasr4y/D768= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708534528; c=relaxed/simple; bh=9A2NkYvXqxZrDii8D/Ri7QZZYFt4/LusxalkSWfJdg8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pa0Xstv82NHBCjNr0+w1P1MO5LIRwPzvseFih4w00miUgA2c1g71P9aPD4ffsdpzcpnOsWp5jCBU03+F6NImvHgT8yiaYcy+A+8HBgwCBCL36P+LHc/I1S8ajElKn6C4IskC4/geEbNscdo4/G6fvmgksZKuz+6HvdHOQX2Jepk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k1yVo2a/; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708534527; x=1740070527; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=9A2NkYvXqxZrDii8D/Ri7QZZYFt4/LusxalkSWfJdg8=; b=k1yVo2a/8mQSTByNBLcnW8BSmei4WnwcR25aRvy4J3ZwLbhRCZC7SREn JHnleRag/ffLmnY2VRlowlDvgRGgKVuNeakD4CIVTp7fEdgdIXfoAH4Si rk6WBp6GFQhua9EtxUypdfzSNcyD8fH5IOfBwuRTCZew+bFVPXcozcu0J DhaqGqnevWxrWVPYQPvCwAENPDOndCq6/AXGWXLbfwGk0RVohg/mX9NHt eZS4go1cx+V8tE0e0jpxJKaDOG4T3LU2C6EFPI9eNvyRj3LD016tDlomo jXlG9G8nfagn3JW3+Oj2xf1yl/9/SWm45RLlNBwlPMrz72vMyjUkHcM6a w==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="20249539" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="20249539" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 08:55:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="827377914" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="827377914" Received: from remiller-mobl1.amr.corp.intel.com (HELO [10.209.48.179]) ([10.209.48.179]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 08:55:25 -0800 Message-ID: Date: Wed, 21 Feb 2024 08:55:26 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] x86/coco: Require seeding RNG with RDRAND on CoCo systems Content-Language: en-US To: "Jason A. Donenfeld" , x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Borislav Petkov , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Dave Hansen , Elena Reshetova , "H . Peter Anvin" , Ingo Molnar , "Kirill A . Shutemov" , Theodore Ts'o , Thomas Gleixner References: <20240221123248.25570-1-Jason@zx2c4.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240221123248.25570-1-Jason@zx2c4.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/21/24 04:32, Jason A. Donenfeld wrote: > +__init void cc_random_init(void) > +{ > + unsigned long rng_seed[32 / sizeof(long)]; My only nit with this is the magic "32". Why not 16? Or 64?