Received-SPF: pass (google.com: domain of linux-kernel+bounces-75137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240220231424.126600-1-vishal.moola@gmail.com>
 <20240220231424.126600-2-vishal.moola@gmail.com> <ZdVvzu5OrdUoxc-O@casper.infradead.org>
In-Reply-To: <ZdVvzu5OrdUoxc-O@casper.infradead.org>
From: Vishal Moola <vishal.moola@gmail.com>
Date: Wed, 21 Feb 2024 08:49:24 -0800
Message-ID: <CAOzc2py2PEV9V6WFpgyYkHxpYUk84i40+USFPMiXOV=R090VaQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] mm/memory: Change vmf_anon_prepare() to be non-static
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	akpm@linux-foundation.org, muchun.song@linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 20, 2024 at 7:36=E2=80=AFPM Matthew Wilcox <willy@infradead.org=
> wrote:
>
> On Tue, Feb 20, 2024 at 03:14:22PM -0800, Vishal Moola (Oracle) wrote:
> > In order to handle hugetlb faults under the VMA lock, hugetlb can use
> > vmf_anon_prepare() to ensure we can safely prepare an anon_vma. Change
> > it to be a non-static function so it can be used within hugetlb as well=
.
>
> I think the prototype for this should probably live in mm/internal.h?

That does make more sense, I'll move it for v2.

> > +++ b/include/linux/hugetlb.h
> > @@ -272,6 +272,7 @@ void hugetlb_vma_unlock_write(struct vm_area_struct=
 *vma);
> >  int hugetlb_vma_trylock_write(struct vm_area_struct *vma);
> >  void hugetlb_vma_assert_locked(struct vm_area_struct *vma);
> >  void hugetlb_vma_lock_release(struct kref *kref);
> > +vm_fault_t vmf_anon_prepare(struct vm_fault *vmf);
> >
> >  int pmd_huge(pmd_t pmd);
> >  int pud_huge(pud_t pud);
> >