Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2487904rdb; Wed, 21 Feb 2024 09:04:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVnyT584WvtixhGCNMavhumm3LU85R0/9hBtDAOnlaZ8UpKf5jWzF6YYwcH0UGpgz7cuzcJR4P5mpdcIDvorWwoodjCN5+GuQchTql0kg== X-Google-Smtp-Source: AGHT+IER+vX6gafUBVytjk0/simA54bC1IGG++eqsvwz4R95bh1CvfQWLuGwn8epLtnYhQ9ixHAn X-Received: by 2002:a92:ca05:0:b0:365:2732:8bb6 with SMTP id j5-20020a92ca05000000b0036527328bb6mr14460891ils.11.1708535083962; Wed, 21 Feb 2024 09:04:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708535083; cv=pass; d=google.com; s=arc-20160816; b=g++JOKForlQIiMAuNvdcdHlFIBIeWTafwz+/1TbcBRM0jUCsNvA5F4mQB22rtmuRxb EA5f+Hb12reErWFvRxakJsgqTBeVJ0TjGHJu8hC7D4Yc7IpFq4BFO/xGgqHqwypa9pTJ OBTlbT2kTEfAdC3IIFy/A76MebJ0Ha3jYNJY/ivqrOgtw5u4PlAn/6rDwree0w2+IJIW +clsTQpLzaG0KoT6IjvRdvXyMpwq+tgjA+F4EZpA2af7Wn9yQZSWJXERqOyPtIu+/W1e I8Z6PAzMS/YcAlVi5JPeoOwEO1QL9k/8yQnDTrkqZ5g5D/bQLuXY4RboNWfxAog5ekY5 r0Tw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=5/2PXeUtYZN5Banhfqv2e+wEkrcm+AGTORes2hTmKPk=; fh=vzqGYvLAcI1r56p9L5USQEZxcGyU/dq82J+Mn3KQKPA=; b=Z0E0XKeu0fXqfbocLeCQUn47XNsW7m7DZ9d9fxs/OonIqG8OPJbFgxVJ9oW0GxhLXv yQxU7wIFCePZNvm2muyksOPol7qG8g07UvFIirPD817wo/TgtY0weNnPZIXjBspqQMgf 68ZHlvkNP+UMdFlQbwkwBx5ynkJ8FRN75Rmoip3i52dXokQu8b+WeBXtQn+hpX7pwEdQ FBoK6cz4O8+TT88NJyy5ggEbsQvgDX6fXqqrZpO9PjHtJANxq5it/UdKtvJoPIPUtq9f GrfdMgB7csml5DrnTDg4NZNNwIhVB9azfcXo3DFJLuKMlo8133QwlEBwC2vCVKGYNNBj Me+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=kKF9hTRn; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=rLHUGzek; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-75158-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75158-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y2-20020a056e02128200b00363c99587adsi3618285ilq.129.2024.02.21.09.04.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 09:04:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75158-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=kKF9hTRn; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=rLHUGzek; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-75158-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75158-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A7F99282D37 for ; Wed, 21 Feb 2024 17:04:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0109839F9; Wed, 21 Feb 2024 17:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kKF9hTRn"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="rLHUGzek" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E73E83A12; Wed, 21 Feb 2024 17:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708535067; cv=none; b=SEW6jGQhmOkTqSLa9xI9ikXaXRDBCPDPZxqQ3XF2YpDA66jiinLdQUKbIMebVmQFn2/V2iX9Ef1G2mckrS+EqtxdpLwijoJWEQmfWz1R0qwIpnIjbSFuqIEj5PxfqQq035RAPqp5kIM3CXKUHNykmteVqoU9afw1NSd9LTz4vHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708535067; c=relaxed/simple; bh=I9BPIMQV8ivzAq2sUNXIWktFBAZhuoYcLn9hK+92n3c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=DX83b1WvCU1idgVqBLTwr+BqH5vBrmQBOsdE1Kdb08xi7hhyx3C96LNCw2WHKfcyuYGKf26LhCJeb16jDb9ID7vtREg+mZ/5/6foswpS20tdCYHxsTTkLozA5TypoTNNNlJFuv/fj86WKwBzDeyV+KAd5CbVREOssmrN0RFENwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kKF9hTRn; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=rLHUGzek; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708535062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5/2PXeUtYZN5Banhfqv2e+wEkrcm+AGTORes2hTmKPk=; b=kKF9hTRn/NdeRVN/fjSQ36SK7Zt7CiVyKGHrDJzYPqU0cXodAWIB/lUF9AjSYLYhDC5pHM VR++i0UzTHTD7IfjU2W0BA8BIpmXWPOOxssJfqsDArwrdX0FXqQNO79viSVqzcxO0uIddu jWKpkJlGMoatTw6CVsY7Py1oVOMmVpAU4sq0iWXsZ2aM1ewa1WNBJphhA/Ih7GtU74xcQs sogpPaxc9Endjt9XGRmJs+kJxrAUqCqvipRfyjWHFFV11pxFisAkrpzpCB0jUoUW5gg8/R qSSi9iXBJHCt36FSNo5la0FOTGGFSzfTf+T6ioISkGwD/wcyNeaoSjCNWDXTDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708535062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5/2PXeUtYZN5Banhfqv2e+wEkrcm+AGTORes2hTmKPk=; b=rLHUGzek8UDGvurt1OgFa5LrZ4A+qJ29OC7ELGvQHxrIjqGY/PneNNgi5prXv4tdqQJbZh O/aOtUoeywd5CUCg== To: Leonardo Bras Cc: Leonardo Bras , Greg Kroah-Hartman , Jiri Slaby , Tony Lindgren , Andy Shevchenko , John Ogness , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Florian Fainelli , Shanker Donthineni , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] irq: Introduce IRQ_HANDLED_MANY In-Reply-To: <87edd5hljz.ffs@tglx> References: <20240216075948.131372-2-leobras@redhat.com> <20240216075948.131372-5-leobras@redhat.com> <87zfvwai62.ffs@tglx> <87v86kaf84.ffs@tglx> <87edd5hljz.ffs@tglx> Date: Wed, 21 Feb 2024 18:04:21 +0100 Message-ID: <87bk89hhpm.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Feb 21 2024 at 16:41, Thomas Gleixner wrote: > On Wed, Feb 21 2024 at 02:39, Leonardo Bras wrote: > But as I pointed out above the detection logic is flawed due to the > unconditional accumulation. Can you give the uncompiled below a test > ride with your scenario? Bah. Ignore this. I misread the code completely. No idea where my brain was. This thing triggers only when there are 100K interrupts and 99.9k of them unhandled. The 100k total resets the unhandled counts. Though one thing which strikes me odd is that this actually triggers at all because it needs 99.9k unhandled out of 100k total. That means on average every thread handler invocation handles 1000 hardware interrupts in one go. Is that even realistic? Thanks, tglx