Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2514941rdb; Wed, 21 Feb 2024 09:52:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXlo2aECJsEANdkNvFZ4Zl8R8XwYn58f2CqB3+5yUAEZCXjKptjmEcZ0cT2P2ynTet/rfcJCaElwimC8rmv2vGUtR8ALEabWmIF4jZ7sw== X-Google-Smtp-Source: AGHT+IErwoYxhusgv+tOGYbjudsuyDLDiUfRZrN36itn9ezaT2JySSylcDNOXAz7tJxakNXI7WDq X-Received: by 2002:a05:620a:d4b:b0:785:d8a3:ab84 with SMTP id o11-20020a05620a0d4b00b00785d8a3ab84mr20661558qkl.34.1708537968740; Wed, 21 Feb 2024 09:52:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708537968; cv=pass; d=google.com; s=arc-20160816; b=fgXinn7/JKLrA05xf85QpP7ROhCsvqbqFf/I/OmsgzZtZEZnlJCJMUlwDAP5Hhen4u qSHaQsAyHOQDy7Y+cBJMvT0tU1nw+1QRTzn7zYHKMDAZGPmAdSIYxtl6Uw8CNG+3+Ni5 xuDVgr7zDJY7QKl8UI/vTiNkIEE9uhjAsLyfbzN2GiK2B9g9hOPYtpbFT9UIkqYom+r2 EQv3Y3CnuttcyXi8STjYrVk9pAHmVyPPlDJhGQAPChu79mX/juPbNU4QCcKmE1iBVPUH PsMKMDs/uBdU6vdBaQXajrpbUNIWAQXuBQo1n+Uhf9JLrcr+FXRjUK0cuWWfrN0yudJo x3cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=qsBOiIrG9KljWzFeDUJcGtaUB0dhNIZP29Kyl7b4+fc=; fh=Zlfii1P9eA0mF9hv7ggodwbSUPcHZUtY2/ZHOjBJR88=; b=EErcHzARg9CHogJXp0RFv/cjsMphKKiIcoex+Vi2omauR0lFNdg0uecWVJCVG1YDRR LRhEi9nI5T4Eb6A9lv3ai20hzDXjZxu7faW0pD9wIWHByUs3+Suxv3wEZSP0n6FPsBX5 AQ3CgCVdHupjcBCmT2BCAWhtRVD6Qwv7EUNE5AZ3eA9dbIszlolVj8gVbOu7Q+GyNcOj z/f9fyWLpxxhCxn8eX8FNopVkuyVI6gUw75jRM50xNWqTvZ3fojdirE29EugUYmDcJYX XNJEvbKCMIasPmeGbDq/zSSdWPusW6Iq2pvTyRypjNUGoHN4e6rlCbKSUoNbOoNa9ing vysQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-75230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75230-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g13-20020a05620a40cd00b007872afe4bdesi12469972qko.410.2024.02.21.09.52.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 09:52:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-75230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75230-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 806F81C23988 for ; Wed, 21 Feb 2024 17:52:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A8EFB84FA5; Wed, 21 Feb 2024 17:52:34 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3417283CBC for ; Wed, 21 Feb 2024 17:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708537954; cv=none; b=Z9HLDRbIhIlW9er3HZG8OUPmxMxtZfEkMivkQBLQiIHLIsoiIdFr0XI+CfOzyP8DzH8/P5MnZ7U1ASpAuYdxkOKMNkaznUJnyK1bNN13O65uxcpDoI5LEfITLrrAxTg2JzgHLT+1z5Zod7e74cEIPIt5dQIkUZVXZPVlhkJFuLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708537954; c=relaxed/simple; bh=vGsigQuL+u0HFHNbxOC0aQw+UDlTSj//wNx9tmWe9kY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lm1j0E39MqCRnYAqEcesv4lhfx3AVl+JqU7ktURBXvgAv0LMh0522UCHkRgRbvvn2NbIrD/ytPr6DDd3aPzwTDewc76L3/pW9ckQ9UPyRiiH8A6iP49AO4qjNM65PGgMmXRUX4qszbl02dOrYgMG4F0gQNtP9x+OprmN5JAldFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDCD8C433F1; Wed, 21 Feb 2024 17:52:32 +0000 (UTC) Date: Wed, 21 Feb 2024 12:54:20 -0500 From: Steven Rostedt To: Wen Yang Cc: Oleg Nesterov , Masami Hiramatsu , Ingo Molnar , Mathieu Desnoyers , Mel Gorman , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH] coredump debugging: add a tracepoint to report the coredumping Message-ID: <20240221125420.3430eae5@gandalf.local.home> In-Reply-To: References: <20240217104924.GB10393@redhat.com> <20240219112926.77ac16f8@gandalf.local.home> <20240219170038.GA710@redhat.com> <20240219122825.31579a1e@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 22 Feb 2024 00:00:55 +0800 Wen Yang wrote: > > Honestly, if anything, it should probably be moved down right next to > > () (I never understood why needed its own hooks > > and not just use tracepoints). > > > > Perhaps it's just because perf appeared earlier, and it doesn't rely on > TRACEPOINTS. tracepoints existed in 2008 and perf was added in 2009, so time frame was not a factor. > It is indeed reasonable to replace perf_event_exit_task() with > TRACEPOINT, and we are willing to try to modify it. It will require some > work and time. I think that would be worth while, but I guess Peter will need to approve that. -- Steve