Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2521456rdb; Wed, 21 Feb 2024 10:04:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVmFy7ls1e+n3qeArrziOub4Jo3K6s1XqwKwGPalSA6NVxwp8m4y9T7NjMzBIelMTY8nUaHvTqcyhTNyKscfb8ypYxodJkSk65a2HpjwA== X-Google-Smtp-Source: AGHT+IHuJ6R9AH6oP3l/7Kpr0C5eiNRT716ZvzlaoDw2fbfsDNZeZ0scCVBM6bMPVxXp7vUsa4M+ X-Received: by 2002:a05:6402:5246:b0:565:2183:d296 with SMTP id t6-20020a056402524600b005652183d296mr514909edd.27.1708538664863; Wed, 21 Feb 2024 10:04:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708538664; cv=pass; d=google.com; s=arc-20160816; b=mg0nKuWwDOwRYfJoVH59VP2/yoh71t2GB4QmJBN/gyDYCJUkUhXVEY0MhiNfP+llZa OEq80sWxabOpFUQfj0CTtIaPjOIquF97X/x9vucPIyy+fe5cZs/htdabSZPboOBSv8gJ x88fU7CcJLAQHYHXOCqG5FyXCO91Y34SZv9nrYam04FuVAIZFHsqxh2AYMbjOdxI7qn7 w3DcXEA6kVDaYmYj52KeUT8j1h3A0LRxgqSK7RZDvCXuBsvxF0WEIT1GFaZVRriGWXO5 vJOcSW7XvW/Ghr5PhNgVWodfbPLot3Pd9xyiyR4rPpAgAwY1jjPfc7ta0ASIIAOfq0V5 bDWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SVtj5UeLN9PzLE+nAc3He4Nr45+iGWDtonODqu2YIag=; fh=s5uhl5vi3XdGOzT+EWONIuNjCwcBKo0TQDaSXvDVep4=; b=hYvE09eD6L4Cv/+zwDSoCTRKR8uCl1gQb/Pm95sLFfJF3AKh+6tutsTTT7ZZltfX1y 6ZaQhqWASl2xNBur6tzJW6pJrf63ded3WX5C3jgEe/6HCFAnI5kVsdgpsv6STumArZB9 dh8Ithhvv25J1+Bo9Hq+4ykgIahmeyCE7ZXkQvA8HxVV7ErsiGklWr5hJCNdcKbClbnl PUt7J6eqBa2D3l0qmK84FLdS4W1y9J+6CeUWO6U5V++zN6qKQkqZIG+mD/v27gxin5te i733YLbv+Gqs+WcJsoqi1/zK076gjhrf+9dsx+B0dwqiZsgypG7PgBgtj1+slVKY/1cS 193w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HkZlqsNb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75244-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id bl6-20020a056402210600b005621e481340si4755388edb.49.2024.02.21.10.04.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 10:04:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HkZlqsNb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75244-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9B5F71F240D0 for ; Wed, 21 Feb 2024 18:04:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 619EF85260; Wed, 21 Feb 2024 18:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HkZlqsNb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA7384A40 for ; Wed, 21 Feb 2024 18:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708538657; cv=none; b=rlqQbaTROzy16l95VC/zL8DdvVmarjYtW+Ej9nxJvg9KdijvQj+wIRNZqHyuhZEVNrBwPLIQnY9UQpZ6F2WZJyV5NBF5WdHV8UdL5aJZqIC52nVicDOA6I4e2E77Pr5mM3sTySXgNGwEy8LcswSUhNFyZJLNnyY2Ep9Q+0Ehpkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708538657; c=relaxed/simple; bh=CZQzgLXnK0wfVh9AjBPaaAYevg83M6W8YPFqFEIq3Ls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fxcXS2n87qC8FUSxOzRldE+9JLdJmLgb2RkqroyyTJG661VUE0hCN7JKl2on6vCc8cY7rvHsUjjWUV9wig4RlQ0Hzw5aC481sRDkqoQBf9gXKVVDCWUhzzDQc+sXiX143u8X9eVU5Jn+8rLnwUdQBqgYR15GQXnHGyeVbtHmtFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HkZlqsNb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BBC0C433F1; Wed, 21 Feb 2024 18:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708538657; bh=CZQzgLXnK0wfVh9AjBPaaAYevg83M6W8YPFqFEIq3Ls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HkZlqsNba/I8LjXS72j+mE53PIhJqcBnBnNysOlWO4TQc11r3BekpgSQjEinuCuFO xtgFu/YKINPsAdHUGhmyS1EbdxarffVXg6N6MiuD6K3nrXKWapbSf+UQE0bLZwO21+ 0VoZ6ic0UfcfX0KwYXcy24cm1hTMooIqRSnH5EpHLMl4inWycugFO/bZL4w4FGtLY1 AUg7ueCGOFIaLVCoLI5FpqzWdATYupWBVlBypqOekY62AdTqVdQloEtPbzoS7yhnxP poCvEI7GIJD9ruNHmq6j2TRBn+Y1dn1I6cl+AtjmzPFSojG/hu5A5rZ/eV6ml6tacR h/Ae47EqUdHlg== Date: Wed, 21 Feb 2024 11:04:13 -0700 From: Keith Busch To: Daniel Wagner Cc: James Smart , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] nvme-fc: fix blktests nvme/041 Message-ID: References: <20240221132404.6311-1-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221132404.6311-1-dwagner@suse.de> On Wed, Feb 21, 2024 at 02:23:59PM +0100, Daniel Wagner wrote: > As suggested by Keith I've merged the new flag for nvme-fabrics with the last > patch. I also added some information why nvme-fc is handling the initial connect > attempt differently as requested by Christoph. > > The new flag is called connect_async and the default is false/0. I've tested > with a patched nvme-cli/libnvme version and all looks good. When this series is > accepted I'll update nvme-cli/libnvme accordingly. Note, that even with an older > nvme-cli the blktests (especially nvme/041) will pass with a newer kernel. > > (nvme/048 is still fails but this is a different problem. On my TODO list) Series looks good to me. Sounds like it's not fixing any regressions, so I think this goes to the 6.9 branch. I'll wait till end of week for any other feedback before pushing anything out.