Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755863AbXL3TSh (ORCPT ); Sun, 30 Dec 2007 14:18:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753077AbXL3TS2 (ORCPT ); Sun, 30 Dec 2007 14:18:28 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:58113 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbXL3TS1 (ORCPT ); Sun, 30 Dec 2007 14:18:27 -0500 Date: Sun, 30 Dec 2007 19:18:25 +0000 From: Christoph Hellwig To: Marcin Slusarz Cc: LKML , kernel-janitors Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Message-ID: <20071230191825.GA6447@infradead.org> References: <20071230190619.GA13757@joi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071230190619.GA13757@joi> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 20 On Sun, Dec 30, 2007 at 08:06:34PM +0100, Marcin Slusarz wrote: > There are many places where these functions would be useful. > (just look at: grep -r 'cpu_to_[ble12346]*([ble12346]*_to_cpu.*[-+]' linux-src/) > What do you think? > > ps: this patch depends on http://lkml.org/lkml/2007/12/25/35 > -- > > add inline functions which add native byte order variable to > little/big endian variable to core header and as an example > convert ext3 to use them Various places already have this as be*_add / le*_add, so it might be more useful to keep those names already in use. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/