Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2545661rdb; Wed, 21 Feb 2024 10:53:35 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCV2naGiHEKRoOPnJH0pjI2D4X9LtjLNvh4BnBpN4W6xXW/8E3CLh50q99aTXbXK384joOSTuhdEBX/1v0yv1zWH+HPVEjvDvptLyBAUnA== X-Google-Smtp-Source: AGHT+IEZPMdWDfWzpop3wfVORjHM8k6VnmlKZAfNAUsaBQUYbCLrHfBkdIhwrO8QMMRop/Bt5Kto X-Received: by 2002:a2e:7c0a:0:b0:2d2:524c:a535 with SMTP id x10-20020a2e7c0a000000b002d2524ca535mr2255823ljc.16.1708541615404; Wed, 21 Feb 2024 10:53:35 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id r7-20020a056402234700b00563cf3114d0si4680781eda.426.2024.02.21.10.53.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 10:53:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75331-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=DzYocgmy; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-75331-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75331-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 13F5B1F2610B for ; Wed, 21 Feb 2024 18:53:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9B7885941; Wed, 21 Feb 2024 18:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DzYocgmy" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA908004E; Wed, 21 Feb 2024 18:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541606; cv=none; b=cur42VPAlvnufPaCSnBoNYkjHV+u+yQ6a0DH0HMMGuO96SZj1Sz0gjWlXY/e7v9Td4r4FOZmUfeAPaiMpAj3NIsm/iPp2+9JjHV4pimTy/YbDpF//PU9U+6DVQCEj7sMZzx44FRwg9VOIoOAKDzYnkPD/i/MUZE+lhLl8qStYtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541606; c=relaxed/simple; bh=eMGM5YzEKrkILV3+3vpXcMdr1HJpfGEmL2Nq2vxUdlA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rrusEhhm4f4NoEd5s13C3tWDNLv5SiW2iBisPtXCES2o/PzDrkTtzNUe7O5wAQ0+9eWPzlKWHMljERRPSsEzdJfW5ZYnw2xiohYl613z4qRJDhq3pvAZvkSXh/U35PZXOaxctgyuuLQ1syK9xJKVePwva98A5DbXl1D0LiUvTHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DzYocgmy; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708541605; x=1740077605; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eMGM5YzEKrkILV3+3vpXcMdr1HJpfGEmL2Nq2vxUdlA=; b=DzYocgmyYE5xVXo3eH3x0l1WnYqxOITEAbCnclvpCPDwPvLgc88Y7XAD JcT9L2g36sCA1fcnZgQljIEcSssFhg9vgUTOilcEeOijcpi8gIN4+17Vx BNckqNnH116PBTYZarBYpMEliBP+76mZYQRSHMwWt4ycuf5r47O60sNJc 4yeWYTDUPjFD+jJLY5gshzCbcVQC5MTx8wHoecEO2EyLF1Vf3UuMm+1Qx jwnitTyRubUOfKSYsM3P9hrkoZlVjXM41/wNR4dHN3PZ5CVaITiezbvDR hLd/i6Nu9KFpAZpfu/xgDMg12l62XYQZZX6qVMy01fyNxfRo3JukF5QmM Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="2871965" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="2871965" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:53:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="913353183" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="913353183" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:53:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rcriO-00000006QtU-2avs; Wed, 21 Feb 2024 20:53:08 +0200 Date: Wed, 21 Feb 2024 20:53:08 +0200 From: Andy Shevchenko To: Florian Fainelli Cc: Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Jiri Slaby , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Al Cooper , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type Message-ID: References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> <20240221183442.4124354-3-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 21, 2024 at 10:47:13AM -0800, Florian Fainelli wrote: > On 2/21/24 10:31, Andy Shevchenko wrote: .. > > unsigned char iotype; /* io access style */ > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */ > > Nit: I would name this UPIO_UNKNOWN, or UPIO_NOTSET, unset means to me that > it was previously set and we undid that action, whereas unknown or not set > means we never did. Works for me. I will wait for a few days / week to have more reviews and likely testings to be collected. Would be nice if you be able to test on (some of) the hardware in the list of modified drivers. -- With Best Regards, Andy Shevchenko