Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2555642rdb; Wed, 21 Feb 2024 11:12:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU5TG8yjX866LPaCsEYNLVjktFxIl+PJ3WlZob8PZNLEcn6BwBWA/vJ4LK1xHUXOnCUpyE1x+13Ad0kEwFEMhSiGr/yyblsj+ZB2FtomA== X-Google-Smtp-Source: AGHT+IEhc62L60WEds1OSGN46TE6DrlOAVO4AZuKJBgSpjLaIiceknoxEJudaCXydvuFa4WZLzVe X-Received: by 2002:a17:906:b0d9:b0:a36:5079:d6cb with SMTP id bk25-20020a170906b0d900b00a365079d6cbmr13477091ejb.56.1708542751318; Wed, 21 Feb 2024 11:12:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708542751; cv=pass; d=google.com; s=arc-20160816; b=pJzQlTpqDtR3OunE8HoZfRXFqwu4KsRXgWWWeOhj5/A8O0ldiiI30VykdqgdJyQPti MlDu1xHouyu9UZ+fpmQf38o+N43pK0OiRaBXUq7ZEbbdeaXsbaX8DvHlWon1wXaGlNhG G26YLwCXZ1C9VUkj4d9a3gElgqnsZvKUFlr/JLnQ9Osq4hvYVdi5gWh7fPGt1UxnrfUI I7WZ/zU9dS/VLpgvokIXmuVySPV6mfqg3DZTfheMlPzGDCc77qUaGPzuIbLgLSaGY7fQ NSz0KtDHwO6h0DYZYad2hY8PHfMCglnN/DJkf82kqmQywq+QCEzjozspbcwniY6idqGF gKlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Kebo6WNO69mQZOfNv/8pnedxifg/tlOZHFfQyK1TELM=; fh=/bN4/v1C9yLxiTk4ZiO/1i+xzroct+TY948P2VzqhmE=; b=WEEhAmZ2dU+G0iU74s44qRMOqSnSmA/80kxroGMhLloLEW/UbglvQDDVYh4hZQwBF+ 2oq+45kawiW8txF6OTUyLtRxOf/MkeK5UA4hyfMua1nfkc4wX3xx2Cc1VQ+MaIqYM2wx gKIYSzLdxOb0R9B2GC69Zdudmgz5k5hkmALymRGq1kqsfObLtVTNXTaGuMCnpGK4Or6P H1hiKJWuJjLZnLC9LnosXjZe7aeZcjxTrz7Z4ucSkY2EpNerOn3I7vFNa3Ze6NTjH3XR nB75jbuWLA1RLOLu+J3+c8jpJpqxBW/0t8vtBzOjOqDlz9n7OTjLFGxUfsUXGVBS75YC uKGg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S0EFue7k; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gt15-20020a1709072d8f00b00a3f0d98c123si1791445ejc.560.2024.02.21.11.12.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 11:12:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S0EFue7k; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 149EE1F25C4F for ; Wed, 21 Feb 2024 19:12:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18F3C85C47; Wed, 21 Feb 2024 19:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S0EFue7k" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41ABE53E0D; Wed, 21 Feb 2024 19:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708542742; cv=none; b=ks4+Feql7ac70frirMcJVGUHS7szDLBTbeHD/bHceomoisydTNMrHirMLAetQxTdjE9M95qX0dXYEkAnE5PoXnxPZBGKAaEGjUwGJgR3JGx3UpavBMDXiNpx3vo9acOhvkhFAariU5nHXnDWc53meBCeLXO+qShSkVALix5+zfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708542742; c=relaxed/simple; bh=HbFX41l2n6H1gMRIKPuLIsTT8B4OgQtH1R+ivawPBWU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iKNQFxCMchv2AYXcpSMVZdZdWoJkKyrXtzn/CaGA+0eBXHC2Mw6X1jUtXoVFPcBSIl1Vgt1abzXo0Ymr9efoQVXiL7h9XPIWrEIopj4yq0VhxP6L8F5Z1PZa36iiLo6iV3eRb98KOuz2/DhH8lEuiCNjcxiGvQb4oZrr8pLTqLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S0EFue7k; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2036AC433F1; Wed, 21 Feb 2024 19:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708542741; bh=HbFX41l2n6H1gMRIKPuLIsTT8B4OgQtH1R+ivawPBWU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S0EFue7kFEUdqIvWdAj5WZ8oaEIpQXve75p0Zp39wv9G/XhchXr/uQZr3WY99YfJI DU9iUpuhYff+nYgZr+aTdbwWvLCJi/8dwuZQgf8fisNaceBFs7LFDgSRgX7grUSzJ8 PfW6dfYBsXDKhejCEZQ1BNmRhYti8ZGdwhpd1ClQJiwkODxRElKapuYyALdMt9eJuu WrAQsZQ6XqKOnF0ZiA0VQWqstIp0WUvg0Yq1/Or3+jLVkIszTkhhRyvN8ZerPKb1Kr gFA18LXZSoclHF9qXjC6nnr81I8+ZHkaYbNq5jt/5gSW20NYZ6kxMg6v0LNkRbxsOd zKo4SZxW68pTQ== Date: Wed, 21 Feb 2024 11:12:20 -0800 From: Jakub Kicinski To: Joe Damato Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Jesper Dangaard Brouer , Stanislav Fomichev , Amritha Nambiar , Larysa Zaremba , Lorenzo Bianconi , Tariq Toukan , Sridhar Samudrala , Alexei Starovoitov , Maciej Fijalkowski Subject: Re: [PATCH net-next 1/2] netdev-genl: Add ifname for queue and NAPI APIs Message-ID: <20240221111220.4e6b6170@kernel.org> In-Reply-To: <1708531057-67392-2-git-send-email-jdamato@fastly.com> References: <1708531057-67392-1-git-send-email-jdamato@fastly.com> <1708531057-67392-2-git-send-email-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 21 Feb 2024 07:57:29 -0800 Joe Damato wrote: > if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_ID) || > GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_TYPE) || > - GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX)) > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX) || > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFNAME)) This means user always has to provide both ifindex and ifname, right?