Received-SPF: pass (google.com: domain of linux-kernel+bounces-75371-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 21 Feb 2024 19:34:12 +0000
From: Conor Dooley <conor@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>, Len Brown <lenb@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-efi@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: Add post-init-supplier property
Message-ID: <20240221-emblaze-ripeness-7ad4e41343fa@spud>
References: <20240212213147.489377-1-saravanak@google.com>
 <20240212213147.489377-4-saravanak@google.com>
 <20240214-stable-anytime-b51b898d87af@spud>
 <CAGETcx-tBjfaLQqmGW=ap2N5FLK_gvTzxskA6sVsr_SUEpvomA@mail.gmail.com>
 <20240215-unstirred-rearrange-d619a2524a63@spud>
 <CAGETcx8EBta8dUSELUJ6_ibZABnnhSYX0VEGa8s-CbHFYuskkQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="pLmCPIAdI0+mCq/J"
Content-Disposition: inline
In-Reply-To: <CAGETcx8EBta8dUSELUJ6_ibZABnnhSYX0VEGa8s-CbHFYuskkQ@mail.gmail.com>


--pLmCPIAdI0+mCq/J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 20, 2024 at 08:13:31PM -0800, Saravana Kannan wrote:
> I made that fix and now I'm getting this:
> $ make DT_CHECKER_FLAGS=-m dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/post-init-suppliers.yaml
>   DTEX    Documentation/devicetree/bindings/post-init-suppliers.example.dts
>   LINT    Documentation/devicetree/bindings
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> /mnt/android/linus-tree/Documentation/devicetree/bindings/post-init-suppliers.yaml:
> 'oneOf' conditional failed, one must be fixed:
>         'unevaluatedProperties' is a required property
>         'additionalProperties' is a required property
>         hint: Either unevaluatedProperties or additionalProperties
> must be present
>         from schema $id: http://devicetree.org/meta-schemas/core.yaml#
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> /mnt/android/linus-tree/Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml:
> ignoring, error in schema: properties
> /mnt/android/linus-tree/Documentation/devicetree/bindings/post-init-suppliers.yaml:
> ignoring, error in schema:
> /mnt/android/linus-tree/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml:
> ignoring, error in schema: allOf: 0: then: properties: pinmux
> /mnt/android/linus-tree/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml:
> ignoring, error in schema: properties: lantiq,data-rate-bps
> /mnt/android/linus-tree/Documentation/devicetree/bindings/post-init-supplier.yaml:
> ignoring, error in schema:
> /mnt/android/linus-tree/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml:
> ignoring, error in schema: properties: honeywell,pmax-pascal
> /mnt/android/linus-tree/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml:
> ignoring, error in schema: properties: honeywell,pmax-pascal

>   DTC_CHK Documentation/devicetree/bindings/post-init-suppliers.example.dtb
> Documentation/devicetree/bindings/post-init-suppliers.example.dtb:0:0:
> /example-0/clock-controller@1000: failed to match any schema with
> compatible: ['vendor,soc4-gcc', 'vendor,soc1-gcc']
> Documentation/devicetree/bindings/post-init-suppliers.example.dtb:0:0:
> /example-0/clock-controller@1000: failed to match any schema with
> compatible: ['vendor,soc4-gcc', 'vendor,soc1-gcc']
> Documentation/devicetree/bindings/post-init-suppliers.example.dtb:0:0:
> /example-0/clock-controller@2000: failed to match any schema with
> compatible: ['vendor,soc4-dispcc', 'vendor,soc1-dispcc']
> Documentation/devicetree/bindings/post-init-suppliers.example.dtb:0:0:
> /example-0/clock-controller@2000: failed to match any schema with
> compatible: ['vendor,soc4-dispcc', 'vendor,soc1-dispcc']

FWIW, I don't see these or the other errors you see above. You really
need to get yourself a newer version of dt-schema, or else avoid
working on this using whatever castrated system google provides you with!

> But I guess the "oneOf" error is because the yaml is being treated as
> a description of a DT node and not a schema?

The oneOf is due to missing "additionalProperties: true" - As far as I
understand you need that regardless of whether this is going into
dt-schema or the kernel.

--pLmCPIAdI0+mCq/J
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdZQNAAKCRB4tDGHoIJi
0g3HAQDpIe4M9otvSpLROV6Ux41ghNaHIm5e1Qhx4Q295ZxF3QEAodiz/FUXPees
zSZSMDf2CLnO5KDtqoIy8tOHjOqzMw0=
=9UjH
-----END PGP SIGNATURE-----

--pLmCPIAdI0+mCq/J--