Received-SPF: pass (google.com: domain of linux-kernel+bounces-75438-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 21 Feb 2024 20:00:40 +0000
From: Conor Dooley <conor@kernel.org>
To: Ceclan Dumitru <mitrutzceclan@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>, linus.walleij@linaro.org,
	brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Walle <michael@walle.cc>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Leonard =?iso-8859-1?Q?G=F6hrs?= <l.goehrs@pengutronix.de>,
	Mike Looijmans <mike.looijmans@topic.nl>,
	Haibo Chen <haibo.chen@nxp.com>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	Ceclan Dumitru <dumitru.ceclan@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173
Message-ID: <20240221-grief-situated-575ce257f6ff@spud>
References: <20240220094344.17556-1-mitrutzceclan@gmail.com>
 <CAMknhBEZ7Y1Yx=wJGnfvYWGKPLas3pbCyY+sN8vrBzdkYO-A4w@mail.gmail.com>
 <0fa819d1-2a0f-4243-8e5f-a098528278c3@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Gq3jLFI+SugAYTYF"
Content-Disposition: inline
In-Reply-To: <0fa819d1-2a0f-4243-8e5f-a098528278c3@gmail.com>


--Gq3jLFI+SugAYTYF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> >> +
> >> +      diff-channels:
> >> +        items:
> >> +          minimum: 0
> >> +          maximum: 31
> >> +
> >=20
> > Are we missing `bipolar: true` here? (since we have
> > unevaluatedProperties: false)
> >=20
>=20
> No, since we are referencing the adc schema "$ref: adc.yaml"
> Which contains:
> """
>   bipolar:
>=20
>     $ref: /schemas/types.yaml#/definitions/flag
>=20
>     description: If provided, the channel is to be used in bipolar mode.
> """

FWIW, the difference here is whether or not the binding for the device
contains "additionalProperties: false" or "unevaluatedProperties: false".
The former requires "bipolar: true", the latter does not.

Cheers,
Conor.

--Gq3jLFI+SugAYTYF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdZWaAAKCRB4tDGHoIJi
0h0tAQC4eO1DowojEvVagFKPsHMUGG8afYTYGfkExi7A6fMnhAEAjWIamj131REA
D7r8rgqBpDk+FKzG6L4DcLAG3X2LMAU=
=rUvt
-----END PGP SIGNATURE-----

--Gq3jLFI+SugAYTYF--