Received-SPF: pass (google.com: domain of linux-kernel+bounces-75471-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240221091908.1759083-1-tmricht@linux.ibm.com>
In-Reply-To: <20240221091908.1759083-1-tmricht@linux.ibm.com>
From: Ian Rogers <irogers@google.com>
Date: Wed, 21 Feb 2024 12:37:59 -0800
Message-ID: <CAP-5=fVY0f4SkQ-F0KC2JXuayZyPHwXvsdS8dbMEvF8zg0vdwA@mail.gmail.com>
Subject: Re: [PATCH] perf list: fix short description for some cache events
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, 
	acme@kernel.org, krebbel@linux.ibm.com, svens@linux.ibm.com, 
	gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 1:20=E2=80=AFAM Thomas Richter <tmricht@linux.ibm.c=
om> wrote:
>
> Correct the short description of the following events:
> DCW_REQ, DCW_REQ_CHIP_HIT, DCW_REQ_DRAWER_HIT, DCW_REQ_IV,
> DCW_ON_CHIP, DCW_ON_CHIP_IV, DCW_ON_CHIP_CHIP_HIT,
> DCW_ON_CHIP_DRAWER_HIT, CW_ON_MODULE, DCW_ON_DRAWER,
> DCW_OFF_DRAWER, IDCW_ON_MODULE_IV, IDCW_ON_MODULE_CHIP_HIT,
> IDCW_ON_MODULE_DRAWER_HIT, IDCW_ON_DRAWER_IV, IDCW_ON_DRAWER_CHIP_HIT,
> IDCW_ON_DRAWER_DRAWER_HIT, IDCW_OFF_DRAWER_IV, IDCW_OFF_DRAWER_CHIP_HIT,
> IDCW_OFF_DRAWER_DRAWER_HIT, ICW_REQ, ICW_REQ_IV, CW_REQ_CHIP_HIT,
> ICW_REQ_DRAWER_HIT, ICW_ON_CHIP, ICW_ON_CHIP_IV, ICW_ON_CHIP_CHIP_HIT,
> ICW_ON_CHIP_DRAWER_HIT, ICW_ON_MODULE and ICW_OFF_DRAWER.
>
> The second Cache should be L2-Cache.
>
> Output before (display diff of the first four events)
>   # perf list -d
>   DCW_REQ
>        [Directory Write Level 1 Data Cache from Cache. Unit: cpum_cf]
>   DCW_REQ_CHIP_HIT
>        [Directory Write Level 1 Data Cache from Cache with Chip HP \
>                Hit. Unit: cpum_cf]
>   DCW_REQ_DRAWER_HIT
>        [Directory Write Level 1 Data Cache from Cache with Drawer \
>                HP Hit. Unit: cpum_cf]
>   DCW_REQ_IV
>        [Directory Write Level 1 Data Cache from Cache with Intervention. =
\
>                Unit: cpum_cf]
>
> Output after:
>   # perf list -d
>   DCW_REQ
>        [Directory Write Level 1 Data Cache from L2-Cache. Unit: cpum_cf]
>   DCW_REQ_CHIP_HIT
>        [Directory Write Level 1 Data Cache from L2-Cache with Chip HP \
>                Hit. Unit: cpum_cf]
>   DCW_REQ_DRAWER_HIT
>        [Directory Write Level 1 Data Cache from L2-Cache with Drawer \
>                HP Hit. Unit: cpum_cf]
>   DCW_REQ_IV
>        [Directory Write Level 1 Data Cache from L2-Cache with \
>                Intervention. Unit: cpum_cf]
>
> Fixes: 7f76b3113068 ("perf list: Add IBM z16 event description for s390")
> Reported-by: Andreas Krebbel <krebbel@linux.ibm.com>
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> Acked-by: Andreas Krebbel <krebbel@linux.ibm.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian