Received-SPF: pass (google.com: domain of linux-kernel+bounces-75487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 21 Feb 2024 22:01:44 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: linux-pm@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] power: reset: restart-poweroff: convert to module
Message-ID: <75ljt3czi7ve3nqaqb52lezxlqu2o5wpxeivlbe2gwlg2vjd6s@q54nzrsondtu>
References: <20240221174610.3560775-1-alexander.sverdlin@siemens.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3q6sgkglmk7n5vqu"
Content-Disposition: inline
In-Reply-To: <20240221174610.3560775-1-alexander.sverdlin@siemens.com>


--3q6sgkglmk7n5vqu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Feb 21, 2024 at 06:46:07PM +0100, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>=20
> The necessity of having a fake platform device for a generic, platform
> independent functionality is not obvious.
> Some platforms requre device tree modification for this, some would requi=
re
> ACPI tables modification, while functionality may be useful even to
> end-users without required expertise. Convert the platform driver to
> a simple module.
>=20
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> ---
> This RFC is merely to understand if this approach would be accepted.
> Converting to "tristate" could follow or preceed this patch.

1. You cannot easily make this tristate, because of machine_restart().
2. This is already using module_platform_driver(), so this has
   nothing to do with making it a module like the subject suggests.
3. This no longer applies, since the driver is now properly using
   devm_register_sys_off_handler instead of pm_power_off.
4. It's intentional, that a device needs to be described. This is
   _not_ meant as a general purpose poweroff driver. It's intended
   to be used with bootloader support, which keeps the system off
   as described in the comment at the start of the file.

So: NAK

-- Sebastian

> diff --git a/drivers/power/reset/restart-poweroff.c b/drivers/power/reset=
/restart-poweroff.c
> index 28f1822db1626..e1d94109f6823 100644
> --- a/drivers/power/reset/restart-poweroff.c
> +++ b/drivers/power/reset/restart-poweroff.c
> @@ -20,7 +20,7 @@ static void restart_poweroff_do_poweroff(void)
>  	machine_restart(NULL);
>  }
> =20
> -static int restart_poweroff_probe(struct platform_device *pdev)
> +static int __init restart_poweroff_init(void)
>  {
>  	/* If a pm_power_off function has already been added, leave it alone */
>  	if (pm_power_off !=3D NULL) {
> @@ -33,12 +33,10 @@ static int restart_poweroff_probe(struct platform_dev=
ice *pdev)
>  	return 0;
>  }
> =20
> -static int restart_poweroff_remove(struct platform_device *pdev)
> +static void __exit restart_poweroff_exit(void)
>  {
>  	if (pm_power_off =3D=3D &restart_poweroff_do_poweroff)
>  		pm_power_off =3D NULL;
> -
> -	return 0;
>  }
> =20
>  static const struct of_device_id of_restart_poweroff_match[] =3D {
> @@ -47,15 +45,8 @@ static const struct of_device_id of_restart_poweroff_m=
atch[] =3D {
>  };
>  MODULE_DEVICE_TABLE(of, of_restart_poweroff_match);
> =20
> -static struct platform_driver restart_poweroff_driver =3D {
> -	.probe =3D restart_poweroff_probe,
> -	.remove =3D restart_poweroff_remove,
> -	.driver =3D {
> -		.name =3D "poweroff-restart",
> -		.of_match_table =3D of_restart_poweroff_match,
> -	},
> -};
> -module_platform_driver(restart_poweroff_driver);
> +module_init(restart_poweroff_init);
> +module_exit(restart_poweroff_exit);
> =20
>  MODULE_AUTHOR("Andrew Lunn <andrew@lunn.ch");
>  MODULE_DESCRIPTION("restart poweroff driver");
> --=20
> 2.43.0
>=20

--3q6sgkglmk7n5vqu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmXWZKwACgkQ2O7X88g7
+pqegg/+NsgK3lSsW8+BxUMAhXzCRTyGzWp0xmMAJ8pVgq0fBdn4IG/JUe8yTknm
mzdtmWWqmrMQBOUXZ32lwD/nugScKBkVZd9INv1O6CV+lgfq7S5zTOtmux7S9Jgu
uVGKKM4v6rDpXvauWjenWUwj6F0A7vPXcGCGKY9mqf4v4ze7Vpaj7FySPSOa/fur
/rZw5pMPaTNHwGXiLUkI0ptCNVA8WnXBlkKYIkPsHbNN4c4Zmoqlx9lgROBBx0h7
ptIZ039+svq6V22lxH5clWWnGfH7oW6Cgkj7tCNpmn5/1glXxvsR0MwpHWfE11F8
Lk4+JpbKgD9mEdSPE9niiLBAkE1/Des/k9bb+PsuKXpt9DjP6Bstku6aaQ9FT+nX
qU3HXjrxB1+L8z7vHKiTVY7qvsx6yWO5mKAey0+Sk9u+cMNDXGug6+QO/+mmF/O+
PNR6n+BRSTDpKSdtvEb8nUdZGPNIikNKIT9AKX/V94h8eXVyABql+OPknSP8CS30
oeTuh4YjlJzW48IaGUVFUZTqMTqQDfQ/U0B614KF0F+aqZjY+nipAcYu33MRYzzL
Kg+twNccclnZR591CGQbHAeL6CCqFGXJ1h9ZbVR4e/6oC3RAnMFn8++5la/Gn87H
kNXEh8YtDgZXzud5LpASZOKMjuqLwwG0c41ooAEfSFfLVsHnwDM=
=/bxz
-----END PGP SIGNATURE-----

--3q6sgkglmk7n5vqu--