Received-SPF: pass (google.com: domain of linux-kernel+bounces-75514-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-153-g7e3bb84806-fm-20240215.007-g7e3bb848
Precedence: bulk
MIME-Version: 1.0
Message-Id: <e33a59f7-cf0e-4b63-b994-752d1e77652a@app.fastmail.com>
In-Reply-To: <20240221202655.2423854-1-jannh@google.com>
References: <20240221202655.2423854-1-jannh@google.com>
Date: Wed, 21 Feb 2024 22:18:47 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jann Horn" <jannh@google.com>,
 "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
 "Nick Desaulniers" <ndesaulniers@google.com>,
 "Miguel Ojeda" <ojeda@kernel.org>, "Zhen Lei" <thunder.leizhen@huawei.com>,
 linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
 "Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH 1/2] kallsyms: get rid of code for absolute kallsyms
Content-Type: text/plain

On Wed, Feb 21, 2024, at 21:26, Jann Horn wrote:
> To compile code for absolute kallsyms, you had to turn off
> KALLSYMS_BASE_RELATIVE. I think based on the way it was declared in
> Kconfig (without a string after "bool"), it wasn't even possible to
> select it.
>
> Get rid of this config option, as preparation for some kallsyms
> optimizations that would otherwise be infeasible.
>
> Signed-off-by: Jann Horn <jannh@google.com>

Nice catch!

The code was needed until cf8e8658100d ("arch: Remove
Itanium (IA-64) architecture"), and we missed that this
allowed the cleanup you now did.

Acked-by: Arnd Bergmann <arnd@arndb.de>

     Arnd