Received-SPF: pass (google.com: domain of linux-kernel+bounces-75519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <20240213055554.1802415-4-ankur.a.arora@oracle.com>
 <ZczJU8uZdbRKvcAE@FVFF77S0Q05N> <87v86k8opr.ffs@tglx>
 <877ciykc9v.fsf@oracle.com> <875xyhhhju.ffs@tglx>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
        Ankur Arora
 <ankur.a.arora@oracle.com>, linux-kernel@vger.kernel.org,
        peterz@infradead.org, torvalds@linux-foundation.org,
        paulmck@kernel.org, akpm@linux-foundation.org, luto@kernel.org,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org,
        willy@infradead.org, mgorman@suse.de, jpoimboe@kernel.org,
        jgross@suse.com, andrew.cooper3@citrix.com, bristot@kernel.org,
        mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
        glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
        mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Arnd Bergmann
 <arnd@arndb.de>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 03/30] thread_info: tif_need_resched() now takes
 resched_t as param
In-reply-to: <875xyhhhju.ffs@tglx>
Date: Wed, 21 Feb 2024 13:22:15 -0800
Message-ID: <87il2hfr7c.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?MWXFfuz5nbb8kunbJkJUDC6Wo8GrCmz+sey4eV/QvSnbugvv3C116vvV325x?=
 =?us-ascii?Q?GUQAo81qE+c7ZQNfhMxXnGPMC8bpOpwT81VuPau3WFFGbx4l50CFRtnBK5YP?=
 =?us-ascii?Q?57y8nJ18WVFDs5Bey981tvQMCfviHkBD6kwFSs7Zfzddy3N0wkeQgKjILZNG?=
 =?us-ascii?Q?bqSrabS5dxYxoRVIYFzuQ52hqz6xgIRGR0yiOo/digmCb+jWnzQnuutCzHZ/?=
 =?us-ascii?Q?UIB+8iyKLhEncKt+z/94u3MHLTl558X4EqoK+kPuC1069hBcDnU+qKl6Dbdv?=
 =?us-ascii?Q?mT0gxit/NGC53M9ngXB1rgVWjWeyVRUpNlOwidtUCSJ0doYy3Hb+AfVj4KJ/?=
 =?us-ascii?Q?R9l8+D/oq6ZqhMJzIFmJ6bAUEAjRoz6ycciSf4tWEiRn2DilzrvFJOVXvSVr?=
 =?us-ascii?Q?0LSxAofH1APkHBagUUsqnGy/BeneQgQrDW44ZSD3ey3wM+R6FOK9NARX3N2f?=
 =?us-ascii?Q?Bljd2XJ1F1BDY9KsSCjBzCvEiWi9cOAyauhKhbhdnhVY2c14z0ciK4BveKP7?=
 =?us-ascii?Q?0b+oblc0/BpoWB3zTzI+5/xIV5bHb+ohTRQJczElTwcH1FmuUV+zcaAi3zta?=
 =?us-ascii?Q?M6xOEz9SyYMkrevlPjn6DCB0kfgkOJmJI7RaIr6rsjEjlC3Ac3WBA7pXZEy2?=
 =?us-ascii?Q?kCRkAPep+Bq9Tu1tf08KMZcWFV73Uq/vfSsy+cfam73dtbBI/eI6vM7BOZ4a?=
 =?us-ascii?Q?Ha3SYNgxen+Y7RWi2ZErGsNewHkAiGRGg8FjgeCIKjj7T0tYTB3hhBKc4dJW?=
 =?us-ascii?Q?m+Z3y3h6sGrDntvoMHK7UHwTjP1oKWfQfe2bW9GoSlnk8sOM71/u/CEGPvn9?=
 =?us-ascii?Q?MpBJtser3aA0nF1VrIqMzhUFissix2OOGPMkbfLfPs6bzzy9MtcwtKFBqnv4?=
 =?us-ascii?Q?QGoaxaG4RZYcPivXsggC3zZXNM2Q8I0IZsmzleVmom2FjZCX53FLghDxdkX+?=
 =?us-ascii?Q?uHX+StHNM1Ucy0Y4XvBrEYsv1wy/6h4BdI8VLxQyaSJQyOlxIPY1+ezALMst?=
 =?us-ascii?Q?DjPSLdemOSuLW0YycmhT4Ot4CVpoBqB1sx5bS+Mxyitmgz0stCHpz2jnoVjF?=
 =?us-ascii?Q?E9Lwo+LowUBOBR4YvEZUoT5Fnh7EpTiOhRozClCTUkZ84jHhsHXVqJyG8Mc3?=
 =?us-ascii?Q?LmqPKOzQid4XbCGfLMzeTjOrEgLMq/Lu0kSX8x1W5N4BzY0ZMciLP/c1J1X9?=
 =?us-ascii?Q?6NqTpLRg0o1y7j2chU9J/JQye1UtkMISvG6vm127lmuFbRTHRqXtWrAt8GT8?=
 =?us-ascii?Q?Ql8TLgs85mpAR/3TLriuLRN2/5nTGvRU7RMNmoISB42i8ichVUGoFSbwzDtO?=
 =?us-ascii?Q?k9YdS5Ye7pJ5buMQMijBRf7QPpE+KGR7Pq6MDvHnZdKIZpHyT7am4A6eO7Fc?=
 =?us-ascii?Q?KdfbhG0/VyLHPL8O38brL4AcUeopnI3reCgXDDusZoTbGCVwvqXvRMUDtd9t?=
 =?us-ascii?Q?Io5ai4v1CqzRprL0tB3EYiMB3X5BsZ5p70mxGg85eYdnxkJI02Cy9K6kcROx?=
 =?us-ascii?Q?uuNekJXAGhx3aBeREjERMfZ4IoI/UIumNkIzDlpFhiMOjoeagF+b1HyXZ5lv?=
 =?us-ascii?Q?GwlKifdbElSgtX6DxH/+lvYf0GwtsRfDwBZ10dLV2tlpXD7JDA6Tg7Y2DpQS?=
 =?us-ascii?Q?4A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	077G335tT9fzH/eWl6o8DEE8tIy7iOcxvIKFYY4nUz0MOpD+Cp+4QjQ1CrPGZdVcxTIVt1sZfqBczSXh57vqhF2+7fh20pLqSNGF61X/AJWQNIJo9r4WpKViJhD6rpiu7o4Ab8qDMIQMjedCs7StYMc7bqKkg52k6/EjKzbyZJDLmxc1tCIZSrTRPuCrdC6/gaZlG3aBL8PvU8uqPXU3aFmBZZ2WoaX/TJaRoNocYV3t1etLUvBFZa6ARYdHuTmgM1qDloGI34YtZZfiRBQVrGSI2A1u+qHl8zsdyhND29cxqB/hNw+zjxK1F/wY+EyuWfeqEDiL2rhaI3eS7B3lXiwMe9Z6kEm0FbHO7Slx8IMbDNxWaCZ4OI/x4QVFbfctiAjA7ewgsYq2RTqS29fxyrOn0fP7EtrNmSp5zJjManObXOc+OXaCzFcx/4m0s0yeLttN37eN3RXPOwFHp0h5k98zwDzCzSXFcdOWF2Xm345lIC/8qbqm+z9vUjQJTRYIUYmWiC1Z0zVmOUXrwjijs5kIbjkzETCt+n0hOJu1xXPJtLL/7qizIhMdOHLg24AAanyCL2TO81ZpvvPLl9z7KpB8gRc+A0WN+usjNPwXSVw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5003007e-b621-4ae7-f9c4-08dc33231f64
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 21:21:52.4546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WzPDQrisAxDK0yp+6Sz+rey2UqOfMhc7if4P2UnGP4nhw1wJJISnFsK2aHfBEOb0IpL2iDNPTZ1iL0qgjTD1HFFf1Vt9O80cCMGuIAOfNvw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6612
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-21_09,2024-02-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=706
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402210167
X-Proofpoint-GUID: dWoEUpfPdYPl9HZcOObB_HJpTbTxnqQS
X-Proofpoint-ORIG-GUID: dWoEUpfPdYPl9HZcOObB_HJpTbTxnqQS


Thomas Gleixner <tglx@linutronix.de> writes:

> On Tue, Feb 20 2024 at 14:21, Ankur Arora wrote:
>> Thomas Gleixner <tglx@linutronix.de> writes:
>>>> static __always_inline bool tif_need_resched_lazy(void)
>>>> {
>>>> 	return IS_ENABLED(CONFIG_PREEMPT_AUTO) &&
>>>> 	        __tif_need_resched(TIF_NEED_RESCHED_LAZY);
>>>> }
>>>
>>> Yes please.
>>
>> As I wrote to Mark in the sibling subthread, I think exposing
>> the lazy variants outside of the scheduler isn't really needed.
>
> But having a proper wrapper inline in the scheduler code (local header)
> makes still a lot of sense.

Yeah, there are a few callsites where this will help. Will do.

Thanks

--
ankur