Received-SPF: pass (google.com: domain of linux-kernel+bounces-75580-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 21 Feb 2024 15:59:06 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Yury Norov
	<yury.norov@gmail.com>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, Jani Nikula <jani.nikula@linux.intel.com>,
	<intel-xe@lists.freedesktop.org>, <intel-gfx@lists.freedesktop.org>, "Jani
 Nikula" <jani.nikula@intel.com>
Subject: Re: Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks
Message-ID: <btssirjumey2kcp5dyhe6m3embdwd5bswjz3c6swrhxfijfhld@lztxaptkegw6>
References: <20240208074521.577076-1-lucas.demarchi@intel.com>
 <20240208074521.577076-2-lucas.demarchi@intel.com>
 <CAA8EJpprfrtOjNzT6TFhV1n6MXzLdTahanfxcRW4uVjeHaBduA@mail.gmail.com>
 <ZdZlVn9BI-0q1Xdn@smile.fi.intel.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <ZdZlVn9BI-0q1Xdn@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t0+hVZM9O7bpkrVjANFHZn/+6adcSG8sGsxw/Wy/siSoMlXYJViHB3E7hd/G?=
 =?us-ascii?Q?CkHYFZUHzWZeFDADan63nICD06B7VmnmQegMHU355wmjNAJTWaJK4qySZaJI?=
 =?us-ascii?Q?E2x/Uo19XJpf8ldG7F494ZTcwtqlw60vSOJWSjR6xhF88NOV5WTA5/MTx1nD?=
 =?us-ascii?Q?61daJ8w6vFCCU0ZmQ4kBWTkA5x3NBcmgVSkwuttyytbSOr86n82GeTBKTaNO?=
 =?us-ascii?Q?uR5z3cP8LirIXLcPiKcqI/78pkFjMcTDeiuT8wQ9txUNYtI1484qxpCRyX1e?=
 =?us-ascii?Q?4iH9jiwccoh2yy2a7ZI5pB/nNw2Y4NgMljYa0zwnM10YytHc4Ol00zql3RZk?=
 =?us-ascii?Q?7Ep8ipZI+uz9KdYzETm0lhMOqJgzIDK7xagHDPAiOCHcNd0YvmC1sjlILzhR?=
 =?us-ascii?Q?h0uYQobXZ4Bx6TlnYke6IxshHf13KKDoLoH9tGfm0GYG2lI0ffavV7pnxJrW?=
 =?us-ascii?Q?07Gn1Cb+FE59V9LlWvv+4NCd9YuEMIkdHrdceKG1YIE8Q20pyHzkfsx4XtNb?=
 =?us-ascii?Q?G3S20QEBj/k/SD7FzIsqwdhki2OnN7j3WYcaIKJBxOQ8WCPHp/LZuwhLMyUe?=
 =?us-ascii?Q?KxlAAaqP80SIycC0LVUDZn4Fiej6WCNjBR5wEZveNcwcM779q1FNyWbEZ2sC?=
 =?us-ascii?Q?nOaT9SjULfSF1RV68AaQSO3P++h1M/YKx1MHksAPeAfvQqEzx7DS9zyPeOUv?=
 =?us-ascii?Q?gTTWp/UShx0A4ANBMLtEj2HBqUJFjvKmzjBwzgFh5gLwGC/XV7bBC8Ky6TRg?=
 =?us-ascii?Q?m74S0zVuQ+SPLQdh8hIKmi0DZhfaZt2KiWdjCZXyzfKIym/KvXzMntacVX1Z?=
 =?us-ascii?Q?AXVoUR7kRMHUVfQxtplDBRY9RmVAW4seZrohYa5DLTpyNe1v2k43i/goI6qV?=
 =?us-ascii?Q?z5zaCCfXiSrq0xAM926c7o7UxbpdBXOoK4pQyImvKIlo/OSh/ylRNXqwNNTg?=
 =?us-ascii?Q?83OFMim50TwVPUjp//VGB/jMyi4oocKT8WF1pZWA/FmsLxQdpwpUmnjWKHTU?=
 =?us-ascii?Q?pdkI72nfSt/Uck8SintMeSZmTwma2jJvL4IvRdiJL+NzvFT6ZpeeQ9js599l?=
 =?us-ascii?Q?DtF15V5RCSyGxGBg47mIzOCk+v9x8H19guFBaFvB5VeeASnX1LQxP/7fDukF?=
 =?us-ascii?Q?zK9cFqNeFv7nTz/k7g6l+84fgsMNIOGdHfeRblMD1GruPYNC/mKLY75vrOdU?=
 =?us-ascii?Q?eEEFMqRHYgB9dIMbTj1u29rvK5lh7+vFmW/n1qrb9gK0TqpjXjGPbb7ojUAk?=
 =?us-ascii?Q?YRxQ+OHS/fK99j2Dqttaq4qr2X3AZIGIxEojj+Y45+UzM1CuTmXH75AlTbeH?=
 =?us-ascii?Q?vkJEtNuJAELEuTgyuzsxa42Bziip9e5JFMURZ6gri/IPLuW/NE7AwpL0OTq0?=
 =?us-ascii?Q?1Jpdy96lk3WwsCbM99Me1uoQVfxy4QDYHAxQbYWzw7j0pIuuG30+wGGyLEta?=
 =?us-ascii?Q?tm7qF1YR36TeuaZvTDa9EyGSPMt0HkyGgWEutA50JMnS0jzNmlZfVAFDkx3g?=
 =?us-ascii?Q?86GyLgAo6YBUA+LzhoI3RyLMWF+JiJo0k4WB7UrLBN0/FvXpRobdcc34RIht?=
 =?us-ascii?Q?S9dETvTqjjwRJQH20neOsOtJUHqhE4ps2LogpGA6PcAIa/Wzj8UeBY/tVL2s?=
 =?us-ascii?Q?LQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11fb31bf-1282-44d2-23f9-08dc33285441
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 21:59:08.6558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5y5PGFW1l7rzE8x6TEP0NvHisQvIXTwMs0G3jeGnx4Itm0qMykNVA0IfiJ42TqOkXPJd0lZvxIGQs34zmfroY2Soe/0f3ydLhnr1qW1CyFg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8419
X-OriginatorOrg: intel.com

On Wed, Feb 21, 2024 at 11:04:22PM +0200, Andy Shevchenko wrote:
>On Wed, Feb 21, 2024 at 10:30:02PM +0200, Dmitry Baryshkov wrote:
>> On Thu, 8 Feb 2024 at 09:45, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>
>...
>
>> > +#define BITS_PER_TYPE(type)    (sizeof(type) * BITS_PER_BYTE)
>
>Can sizeof() be used in assembly?
>
>...
>
>> > -#define __GENMASK(h, l) \
>> > -       (((~UL(0)) - (UL(1) << (l)) + 1) & \
>> > -        (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
>> > -#define GENMASK(h, l) \
>> > -       (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
>
>> > +#define __GENMASK(t, h, l) \
>> > +       (GENMASK_INPUT_CHECK(h, l) + \
>> > +        (((t)~0ULL - ((t)(1) << (l)) + 1) & \
>> > +        ((t)~0ULL >> (BITS_PER_TYPE(t) - 1 - (h)))))
>
>Nevertheless, the use ~0ULL is not proper assembly, this broke initial
>implementation using UL() / ULL().

indeed.

>
>
>> > -#define __GENMASK_ULL(h, l) \
>> > -       (((~ULL(0)) - (ULL(1) << (l)) + 1) & \
>> > -        (~ULL(0) >> (BITS_PER_LONG_LONG - 1 - (h))))
>> > -#define GENMASK_ULL(h, l) \
>> > -       (GENMASK_INPUT_CHECK(h, l) + __GENMASK_ULL(h, l))
>
>Ditto.

problem here seems actually because of the cast to the final type. My
previous impl was avoiding that, but was too verbose compared to this.

I will look at reverting this.

Lucas De Marchi

>
>> > +#define GENMASK(h, l)          __GENMASK(unsigned long,  h, l)
>> > +#define GENMASK_ULL(h, l)      __GENMASK(unsigned long long, h, l)
>> > +#define GENMASK_U8(h, l)       __GENMASK(u8,  h, l)
>> > +#define GENMASK_U16(h, l)      __GENMASK(u16, h, l)
>> > +#define GENMASK_U32(h, l)      __GENMASK(u32, h, l)
>> > +#define GENMASK_U64(h, l)      __GENMASK(u64, h, l)
>>
>> This breaks drm-tip on arm64 architecture:
>>
>> arch/arm64/kernel/entry-fpsimd.S: Assembler messages:
>> 465arch/arm64/kernel/entry-fpsimd.S:271: Error: found 'l', expected: ')'
>> 466arch/arm64/kernel/entry-fpsimd.S:66: Info: macro invoked from here
>> 467arch/arm64/kernel/entry-fpsimd.S:271: Error: found 'l', expected: ')'
>> 468arch/arm64/kernel/entry-fpsimd.S:66: Info: macro invoked from here
>> 469arch/arm64/kernel/entry-fpsimd.S:271: Error: found 'l', expected: ')'
>> 470arch/arm64/kernel/entry-fpsimd.S:66: Info: macro invoked from here
>> 471arch/arm64/kernel/entry-fpsimd.S:271: Error: found 'l', expected: ')'
>> 472arch/arm64/kernel/entry-fpsimd.S:66: Info: macro invoked from here
>> 473arch/arm64/kernel/entry-fpsimd.S:271: Error: unexpected characters
>> following instruction at operand 3 -- `bic x2,x1,(0+(((unsigned
>> long)~0ULL-((unsigned long)(1)<<(0))+1)&((unsigned
>> long)~0ULL>>((sizeof(unsigned long)*8)-1-(3)))))'
>> 474arch/arm64/kernel/entry-fpsimd.S:66: Info: macro invoked from here
>> 475arch/arm64/kernel/entry-fpsimd.S:282: Error: found 'l', expected: ')'
>> 476arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
>> 477arch/arm64/kernel/entry-fpsimd.S:282: Error: found 'l', expected: ')'
>> 478arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
>> 479arch/arm64/kernel/entry-fpsimd.S:282: Error: found 'l', expected: ')'
>> 480arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
>> 481arch/arm64/kernel/entry-fpsimd.S:282: Error: found 'l', expected: ')'
>> 482arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
>> 483arch/arm64/kernel/entry-fpsimd.S:282: Error: unexpected characters
>> following instruction at operand 3 -- `bic x2,x1,(0+(((unsigned
>> long)~0ULL-((unsigned long)(1)<<(0))+1)&((unsigned
>> long)~0ULL>>((sizeof(unsigned long)*8)-1-(3)))))'
>> 484arch/arm64/kernel/entry-fpsimd.S:98: Info: macro invoked from here
>
>-- 
>With Best Regards,
>Andy Shevchenko
>
>