Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758363AbXL3VTs (ORCPT ); Sun, 30 Dec 2007 16:19:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755004AbXL3VT3 (ORCPT ); Sun, 30 Dec 2007 16:19:29 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:52500 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbXL3VT2 (ORCPT ); Sun, 30 Dec 2007 16:19:28 -0500 Date: Sun, 30 Dec 2007 22:00:07 +0100 From: Ingo Molnar To: "H. Peter Anvin" Cc: Bodo Eggert <7eggert@gmx.de>, Alan Cox , Linus Torvalds , Rene Herman , dpreed@reed.com, Islam Amer , Pavel Machek , Ingo Molnar , Andi Kleen , Thomas Gleixner , Linux Kernel Subject: Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override Message-ID: <20071230210007.GA3136@elte.hu> References: <9FXbU-3M4-11@gated-at.bofh.it> <9G2Om-4hg-1@gated-at.bofh.it> <9G7O3-3O2-7@gated-at.bofh.it> <9G8qN-4TX-13@gated-at.bofh.it> <20071230181004.GA21968@elte.hu> <477805F1.4070201@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <477805F1.4070201@zytor.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2321 Lines: 69 * H. Peter Anvin wrote: > Ingo Molnar wrote: >> * Bodo Eggert <7eggert@gmx.de> wrote: >> >>> BTW: The error function in linux-2.6.23/arch/i386/boot/compressed/misc.c >>> uses while(1) without cpu_relax() in order to halt the machine. Is this >>> fixed? Should it be fixed? >> >> this is early bootup so there's no need to be "nice" to other cores or >> sockets - none of them are really running. >> > > It probably should actually HLT, to avoid sucking power, and stressing > the thermal system. We're dead at this point, and the early 486's > which had problems with HLT will lock up - we don't care. ok. Like the patch below? Ingo ----------> Subject: x86: hlt on early crash From: Ingo Molnar H. Peter Anvin wrote: > It probably should actually HLT, to avoid sucking power, and stressing > the thermal system. We're dead at this point, and the early 486's > which had problems with HLT will lock up - we don't care. Signed-off-by: Ingo Molnar --- arch/x86/boot/compressed/misc_32.c | 2 +- arch/x86/boot/compressed/misc_64.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: linux-x86.q/arch/x86/boot/compressed/misc_32.c =================================================================== --- linux-x86.q.orig/arch/x86/boot/compressed/misc_32.c +++ linux-x86.q/arch/x86/boot/compressed/misc_32.c @@ -339,7 +339,7 @@ static void error(char *x) putstr(x); putstr("\n\n -- System halted"); - while(1); /* Halt */ + asm("cli; hlt"); /* Halt */ } asmlinkage void decompress_kernel(void *rmode, unsigned long end, Index: linux-x86.q/arch/x86/boot/compressed/misc_64.c =================================================================== --- linux-x86.q.orig/arch/x86/boot/compressed/misc_64.c +++ linux-x86.q/arch/x86/boot/compressed/misc_64.c @@ -338,7 +338,7 @@ static void error(char *x) putstr(x); putstr("\n\n -- System halted"); - while(1); /* Halt */ + asm("cli; hlt"); /* Halt */ } asmlinkage void decompress_kernel(void *rmode, unsigned long heap, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/