Received-SPF: pass (google.com: domain of linux-kernel+bounces-75611-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 21 Feb 2024 23:45:14 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: phone-devel@vger.kernel.org, kernel list <linux-kernel@vger.kernel.org>,
	fiona.klute@gmx.de, martijn@brixit.nl, samuel@sholland.org,
	heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	megi@xff.cz
Subject: Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding
 document
Message-ID: <ZdZ8+vwoILO3pf0h@duo.ucw.cz>
References: <ZcaCXYOf6o4VNneu@duo.ucw.cz>
 <3a662ef2-1888-4f24-bebe-3ce32da9d277@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="VEdryfHzoLY8OQfU"
Content-Disposition: inline
In-Reply-To: <3a662ef2-1888-4f24-bebe-3ce32da9d277@linaro.org>


--VEdryfHzoLY8OQfU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > +  reset-gpios:
> > +    maxItems: 1
>=20
> blank line
>=20
> > +  avdd10-supply:
> > +    description:
> > +      1.0V power supply
>=20
> Keep description in one line and add a blank line. This code is not that
> readable.
>=20
> > +  i2c-supply:
> > +    description:
> > +      Power supply
>=20
> Drop all useless descriptions (so : true)

Ok, fixed, I hope I got it right.

> > +  vbus-supply:
> > +    description:
> > +      Power supply
> > +  vbus_in-supply:
>=20
> No underscores in property names.

Ok.

> > +  connector:
> > +    type: object
> > +    $ref: ../connector/usb-connector.yaml
>=20
> Full path, so /schemas/connector/......
>=20
> > +    unevaluatedProperties: false
>=20
> Drop

> > +
> > +    description:
> > +      Properties for usb c connector.
>=20
> > +
> > +    properties:
> > +      compatible:
> > +        const: usb-c-connector
> > +
> > +      power-role: true
> > +
> > +      data-role: true
> > +
> > +      try-power-role: true
>=20
> I don't understand why do you have here properties. Do you see any
> binding like this?

Well, it looks like I copied these mistakes from analogix,anx7411.yaml .

> > +
> > +    required:
> > +      - compatible
>=20
> Drop, why is it needed?

Again, copy from analogix,anx7411.yaml .

Should I try to fix up analogix,anx7411.yaml , and submit that, first,
or is it easier if you do that?

Thanks and best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--VEdryfHzoLY8OQfU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZdZ8+gAKCRAw5/Bqldv6
8gr4AJ97KMZrugfihrFG/IvlUx3HrasLBACeOE+16JUA5PzpDbeRrZPUpXx/JiY=
=Iun9
-----END PGP SIGNATURE-----

--VEdryfHzoLY8OQfU--