Received-SPF: pass (google.com: domain of linux-kernel+bounces-75620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 21 Feb 2024 23:54:54 +0100
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, Corey Minyard <minyard@acm.org>,
	Andrew Manley <andrew.manley@sealingtech.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: imx: when being a target, mark the last read as
 processed
Message-ID: <ZdZ_PsNhQ9S1Eab-@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
	Corey Minyard <minyard@acm.org>,
	Andrew Manley <andrew.manley@sealingtech.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240221193013.14233-2-wsa+renesas@sang-engineering.com>
 <kgfagzj5vez56levwam6n6tzxl2lu7efnw5x3eadl3uophxism@ph2tghrvedg5>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wMLlim1uQUSFzSBp"
Content-Disposition: inline
In-Reply-To: <kgfagzj5vez56levwam6n6tzxl2lu7efnw5x3eadl3uophxism@ph2tghrvedg5>


--wMLlim1uQUSFzSBp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 09:58:23PM +0100, Andi Shyti wrote:
> Hi Wolfram and Corey,
>=20
> On Wed, Feb 21, 2024 at 08:27:13PM +0100, Wolfram Sang wrote:
> > From: Corey Minyard <minyard@acm.org>
> >=20
> > When being a target, NAK from the controller means that all bytes have
> > been transferred. So, the last byte needs also to be marked as
> > 'processed'. Otherwise index registers of backends may not increase.
> >=20
> > Signed-off-by: Corey Minyard <minyard@acm.org>
> > Tested-by: Andrew Manley <andrew.manley@sealingtech.com>
> > Reviewed-by: Andrew Manley <andrew.manley@sealingtech.com>
> > Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > [wsa: fixed comment and commit message to properly describe the case]
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>=20
> is this a fix?

In deed, it is:

Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver")


--wMLlim1uQUSFzSBp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXWfzoACgkQFA3kzBSg
KbagAxAAn45Po3ZAJlfnoswOKe4rzonqmkLsAxS1Y5qgSdTMQyanU9l5JjsmyaPT
xg/t4ZAzx2vwlGMUwQ9pC3Z3Il6LhHPmq598jn/3Vmj+A343ahRyLhWWHh5VP2qu
iArpIvb98BUeaMdHKKew6Qh319lXMxRgpL1aMDJvWWEMMKJantsrTFywcp3N6WYQ
R6QYENuvtChkG1MIAkiuDozlKbhxb3SzcXBsezMTuEHfOcCEsItnXdiwpo+FJ0pJ
xhMw4d6G2I4Qq1xNNPGtmB5a0Xab0QWUKZ8xe0geV3lhWGVqRi+LX/R9CfEy6ge4
rk4nWiP4t8RQG/+S0nGBo/40zeTx8Bz6KYddR8HLFORH0sRzM07LbXrJMiEWvjjJ
tx6a1MwWLJ8DE+Wa2UMRVQOrmJLXTr4rb/ONH4G3IKmSUeYD3qxZEnIp0MebIY4X
J4j6DyRFS7sum6O3IouXiayOL7NSSITX1lt0+zLeVw2dh6aAx+PvrnCY46SKIl+s
Ai/enUt4CZOt/8QWn5VyNhHBfo1hJIWLh91KQqhZ79k6/XEFj1g3TvnV91eGTqQU
PFdPipawhcNqBnoZOB+DGPlqzUuiXwJuLgCaWCUtsec1Prm0sIQZ0mqyT6r/7W1B
BsH8NWzA0G7I7wPCVmT3/QvWsBVeasc9Jn5X753nqQIh/Oq3p2U=
=w2Tg
-----END PGP SIGNATURE-----

--wMLlim1uQUSFzSBp--