Received-SPF: pass (google.com: domain of linux-kernel+bounces-75672-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 22 Feb 2024 00:41:34 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Nikita Travkin <nikita@trvn.ru>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	cros-qcom-dts-watchers@chromium.org, Andy Gross <agross@kernel.org>, 
	Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Rob Herring <robh@kernel.org>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/3] power: supply: Add Acer Aspire 1 embedded
 controller driver
Message-ID: <qoidm5wujjbeoc2hlraky26wuwmuaxi2atyl6ehovhvffdbfeh@g5gunqdei45m>
References: <20240220-aspire1-ec-v3-0-02cb139a4931@trvn.ru>
 <20240220-aspire1-ec-v3-2-02cb139a4931@trvn.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5pumrq45zgvzlhw7"
Content-Disposition: inline
In-Reply-To: <20240220-aspire1-ec-v3-2-02cb139a4931@trvn.ru>


--5pumrq45zgvzlhw7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Feb 20, 2024 at 04:57:13PM +0500, Nikita Travkin wrote:
> Acer Aspire 1 is a Snapdragon 7c based laptop. It uses an embedded
> controller to control the charging and battery management, as well as to
> perform a set of misc functions.
>=20
> Unfortunately, while all this functionality is implemented in ACPI, it's
> currently not possible to use ACPI to boot Linux on such Qualcomm
> devices. To allow Linux to still support the features provided by EC,
> this driver reimplments the relevant ACPI parts. This allows us to boot
> the laptop with Device Tree and retain all the features.
>=20
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
>  drivers/power/supply/Kconfig           |  14 +
>  drivers/power/supply/Makefile          |   1 +
>  drivers/power/supply/acer-aspire1-ec.c | 453 +++++++++++++++++++++++++++=
++++++

I think this belongs into drivers/platform, as it handles all bits of
the EC.

[...]

>  3 files changed, 468 insertions(+)
>=20
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 3e31375491d5..e91a3acecb41 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -985,4 +985,18 @@ config FUEL_GAUGE_MM8013
>  	  the state of charge, temperature, cycle count, actual and design
>  	  capacity, etc.
> =20
> +config EC_ACER_ASPIRE1
> +	tristate "Acer Aspire 1 Emedded Controller driver"
> +	depends on I2C
> +	depends on DRM
> +	help
> +	  Say Y here to enable the EC driver for the (Snapdragon-based)
> +	  Acer Aspire 1 laptop. The EC handles battery and charging
> +	  monitoring as well as some misc functions like the lid sensor
> +	  and USB Type-C DP HPD events.
> +
> +	  This driver provides battery and AC status support for the mentioned

I did not see any AC status bits?

> [...]

> +	case POWER_SUPPLY_PROP_PRESENT:
> +		val->intval =3D 1;

You have an unused ASPIRE_EC_FG_FLAG_PRESENT, that looks like it
should be used here?

> [...]

Otherwise the power-supply bits LGTM.

-- Sebastian

--5pumrq45zgvzlhw7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmXWiicACgkQ2O7X88g7
+pphEQ//QfRfqFF/XjDaJi9b+8RjH14PfIoll6uD3p5mDEZNt2uUHj0OD6amERqW
f/oEuh3OIdGda/XOQAVsF3hB6R0odh1oU9g2h5O5ibcITedbJylsuMKXxn27OmCg
6pStiMBuNB9RQjrhqjF3THVfqkcyqilW0seTVoqXNq2B1UT2fOT+KKgUaUMt2dj3
jYdAyiza9GywL+bPk2fnEjygNH2tU6YpEDO7p2BYHu4jG066S+sCntaAfS9GYlOm
DRfXUxmWlQuV2J9eJto1dbKaqgCCVl5aHmK16no5kpJy1YaStzi/c4ZebHJkVfUz
/SRFPXUWySirture+1EAL5jj8d52eBJOa9Bm7Nn6VhWnNmrZ+3tLjUK9MQY6Adn3
yCcFi/kmK+rDxBOqzC3FFjQACpH7TYe6cXREqjH45ItqClPOghvPXJNYs0B/RjKv
ZWERkRZKqP0GfDNZhhYWvmNxNBlX9/psgWfGdOQauvmi99jdIDy9rOGvuqBvMoG2
M6wFQBnp/hjVJqbuFZhWTHx5dq1Bnz6TRUsd0Lk6xwWs04bzEaD/dND7WE0JGO6W
VZBqdLdcFO7UvyyQAAY4BB4qqhORN5kwucm3dZQOtHQqrtmJ8JkC0Ysmyyvp3wJZ
fJYww9pNBQ7sV3nylsuvpFd2ocziNoesdhIp2Phkd5p0Pdk1Z+c=
=5HBY
-----END PGP SIGNATURE-----

--5pumrq45zgvzlhw7--