Received-SPF: pass (google.com: domain of linux-kernel+bounces-75691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 21 Feb 2024 13:50:50 -0500
From: Oliver Crumrine <ozlinuxc@gmail.com>
To: dsahern@kernel.org, davem@davemloft.net, edumazet@google.com, 
	kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: copy routing table more efficiently in
 rt_dst_clone
Message-ID: <psfmabpw6p3fk5jk3iuuhv4eiolmtvteiydgoxowk35jxpdslu@pcuzmfyxkm6s>
References: <xlabdyc4izitfdfpuoy2p2hi3abiq4mrrgizdqz45k7xeftbsg@ee6jgncdaqg7>
 <8afe7956-8f29-49e8-a59f-7e6b4136fa1d@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8afe7956-8f29-49e8-a59f-7e6b4136fa1d@kernel.org>

On Tue, Feb 20, 2024 at 07:44:24PM -0700, David Ahern wrote:
Hi David,

You are correct that rtable is a container of dst_entry, and the
previous code copied not only the fields of rtable but also the fields
of dst_entry. However, the *new_rt = *rt line not only copies the fields
of rtable, but also the fields of dst_entry. 

I have demonstrated this by generating a random number and putting it in
the "expired" field of the dst_entry that is part of rt, and the printing
the random number that was generated. After the copy, I printed the
expired field of the dst_entry that is part of new_rt and the numbers
matched. This proves that not only the fields that were part of rtable
were copied but also the fields of dst_entry.

Thanks,
Oliver
> On 2/18/24 6:35 AM, Oliver Crumrine wrote:
> > diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> > index 16615d107cf0..ebb17c3a0dec 100644
> > --- a/net/ipv4/route.c
> > +++ b/net/ipv4/route.c
> > @@ -1664,22 +1664,8 @@ struct rtable *rt_dst_clone(struct net_device *dev, struct rtable *rt)
> >  			   rt->dst.flags);
> >  
> >  	if (new_rt) {
> > +		*new_rt = *rt;
> 
> rtable is a container of dst_entry, so this is copying those fields as well.
> 
> pw-bot: reject
>