Received-SPF: pass (google.com: domain of linux-kernel+bounces-75692-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 21 Feb 2024 18:53:24 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Ankur Arora <ankur.a.arora@oracle.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org,
 torvalds@linux-foundation.org, paulmck@kernel.org,
 akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
 dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
 juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org,
 mgorman@suse.de, jpoimboe@kernel.org, mark.rutland@arm.com,
 jgross@suse.com, andrew.cooper3@citrix.com, bristot@kernel.org,
 mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
 glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
 mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@ACULAB.COM,
 richard@nod.at, mjguzik@gmail.com, jon.grimm@amd.com, bharata@amd.com,
 raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
 Masami Hiramatsu <mhiramat@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 29/30] Documentation: tracing: add TIF_NEED_RESCHED_LAZY
Message-ID: <20240221185324.66986c9a@gandalf.local.home>
In-Reply-To: <87bk89e72r.fsf@oracle.com>
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
	<20240213055554.1802415-30-ankur.a.arora@oracle.com>
	<20240221164334.6f8c69e8@gandalf.local.home>
	<87bk89e72r.fsf@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 21 Feb 2024 15:22:20 -0800
Ankur Arora <ankur.a.arora@oracle.com> wrote:


> > I wonder if we should also add this information in /sys/kernel/tracing/README
> > so that it is easier to find on a machine.  
> 
> Yeah, there is a problem with the discovery. Seems a little out of place
> in tracing/README though.
> 
> How about something like this? Though this isn't really a model of clarity.

Could work, but I would also have it check the configs that are set in the
kernel, and only show the options that are available with the current
configs that are enabled in the kernel.

> 
>     --- a/kernel/trace/trace.c
>     +++ b/kernel/trace/trace.c
>     @@ -4292,7 +4292,7 @@ static void print_lat_help_header(struct seq_file *m)
>     {
>             seq_puts(m, "#                    _------=> CPU#            \n"
>                     "#                   / _-----=> irqs-off/BH-disabled\n"
>     -                   "#                  | / _----=> need-resched    \n"
>     +                   "#                  | / _----=> need-resched  [ l: lazy, n: now, p: preempt, b: l|n, L: l|p, N: n|p, B: l|n|p ]\n"
>                     "#                  || / _---=> hardirq/softirq \n"
>                     "#                  ||| / _--=> preempt-depth   \n"
>                     "#                  |||| / _-=> migrate-disable \n"
> 
> 
> Also, haven't looked at trace-cmd. Anything I should be sending a patch
> out for?

There's really nothing that explains it. But that probably should be fixed.

-- Steve