Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp32490rdb; Wed, 21 Feb 2024 16:05:40 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWdmaWlPJ2ImJDQp26TXLFwoq55xRTm34FTBdi5rYs6qD59ACQerXSFFRro3BKX+VirGxW0kF2VawL6vZsbjZ7B6WaQa6y3L8TZ1Wq32w== X-Google-Smtp-Source: AGHT+IE8KBqJjnJC4NS1+Bxx3pm6ClBFhkA+DSbbu+qZXz6M7RhwvQiOdAB06De32bVAgnMjk12U X-Received: by 2002:aa7:c491:0:b0:560:58f:7148 with SMTP id m17-20020aa7c491000000b00560058f7148mr15993518edq.34.1708560340728; Wed, 21 Feb 2024 16:05:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708560340; cv=pass; d=google.com; s=arc-20160816; b=ZAhjsO3wj5AqDLpl+mLmhD8ayLo+XrYnwbffCjpWukAtyxW4RqMqmcMmfOAcsB3LYx 8w7fQKgRuN9Ndflg1h1ugOk5KxfYGYT9Rx0wubshxgQC7DTbTqPr+4Sir7Svm5msy1vU mAeGD6yJa1RaPjxVkgqxzCo+A3wa5L3+LsYX/Qnq3WAoye9zo7c4QIPVrmqjdPVN3PDF T7pi19o1fGSrS++0s+IZ8dB6C/iBCIINANp8OSKk0OqKXkzwqNZCdJ7BrGBZxGepe/Ar 0mv0uQqPOjnG4EmAvkVZQHE1oO1BNh9jYSPf0/Kc9OHw5kuZWbMI9WuEgFiS92tZU3E5 I+oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=DacZQ2bgLZrPyV3TE+Kd66Fku/+A0+dgRbmVjv/psVo=; fh=PyExhOQhurakcnc2pbKXiqT8xdLZyRjptx2neqZHHas=; b=SLpEPfIV0pegfsvUmB++9UjNBaDtrxK9PwyIf6RrIChDvxwGpLF98ndz6Xj7f+7Scx QXMSPybYrrHGnVaqOk7EpkPsg1UzU7teOXcOVi4K5MSgAn/HkqrbElXDluIED0BjA24K Ol/EpwhAvUcE15Jp39emUXNbMpv6awpnrO5bLhng35amttKqAg+t0679FlxD5aymUYsA HqarMVykmbpxsS8k7Qh7Pnob+abvIwohuoaycSwe6z4AsA63COT6K0lM/UmKj3jSAB/X jk6SHswQUhUtcyDE/t5pkSQSPHbV+EoQAjTyC05Eepx8ZSZXyL6P7bRHN9WaGBpCqND/ eyOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=TIMkT15W; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-75699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75699-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id j6-20020a05640211c600b0056479742905si3303584edw.599.2024.02.21.16.05.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 16:05:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=TIMkT15W; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-75699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75699-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 79C9D1F243E2 for ; Thu, 22 Feb 2024 00:05:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 44BA214A8F; Thu, 22 Feb 2024 00:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TIMkT15W" Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11D1B647 for ; Thu, 22 Feb 2024 00:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708560270; cv=none; b=GbqI6lIRhCUIFESOdsBK/666BDLSnw22+g9sbAijuGrGxIqqVGdy2xMltiJt+0OQeR0qLczZ22Jwv1hYhIqzBV274jHAp7jLH1aUhHMwMsANHRpx7haoDbzeIqekVvNXwn/VZjgE2PZsEKx3IjDsw2E7jT6oxfdMR5BCF93yMu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708560270; c=relaxed/simple; bh=4WKkWotYZ1Oazo/PiLbdh34LV4deHtqfIISRRq7ZkH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PJdFFNhLH2Gvbf9Soo36cabRLizfSCZQYjHlkRy9BuoEtcmMLc+3Xzvu+rBfPvKP0hxGffcdadROaFJCLxcCX3R5eKmLTu//DuF5mnmSFPfekCDCFIvsfrIqouq4QDgbpLxNCXKby2sPQPXtED11YSH+OihWPbxE/Zrug4qzydE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TIMkT15W; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Wed, 21 Feb 2024 19:04:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708560266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DacZQ2bgLZrPyV3TE+Kd66Fku/+A0+dgRbmVjv/psVo=; b=TIMkT15Wa83yuKPGA7xJBGstG2DmQTXX6m46kts3xS2DRGpqIxD0qfriZ6Uj8+J3aTLC7Q S6zwVQOMpY4HUNWunGEpmApf7YuNFrH33khwHIE+k2HD/Nd2OVamTuJeO+x5YYbufH81xm 9C6yHywEYXYfmMNWDGv86G2xOms2uFI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Colin Ian King Cc: Brian Foster , linux-bcachefs@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] bcachefs: remove redundant assignment to variable ret Message-ID: <3qaoftjgf7p2ugutl524b3yin7pqpjrkftjx3frunhduf3so66@tjhcdoq6unk3> References: <20240221115203.3413554-1-colin.i.king@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221115203.3413554-1-colin.i.king@gmail.com> X-Migadu-Flow: FLOW_OUT On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote: > Variable ret is being assigned a value that is never read, it is > being re-assigned a couple of statements later on. The assignment > is redundant and can be removed. > > Cleans up clang scan build warning: > fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is > never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King I'll take this, but - entirely too much of the traffic on this list is getting taken up by static analyzer bullshit, we need to cut down on this