Received-SPF: pass (google.com: domain of linux-kernel+bounces-75701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <cfa4cd82-67e9-4483-9c35-a425859f4a21@gmail.com>
Date: Thu, 22 Feb 2024 00:08:28 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH][next] bcachefs: remove redundant assignment to variable
 ret
Content-Language: en-US
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Brian Foster <bfoster@redhat.com>, linux-bcachefs@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240221115203.3413554-1-colin.i.king@gmail.com>
 <3qaoftjgf7p2ugutl524b3yin7pqpjrkftjx3frunhduf3so66@tjhcdoq6unk3>
From: "Colin King (gmail)" <colin.i.king@gmail.com>
In-Reply-To: <3qaoftjgf7p2ugutl524b3yin7pqpjrkftjx3frunhduf3so66@tjhcdoq6unk3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 22/02/2024 00:04, Kent Overstreet wrote:
> On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote:
>> Variable ret is being assigned a value that is never read, it is
>> being re-assigned a couple of statements later on. The assignment
>> is redundant and can be removed.
>>
>> Cleans up clang scan build warning:
>> fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is
>> never read [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> I'll take this, but - entirely too much of the traffic on this list is
> getting taken up by static analyzer bullshit, we need to cut down on
> this

I'll back off then.

Colin