Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp35901rdb; Wed, 21 Feb 2024 16:13:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUNf1Rvh7lNMvzkv5Ti3APY6mN7Xt4P5xAQwsjWN1gZn9cQ2s6b5OaNEF8322ajUJIIqSSRQp6yEGBgC8ov9h4VFpEG92bwHlcPdUajXg== X-Google-Smtp-Source: AGHT+IFcUWilpokcMo6jQQEakFFCisoSr4w4RHLfwehxcMZ7OptxvzdAXPdDpw4LJYeEmZaZGd3j X-Received: by 2002:a05:6402:556:b0:565:9a3:9f44 with SMTP id i22-20020a056402055600b0056509a39f44mr1005945edx.8.1708560804218; Wed, 21 Feb 2024 16:13:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708560804; cv=pass; d=google.com; s=arc-20160816; b=Waiy/QLt96DAdZnvOLGA3lOBtICRUJOUByl09cBo5lZYeKACZnwpCaXTcpcK0tcpn/ h8QYL1tHbHDEEq4+GUXXpgseGKaTqiRmtxxBnmO1he/5fNPI9kD6L3F34vJUNkd4actZ hOTBs3uwwy0dC5Hx9lzo71xhFxs2PC3Rv/NtTZ/LCZdf2xoT9gN3x/CcZu0u9R1xuHDK p7eRwGjz63EVBcQ6rcFhYgChdtOIIx1cACQIdROEl6D9rPdk3xPTL40MdWwpDo+urKW6 tYJgCc1VYrDtvHKkheUtgKosbTZrY1N1eRUOGOqRG1TeElaDFLkgtl1lKy3WV9mC3wE1 kIJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=9DMHLnyzhcN8vf6iG1IKFZXAcocDG2xngD5mV3RGx+c=; fh=rc8EkvOTE39NSWmLrpZ9/tGwH0tCd+iNIeEYl4hiSMk=; b=AfcLRc6aOF53nxxNAGzrwIs0jaMSXIOYVW53HXlT20PcvExpGSxrvh5DQpn/+B+1Or iewKEEyq0vd4yc8V3cFStWMhzZc1IdJ2oZt19vflCFzaQw6Mo8BhJQhDlnl5A7rzAS49 toA9vhM13uBakeMAp1Uzzvf4ExKTs3NeIO/t0aurh9Xs2DS25FsjL9W2TYSObrk3B8+0 /8Jtw9zj8FsyR0E/L2r//HAy1KvWFu+Hey3GqpgZW+MJBwyl2ad2wwvjVmQaE1iFSJk5 PKfia9LUtHatcLtszHSGEBWvahMI1YA+7Xdf02MGOENKyQPmjCRu9mzkPuWXoQSVwneD wIMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BVCFB3Qn; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-75708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75708-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m15-20020a056402510f00b00564aed208aesi2333429edd.67.2024.02.21.16.13.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 16:13:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BVCFB3Qn; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-75708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75708-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ED5F11F2464B for ; Thu, 22 Feb 2024 00:13:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E41E8F77; Thu, 22 Feb 2024 00:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BVCFB3Qn" Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73E90EC3 for ; Thu, 22 Feb 2024 00:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708560798; cv=none; b=j/ekuX+qKDFApjtGJUOsdCDsxUQWvjYQAo9SjBqXbRDIP97ryYT6TwFdz9PF1LE5zWrCBKR82Uh84qnMazbBZzqkZ20iXZBUuGLsBOL7ZS0nfAI9aw03/QxajipndsB0ZrPX3Osn6oBospzunki5O1tWz02F9WGeFfseQOXYsZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708560798; c=relaxed/simple; bh=iUVWUF9NkdrHOfQDIfPkftj/GJ/E6lO+EKObpVPf634=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Iqg2r2TOomNFXVykok86U9kSyVFPFBA9LgGEW7xoeX4YzdXHuKUrsJQKOqsI3bmVXs7zwgqCAUneQJZ0KWGMssBF2XEjJapQGAZPsLIcA/OoIeftem82Q5uVvvKjKVHLhN99fsLf0ZCjpYxnPjHvAZCiUG2MXlELSNh9n0YXbqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BVCFB3Qn; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Wed, 21 Feb 2024 19:13:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708560795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9DMHLnyzhcN8vf6iG1IKFZXAcocDG2xngD5mV3RGx+c=; b=BVCFB3QnnSsV6YcYDk3XQRAF6CwNL1RSt46ymfCNlUPryJ2e1DhklXaqKS/wmxS1ei03ee g/fOundriHURen1VughVUN9rg1SEunNP6VvbfK2iVnr5us4mzitB7DjnHo+J7l28wZsFYR gYbJ1Epul/iyk/9wkhxWIEoN3zQ1Hxc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: "Colin King (gmail)" Cc: Brian Foster , linux-bcachefs@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] bcachefs: remove redundant assignment to variable ret Message-ID: <27hacgxfzyeatjx27nb4k5rb5cajt5yw4c2papfr4h64urb7qx@teo2ha6msqnl> References: <20240221115203.3413554-1-colin.i.king@gmail.com> <3qaoftjgf7p2ugutl524b3yin7pqpjrkftjx3frunhduf3so66@tjhcdoq6unk3> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Thu, Feb 22, 2024 at 12:08:28AM +0000, Colin King (gmail) wrote: > On 22/02/2024 00:04, Kent Overstreet wrote: > > On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote: > > > Variable ret is being assigned a value that is never read, it is > > > being re-assigned a couple of statements later on. The assignment > > > is redundant and can be removed. > > > > > > Cleans up clang scan build warning: > > > fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is > > > never read [deadcode.DeadStores] > > > > > > Signed-off-by: Colin Ian King > > > > I'll take this, but - entirely too much of the traffic on this list is > > getting taken up by static analyzer bullshit, we need to cut down on > > this > > I'll back off then. Maybe just wrap up fixes for all the warnings every now and then? It is worth keeping up on static analyzer warnings, it's just the mailing list noise I want to cut down on, as well as making better use of my own time. I'd be happy to take a patch like that now and then, or - maybe we could get a dashboard going, like I was just running by Dan in the other thread? If we could get a dirt simple stupid dashboard that had both the clangc analyzer warnings, and the smatch warnings - I think that would make a lot of people happy.