Received-SPF: pass (google.com: domain of linux-kernel+bounces-75769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 22 Feb 2024 09:32:52 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: Jan Kara <jack@suse.cz>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>, Matthew Wilcox
	<willy@infradead.org>, Guo Xuenan <guoxuenan@huawei.com>,
	<linux-fsdevel@vger.kernel.org>, <ying.huang@intel.com>,
	<feng.tang@intel.com>, <fengwei.yin@intel.com>, <oliver.sang@intel.com>
Subject: Re: [linus:master] [readahead]  ab4443fe3c:
 vm-scalability.throughput -21.4% regression
Message-ID: <ZdakRFhEouIF5o6D@xsang-OptiPlex-9020>
References: <202402201642.c8d6bbc3-oliver.sang@intel.com>
 <20240221111425.ozdozcbl3konmkov@quack3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240221111425.ozdozcbl3konmkov@quack3>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c5mwCq1hHPTtPfApcfjnBrnc8XhFZDyKhM1+cZlegd+LU1Wt6lE9nlLws0Tm?=
 =?us-ascii?Q?tOAsOp7xyjnZl1SbTLz6dq3e4fb2q6GiLWY5ljBgmipVI+Cs1EUzpthVxG6e?=
 =?us-ascii?Q?S4iVfohGMA9qJQ3Q+TaYJRJSaE7MnVh1m8nidBfW+LI2WMKh3TgF3US5ACTw?=
 =?us-ascii?Q?3tvhajM5r/9vu6IbQa1rsKUrVZVK8HQIEMJcRoN9N9qWuzLF+rkSYfk5FWr5?=
 =?us-ascii?Q?d/eETlfAr/MQhslfqidAN45X0u3t9ZABtFmIjl9rrlyZxxHFAruWsw9e/tpl?=
 =?us-ascii?Q?gc+jAnATqYpCgPlWOMeutVLGNOMgZMJCRoC69QJbJECFYaxma8iQoIsQEiFJ?=
 =?us-ascii?Q?UyeVgaj3OoG8s9ozaXkMzdEVlrpg8phZ1X8XoBcdMRbKbcKczihY2Sb38JzA?=
 =?us-ascii?Q?JU5DJBHLZAcmYbwAOyVjq9p/ftMfUZn9PiOQ5fKrWlw7EW+hJoadBen0hQ/s?=
 =?us-ascii?Q?taTVp0+1vqQvWPEGPqjCinE8rS2VqHfmvEqzKJbZ5kdTpecUm1xESEOpvWcv?=
 =?us-ascii?Q?lRYe6n8fiZXwJM9HwV9M56ZN4CYVJHFvSiM31ujTeLUcXBdRalC6CBzn0RSp?=
 =?us-ascii?Q?2AgjFH+dYE+FOHjyX7Tjx8LsnfErGI9GfaMypzJeyvzUZjIZK/cYzYfmKFjK?=
 =?us-ascii?Q?PxjUIu8bRPjU/6zXkfh4bGJjtZqqGd4mbNUiDrtVQ7DHBl3ZZtQiJYGeC6jw?=
 =?us-ascii?Q?FuQ3qe+5KnsU4rBjXrmdFc1uUMyLYTpjzaaXWau+fUG4mtfMcWEogZTDjYv3?=
 =?us-ascii?Q?U3XuE3Az2zMUQgdKqlLgg9tkWHgaSUDU4Xs3qU13yZY1FjR6CgAuUGcg2gdQ?=
 =?us-ascii?Q?qULbV7vUOQgiKfLiQF1ccU8GiGQAYXzlHgdXgVsPNxzbr9drsI/Dp8e7rzP/?=
 =?us-ascii?Q?Ma1TP+1uMpgKVdHWdC84UhkEUp4UGKWRBdjK1e9+neuE0+xFXYJrNb1/Yqt8?=
 =?us-ascii?Q?U+TV1kMHZxbrX/2AKJSiDRoQ7Hja1THI8HXtHtwi2FziY2BbMrosNwwTv5r4?=
 =?us-ascii?Q?SjPZ6ZEKIPNVRhFDOjLDZnakSbq9qq6GxmUiPtVkm2P0NE8Kgo6M9y2DU6e5?=
 =?us-ascii?Q?8wv5cP15dlwDmtwNGnrrT28FvsXYrWUqhHpBzG7KiLVDIulDUgMWAy4n+snd?=
 =?us-ascii?Q?sdDVpq24BwommEFwDnc9PsyQPQgNUAzfhPKyE1Ca3+qEnhvmPwClbPq0dda/?=
 =?us-ascii?Q?QK/rMQcjXQuUWBuLkakvesh0wRLnXfrEYKdHR/674BOr++tBsMDolY8cJYnY?=
 =?us-ascii?Q?ZUlcij9+GiH9vOexxIQA9F0POA1jiLtaq/DINgC/SFFYF9XVNVacRt6pbqlH?=
 =?us-ascii?Q?nkKiHBoUtOqtQ72XHoGbE6nXios/gzSyzPTfSAKMXcr6GU28SWkgU3CfO6Fs?=
 =?us-ascii?Q?P6d+S9mlbulPShxKIytdAT9yW5zi97SNVRBq8spciXvlnCIIEtQmwfmQgTJp?=
 =?us-ascii?Q?br7b9TSqrcmqQ8Wc5lCwn+etUBQ7CMZTz3zY65Z7RklzqNWd3yIf0+eP8Unv?=
 =?us-ascii?Q?kwVtsxl395R2gtValyuUrHv78yuyIXYoXiZu3K+GFk0feHPPt0eJNfki90nT?=
 =?us-ascii?Q?22Z0dV+dazbMyCAI/8qb7LyrGSsitBKuPLQRSBN0PU+Q4xWkMqRswlUMmlEs?=
 =?us-ascii?Q?Og=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 67bba0e0-6b41-4371-4586-08dc334634f1
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 01:33:01.0384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YiP5LqZ+Ym0Cd3KN1vBvaTkSDeVP13YPateJ+Evq+YQ6hOT6E68IuxyksE5pBlSPNYgP2Lz0Emp6L9hhzUT4Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5570
X-OriginatorOrg: intel.com

hi, Jan Kara,

On Wed, Feb 21, 2024 at 12:14:25PM +0100, Jan Kara wrote:
> On Tue 20-02-24 16:25:37, kernel test robot wrote:
> > Hello,
> > 
> > kernel test robot noticed a -21.4% regression of vm-scalability.throughput on:
> > 
> > 
> > commit: ab4443fe3ca6298663a55c4a70efc6c3ce913ca6 ("readahead: avoid multiple marked readahead pages")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > testcase: vm-scalability
> > test machine: 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480CTDX (Sapphire Rapids) with 512G memory
> > parameters:
> > 
> > 	runtime: 300s
> > 	test: lru-file-readtwice
> > 	cpufreq_governor: performance
> 
> JFYI I had a look into this. What the test seems to do is that it creates
> image files on tmpfs, loopmounts XFS there, and does reads over file on
> XFS. But I was not able to find what lru-file-readtwice exactly does,
> neither I was able to reproduce it because I got stuck on some missing Ruby
> dependencies on my test system yesterday.

what's your OS?

> 
> Given the workload is over tmpfs, I'm not very concerned about what
> readahead does and how it performs but still I'd like to investigate where
> the regression is coming from because it is unexpected.

Thanks a lot for information!
it was hard to me to determine the connection, so I rebuilt and rerun tests more
which still showed stable data.

if you have any patch want us to try, please let us know.
it's always our great pleasure to supply supports :)

> 
> 								Honza
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>