Received-SPF: pass (google.com: domain of linux-kernel+bounces-75773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 22 Feb 2024 09:28:19 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Shuah Khan <skhan@linuxfoundation.org>, Marcos Paulo de Souza
	<mpdesouza@suse.com>
CC: kernel test robot <lkp@intel.com>, Josh Poimboeuf <jpoimboe@kernel.org>,
	Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek
	<pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com>,
	<oe-kbuild-all@lists.linux.dev>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <live-patching@vger.kernel.org>
Subject: Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR
Message-ID: <ZdajMy061zaqq8fP@yujie-X299>
References: <d984977f-b7ad-44b9-82dd-27aeb2fad592@linuxfoundation.org>
 <20240221220404.11585-1-mpdesouza@suse.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240221220404.11585-1-mpdesouza@suse.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1DV/KPYZe2eGA+HaK29XmoEs0c+8YZB7Nd4nvtTpebXvDvsuCQoR5rWSpb06?=
 =?us-ascii?Q?jJnaasSRPtmncyh5vOKQ1+P7R8ClRRu4ljqg2VAv8+TKU+gjtxsSXEgxT+mn?=
 =?us-ascii?Q?xKUU+2Xdv3kDwskv7T4NNlRe1gfl8gRwIaGgWR/Qet7RUYbDoq5xl+iMVgbq?=
 =?us-ascii?Q?n5Wfqbr7o7T7fa+F2AWtcysj0LEAFqqh4G+Cc1Bha9Doxlz5+baLyNssxzhs?=
 =?us-ascii?Q?nKtM8N/OpMHcOvBUYsZ/wZL9nCJ+z8RsMrrKlteXvd9edyKHqAbq+pFysrOq?=
 =?us-ascii?Q?xre3FeENb04aY0jspejUbz9XEJ9DPyrdKb2m6ie5HBhLM24fC45Sn95E40al?=
 =?us-ascii?Q?olhtg9aRV6RAVklkLFpn1DBUwKk0A2CYjSQDRbf0YG0ROQRHI1HvqBRfy1nt?=
 =?us-ascii?Q?rmRCXRdNVDnGGN05Pxd2q+mo2IjILZFOjwwza/dGsC9RtvbJ5BsbLPfbhrLm?=
 =?us-ascii?Q?ArrG59wNZXGBf5SSapABZENEbPoStsVmq3o0kmwMuXNNPJoaBnaWwdaC9GIs?=
 =?us-ascii?Q?aQwBkZsMM016TXmoc/mznslXatMFC3tADIe1qWRNhNgi4kRYODnZGKe0Gyrr?=
 =?us-ascii?Q?dgXqfaZajpWj0vb5aanQUZnSUrN02ybr9jhwoz659WNc833tS6PzJRlef6yl?=
 =?us-ascii?Q?uIiRMPnRsQiGDwu6wNp91fdZQgLX9SAoLLeuz7foUi49BZsnOZKBy/4GYgoq?=
 =?us-ascii?Q?KnUKHgbFULoPOubfmvlYksgMBnSgoyHGG/j0YPyaXPO/wtgYCku62J6hNseh?=
 =?us-ascii?Q?JnDzqWVLViQwI2nsmxT+76+wHdQopINDx/704VvNdUUbr9Dx4XjJvwkV9gv8?=
 =?us-ascii?Q?NFBLsu9QSQB/EE1wmIZOZbjAQaZh4MaPoSoCAy7k9F4ixziLZHYknyj8K203?=
 =?us-ascii?Q?DtDw9gApQ0ixhi4bq7+EM53APxqRZZEnYMu1QhABDKZfKtiHpQOs9/1tZ2gr?=
 =?us-ascii?Q?yjrSRYW/ca+YTZUDEZhyECD3cLfkGPMzRmYdedwkxTbd+j2Gccdt60mbdAlf?=
 =?us-ascii?Q?+kIOGlBNbd5rX/D08PT3jLUkRlFOU8BVLqFMgWhKss55Nnnqmx0zCSQfIPTO?=
 =?us-ascii?Q?QOro8z+u0Dn6r2t295Vv8KH0ms08ZN29AXENSOXltL/RujM3ub2VqYBLMfax?=
 =?us-ascii?Q?2A9h3WbKteiXAz1omvAjrzNKQDtNzRP/r1SqkapCOs6AJnCWjxIDuNnFvLqW?=
 =?us-ascii?Q?WBMyKowVIz4rD70dcCOmq3wwWCO2XKf/kOAQsE4pbjnEr40oUBV57WKCoano?=
 =?us-ascii?Q?Bhlm0IPnxJ3z27VLxP4yWH9ITX9ZmMqJ3Qzfw4Jzw42xeFNuTp2H25IjLFgn?=
 =?us-ascii?Q?r+5LJ4jdxgA8AxSYv/3AN/t6ne+2aKkO8VMQxwed4YhvgNqpoPqwCwYTnu7y?=
 =?us-ascii?Q?ox/0SNQSeOporSyp5jK/Ttn8Apq+bjwb/3rZWN6CVv6I0Trz/aL9Yzc81m+R?=
 =?us-ascii?Q?kMZ1nZDF1tNvqkYj7gn2UVwSdXKzndcKBnHfnGhOmdw2+9ketpbjh9H4YWLU?=
 =?us-ascii?Q?hGcIOV8sYvh3wxYcAVOfdDBn/yqBJwPR8eWCDPxqzVyPeb6USFm4ofkIxgO6?=
 =?us-ascii?Q?gcfS9V5C1sKeMA9aUwn6t8hzOCXVE2S165F8Al/J?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 38248064-059f-4998-9dfd-08dc33468485
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 01:35:14.4926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KPv6qDgvG5h0+PB+lxjE46SWhs6XmUZp8odCa6OOpsE8utm2FohyhVIp5DaLzyEXGqWkYe7A2mcvqvV3wkj82Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7282
X-OriginatorOrg: intel.com

On Wed, Feb 21, 2024 at 07:04:03PM -0300, Marcos Paulo de Souza wrote:
> On Wed, 21 Feb 2024 14:12:00 -0700 Shuah Khan <skhan@linuxfoundation.org> wrote:
> 
> > On 2/21/24 05:26, Marcos Paulo de Souza wrote:
> > > On Tue, 20 Feb 2024 17:19:54 -0700 Shuah Khan <skhan@linuxfoundation.org> wrote:
> > > 
> > >> On 2/19/24 06:53, Marcos Paulo de Souza wrote:
> > >>> On Mon, 19 Feb 2024 09:15:15 -0300 Marcos Paulo de Souza <mpdesouza@suse.com> wrote:
> > >>>
> > >>>> On Mon, 19 Feb 2024 14:35:16 +0800 kernel test robot <lkp@intel.com> wrote:
> > >>>>
> > >>>>> Hi Marcos,
> > >>>>>
> > >>>>> kernel test robot noticed the following build errors:
> > >>>>>
> > >>>>> [auto build test ERROR on 345e8abe4c355bc24bab3f4a5634122e55be8665]
> > >>>>>
> > >>>>> url:    https://github.com/intel-lab-lkp/linux/commits/Marcos-Paulo-de-Souza/selftests-lib-mk-Do-not-process-TEST_GEN_MODS_DIR/20240216-021601
> > >>>>> base:   345e8abe4c355bc24bab3f4a5634122e55be8665
> > >>>>> patch link:    https://lore.kernel.org/r/20240215-lp-selftests-fixes-v1-1-89f4a6f5cddc%40suse.com
> > >>>>> patch subject: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR
> > >>>>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > >>>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402191417.XULH88Ct-lkp@intel.com/reproduce)
> > >>>>>
> > >>>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > >>>>> the same patch/commit), kindly add following tags
> > >>>>> | Reported-by: kernel test robot <lkp@intel.com>
> > >>>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202402191417.XULH88Ct-lkp@intel.com/
> > >>>>>
> > >>>>> All errors (new ones prefixed by >>):
> > >>>>>
> > >>>>>>> make[3]: *** /lib/modules/5.9.0-2-amd64/build: No such file or directory.  Stop.
> > >>>>
> > >>>> We should ask the kernel test robot machine owners to install kernel-devel
> > >>>> package in order to have this fixed.
> > >>>
> > >>> Or maybe ask them to change the reproducer to specify KDIR to the git tree,
> > >>> instead of /lib/modules/?
> > >>>
> > >>
> > >> This would be a regression to automated test rings. Do you have any other
> > >> solutions?
> > > 
> > > I would say that we could skip the these tests if kernel-devel package is not
> > > installed. Would it be acceptable? At least we would avoid such issues like this
> > > in the future as well.
> > > 
> > 
> > We have to check and skip build. Something we could do in the livepatch
> > Makefile. Can you send patch for this - I will oull this in for next
> > so we don't break test rings.
> 
> I added a new patch in the same patchset that would cover this, skipping the
> build and test if kernel-devel is not installed. The patchset was sent earlier
> today. Please check if the new patch fixes things on the build robot.

Hi Shuah, Hi Marcos,

Sorry for this wrong report. The files are organized in a different way
in the bot and cause this issue. We have fixed the bot to explicitly
set KDIR to the correct path before building the selftests. The patch
[1] can also work well in bot's environment.

[1] https://lore.kernel.org/all/20240221-lp-selftests-fixes-v2-2-a19be1e029a7@suse.com/

Best Regards,
Yujie