Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp78049rdb; Wed, 21 Feb 2024 18:07:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX7i4zUtv1nCPRl+aW2BjLo06/tthGkUODlJnA7QXvIwVGlsPfZgzlf4yj8ayA5odkPlg7hnBCN85Riy6pzuQJFuUW0zDnUHzP0dqdP4g== X-Google-Smtp-Source: AGHT+IG7UEk7SIp4/SZJNPYjwswH0SZjs7mpX+3acJbWj0Kz13fkcrto3ySiJqcuEw5fel6ZF6nG X-Received: by 2002:a17:902:74c7:b0:1db:cb54:5e71 with SMTP id f7-20020a17090274c700b001dbcb545e71mr1452304plt.31.1708567626666; Wed, 21 Feb 2024 18:07:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708567626; cv=pass; d=google.com; s=arc-20160816; b=TcXe06pfQOJx/y7usZ9IY7D0fwSAl7XsdRJ4oonU3f4C4zWofj1BgALj19Sgrzauoo EKaF8l7cFjfrHTWaUiQ5sbwD+V8vIOcbwfZw4iAOfgUQ/dvI/7pzl1f8xTdAQZ30qdhQ 3zxJvCB+epFQ0WIEpNOsj23uxv1mypRkE0u2UC8CfbXo/mcT5OPp+YnNK9OFFv+0i7M9 zeyCcCq0ALzeFmwSdDjJZrD0S2EGT9ZmSAQq+1eBNV/IjLJrCHxFawGFKv06zyHbrk2r ebvVjT5WP6FbQJN6vyYnrINlCw8T3mYszwaIWY7ElKKag1U0d98ALWQWxfbVAU77YYN5 EGGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ybci3+TcYCfWUtyyK9oMeVMAce0zLcjOP2WOB1QozRI=; fh=HSwUWE4z8kNwy2s1X5YudKN3+itD2pFToYTnIUyxH7g=; b=p+t0T1qfehfxiabLGBrrp77s4Qa2TLwqrVQ5D5AexG9RzqG3Okdeo4mCeLKelNtPTg k2txjhI0SUN0gmW8cb0A6AdZyLFinItl1C2+c8gusjJiNFmvedYkqLkg6vkjeu3UnAIU G8ivah3ktfLvzeZZ7qoOtfYa0TGGC4Kgd0wqae6ZoNllZIYUEuUBwbQtEhSLCREMWUrK 1Jv+I7DIv8Y2cPfFqbjN84XYT/nTOD9xClRAfDkd5l/+3Ro1wyyMr+NA6lmDnLJtj9Vm 7qUnM6Q3+zB/lYdgTA6GpfRGK5/sVLknLrDWacOT93zkd64dgaGT5ahbzolFbwlEKrOL 8fNw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OYfgohSQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75785-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75785-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b19-20020a170902ed1300b001db71681d44si9123337pld.187.2024.02.21.18.07.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 18:07:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75785-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OYfgohSQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75785-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75785-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3649128346F for ; Thu, 22 Feb 2024 02:07:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E63B17564; Thu, 22 Feb 2024 02:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OYfgohSQ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A158F17548; Thu, 22 Feb 2024 02:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708567605; cv=none; b=dDGlU0O4WVNeu9rVF5/qGhHX4YgkfmRqe9uyqmyfUP0RjsWdWTVJCrn1RDDMi/uFwLHkZBLS60ayhmR3Kin/vYWYH0zKRK9SrcSXF7CJhzcEFPkN+n0TMRYb7YaRentpF6zzxFoEUYv0yQB7AzGSN7Upi06Isg7UDvX+YtQFIj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708567605; c=relaxed/simple; bh=Ybci3+TcYCfWUtyyK9oMeVMAce0zLcjOP2WOB1QozRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kNoHa+jCbAoSUpJRxrYbhXCSmwh6yXkMw8KyV0EUKHV78PCmkIiksicC1CpywHZKAUVsPvn0fDZwUMoLyW8/bub2Ej5K6KJYZmtjlqdX1bCja5k5kuBXD1D3fQtVY5dRNBdwH0IgXNDCPZe/grDGQYRDd7clxFP+uhCUujed2ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OYfgohSQ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A01CC433F1; Thu, 22 Feb 2024 02:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708567605; bh=Ybci3+TcYCfWUtyyK9oMeVMAce0zLcjOP2WOB1QozRI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OYfgohSQYfx5MuNjkVKbPMcSliwWc4XdYPqIUBvIvU4KT/boyIp106nCyVqD021Sd njg8Y4SdVFb5APDaQCYE2FZLojpASoRlm7m+focW1sr1wY5c1CzFAEp1Ag2fBVoJrT nzkinUd0UTlLcpG28vbMYlglF6egqdoraXipCtlKZ9oB0pbQR+DiuK2gfCFqa/iMVe oKBs87RNBKE5mMumkZsCJzbM3ew6tSls7bY5/3Yt59MZZEj1Q2ukrajX2bvO7RUFH5 Vbx0/AuXX/AKEjWdBndtBOwymR7Hqck94bPygq4Jjs+1eidMFEX2QfAoI1iSTeXNyY mxbTcAqfLSiKg== Date: Wed, 21 Feb 2024 20:06:41 -0600 From: Bjorn Andersson To: Johan Hovold Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Vinod Koul , Jonas Karlman , Laurent Pinchart , Jernej Skrabec , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Kuogee Hsieh , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration Message-ID: References: <20240217150228.5788-1-johan+linaro@kernel.org> <20240217150228.5788-3-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240217150228.5788-3-johan+linaro@kernel.org> On Sat, Feb 17, 2024 at 04:02:24PM +0100, Johan Hovold wrote: > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-bridge.c [..] > +/** > + * devm_drm_dp_hpd_bridge_add - register a HDP DisplayPort bridge kernel-doc wants () after function names. > + * @dev: struct device to tie registration lifetime to > + * @adev: bridge auxiliary device to be registered > + * > + * Returns: zero on success or a negative errno and "Return:" without the 's'. This could however be done in a separate patch, as the file is already wrong in this regard. Reviewed-by: Bjorn Andersson Regards, Bjorn