Received-SPF: pass (google.com: domain of linux-kernel+bounces-75832-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0f51c6ba-a6c0-4fbf-9b00-21cea6d59ca9@kylinos.cn>
Date: Thu, 22 Feb 2024 11:04:55 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cred: Use KMEM_CACHE instead of kmem_cache_create
To: Paul Moore <paul@paul-moore.com>
Cc: axboe@kernel.dk, elena.reshetova@intel.com, linux-kernel@vger.kernel.org
References: <20240130094037.76895-1-chentao@kylinos.cn>
 <CAHC9VhQG6XAm3R3wtgFrb0b0UHoxkSV2yziVAnUy2x7Ovun_pQ@mail.gmail.com>
 <CAHC9VhRLNHT0ar2YPkZBsyha_mh6Ggf6=V2gnbFkdo7ryXmHnQ@mail.gmail.com>
Content-Language: en-US
From: Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <CAHC9VhRLNHT0ar2YPkZBsyha_mh6Ggf6=V2gnbFkdo7ryXmHnQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Thanks for your reply.
On 2024/2/22 08:10, Paul Moore wrote:
> On Thu, Feb 15, 2024 at 10:54=E2=80=AFPM Paul Moore <paul@paul-moore.co=
m> wrote:
>> On Tue, Jan 30, 2024 at 4:40=E2=80=AFAM Kunwu Chan <chentao@kylinos.cn=
> wrote:
>>>
>>> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>>> introduces a new macro.
>>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>>> to simplify the creation of SLAB caches.
>>>
>>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>>> ---
>>>   kernel/cred.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> This seems reasonable to me, unless I see any objections I can pull
>> this via the LSM tree next week.
>=20
> Actually, never mind, the original posting has some non-ASCII junk in
> the patch and I'm not able to import it cleanly.
Thanks for reply.

I checked the patch with the checkpatch.pl script and applied it to=20
another machine to compile and found no issues.
Seems ok to me, what should I do next to clean up that non-ASCII junk.

And i use :perl -ne 'print if /[^[:ascii:]]/'=20
0001-cred-Use-KMEM_CACHE-instead-of-kmem_cache_create.patch seems ok too.
>=20
--=20
Thanks,
   Kunwu