Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp98540rdb; Wed, 21 Feb 2024 19:09:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX8144a9jlSvqqVoOlP8Qf4TPObDfrA5GrTdAT9QDDrgkkmXJNi6QEYgFZNTt5bmoXySoveAazgdO0FB43dt2tDhC+Z1IOTLnlZDRqWng== X-Google-Smtp-Source: AGHT+IHbJs40vcyO90s6mBmXYe83IsHMBVtfjk7l+IB8obQa1IQ9+CP47vRdUXWNnhYQkuqxnafU X-Received: by 2002:a17:906:f749:b0:a3f:8ee6:29b9 with SMTP id jp9-20020a170906f74900b00a3f8ee629b9mr17446ejb.77.1708571361849; Wed, 21 Feb 2024 19:09:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708571361; cv=pass; d=google.com; s=arc-20160816; b=ZpeRsYDGYLghcrTg8si8gQomLJ1C1StCoygJzdi7tEGtn/Tx5yza7JaJoGnpFGIAV4 nmzZ1c77BhpS6fCTrj8Jmvs1Qay83/Pk1dwEn/Q3MGiM9xTBP4buejpjQiwGdXnrOx4F yNZDpg5pyAwxsf3PlCx5FnHoZBsI/7Ui2pVEXjcXWvs4vTEdZ8Wf2kAgI+hrQc7PHoN1 trHjRWFtw+0hr+t0RzFY83PZQ9Hizjnx3S4GQ0NNy4+2nQLDiTIdjvJhiz2ztz70wgsk JB3O4Jh5yWQbsd8nehaxb8o9NRayFUqWDdU+7uYByel/4GH33tKXVx/cWjPLkTz+aOvq gDbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=utSs3m/ghTp4R805q7ZPfnuZ2Nk1u20QIFsToJjeTH0=; fh=VSR3/03qObaMhoeGkiq0O8ksZITetS++CiOrOndLoCQ=; b=CfSNFzH9E5KCccIuRzf+LApLPWnE+Z1EkM2CAIe4n4eQPmZWczKDNpjaNeTd4RMoP/ cb4vrUO6jWAvg2N9G5VH7T6mXpyWsf0gwOTf/9KzeQFa+Bvyzo7qcWRGX1FqsUpL3iGM b5pzFCrlsm5V0pU21n99gnWrw0kNPAxO5HEu9iuHureDaoIN5b1i2e6s3mQulSTXDPig QlGm2mlqHGQ5Lq7Vy0FsoUxFD1t37tnO0EXdtUkyvKZspOMSlTSzIpDzXFXuZH8v8wWY TuE0WTVAf3KgfJhz7tXVW4ZGgSWR7aRHHO87jOIDLxf6wTmCaia7OgjfmtLT+uK4OnNm jqyA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-75835-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75835-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id me11-20020a170906aecb00b00a3ee2eede53si2442052ejb.1048.2024.02.21.19.09.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 19:09:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75835-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-75835-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75835-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 98B4C1F23D61 for ; Thu, 22 Feb 2024 03:09:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6B5217564; Thu, 22 Feb 2024 03:09:13 +0000 (UTC) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28FE410A12; Thu, 22 Feb 2024 03:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708571353; cv=none; b=OrA5g639gk+YMy6XI9aDlUuXI5ypNO/MrPCGEBx3sTJ+JcWerQViWyOwm0p99UB1RpQ2HAqBlMv5D9YAp+dvnkxaYvH6YLjPl+80dUboryiO/e0wsXZkp1391BaXmhfCmVZRi7/hT5i0nW6E5HyrnPBVzdUHK/RO7u87rgoPCy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708571353; c=relaxed/simple; bh=utSs3m/ghTp4R805q7ZPfnuZ2Nk1u20QIFsToJjeTH0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OgpEo/T5PgA2ZPG0VK6tyx2645SQlBbaWF/jSwHYS/9MpocBaKXX04pykzx+/jV0n9FIXkda/F6kua3u84uzr4FvmpJKDXql+de5iw52c1BclXtWWyekl1p8DLPDH+ykyqdKiarSBgT2eXiws+yOIkmsjZcmhBzRbjeI869aNYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dc3b4b9b62so3883025ad.1; Wed, 21 Feb 2024 19:09:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708571351; x=1709176151; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=utSs3m/ghTp4R805q7ZPfnuZ2Nk1u20QIFsToJjeTH0=; b=EmN7hVvJfya12V21lLC5e+Fi07GPwiIrbU2x0cBoBXiw/7zbfqUPMT+V/X9kgESK0o TuXP/ZE7jHcblU5Zb57oxlfeh3uOmOUOR9nW2zvEnKqFOwxLtQenR6xlHWCkx0tiutir SyHTcGMUXQ6DiB1LBCZulw5MuYLp+8CJdnzOYatSvnLoJmQxYRpjEVwhpFb/CMVDUqZk gy7GDvhE1M0TKVs9aP1bSUlFJ+h/EhjQ+o+Dwmcv9F0SnX11A/6XKDSV4S4Zbhbiy+Zy oaNI6+vF0lxKUaZ8i8hIoiIL04/pItvemnIxp9n/0yVdWbokvAzTM8t2ct5xxvQGsHJ5 OeeQ== X-Forwarded-Encrypted: i=1; AJvYcCVrxjVMr8RDgcPwPeC3rnOSwNDLbg+4JzGS1zHSPiMQRDp/ZTIHIqx7hLTsXGsYQFARZRNRSHwpx2YkvHWwG8sug3T61Qo8MAadkhm3AhMDcTViKA8HpZscEBNYVO14vWA4AspEKJDKNw== X-Gm-Message-State: AOJu0YyIuwe/lHsxyHhxW4P1K4bta+kqTrI+6rjx5AXJ3eOHd08rqHQb XkQd46q86jItHmB1caS5q1l2LWbIQJK/UhTe0v2tokgTFd+GvFAz X-Received: by 2002:a17:903:2288:b0:1db:bd46:a429 with SMTP id b8-20020a170903228800b001dbbd46a429mr2039102plh.28.1708571351085; Wed, 21 Feb 2024 19:09:11 -0800 (PST) Received: from [192.168.51.14] (c-73-231-117-72.hsd1.ca.comcast.net. [73.231.117.72]) by smtp.gmail.com with ESMTPSA id w12-20020a170902d3cc00b001db398d13ecsm8780462plb.258.2024.02.21.19.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 19:09:10 -0800 (PST) Message-ID: <9eb36b38-87a3-4619-be64-8a6ccf3b407d@acm.org> Date: Wed, 21 Feb 2024 19:09:07 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scsi: ufs: core: Fix setup_xfer_req invocation Content-Language: en-US To: Can Guo , Rohit Ner , Bean Huo , Stanley Chu , "Martin K. Petersen" , Jaegeuk Kim Cc: Avri Altman , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240220090805.2886914-1-rohitner@google.com> <1920a2f6-e398-47af-a5d7-9dad9c70e03d@acm.org> <0f959cca-ad29-4b8b-966d-55eb37156ef8@acm.org> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/21/24 18:05, Can Guo wrote: > The if-statement you are mentioning here, is it the if (hba->vops && hba->vops->setup_xfer_req) or if (is_mcq_enabled(hba))? Hi Can, I was referring to the latter if-statement, at least if it would occur in the code that you plan to post and that I haven't seen yet. Thanks, Bart.