Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp101052rdb; Wed, 21 Feb 2024 19:17:23 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVQC8NCNCTwAkOipsRBQi5qVjhrUyKt5sKP15uiD61PnjEbNWPEOXeSLBuei3VHlWMEJ8jCyunQ0/QDp42WGmmxxQ+Kx2Kuhi195ZmHRQ== X-Google-Smtp-Source: AGHT+IHhekOX0BJS9ZILEOVqOtkT8Y07etZp/FWLulJ6BBk5SuaE5z9ya9qd+RWRndZILKVPlZQO X-Received: by 2002:a05:6808:10d3:b0:3be:845f:3aa7 with SMTP id s19-20020a05680810d300b003be845f3aa7mr23995854ois.45.1708571843118; Wed, 21 Feb 2024 19:17:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708571843; cv=pass; d=google.com; s=arc-20160816; b=SsIxcHjtthCqHtnNZ4qcSnvof3D50e5z4CG4fh6h5q6CAynh87O69f/MjIguBrUSFr H2fiyz4Qkq1XArgdVxsjJc87Z5CiqjcAygPuTkBXcYMCD4siY81poXLlyrfL3rgU0Ajq yREwtTSpn0ATCofhH496Vssgh5o3mgFJDX3ATkYBl0RiIOzePzomObldjOt69MS4bxMH +p6nDWGx4N6/WVmsXVggi8PQQ5zDYn1S5wTstK6zQHodP5JlxvVhJoWxW1JlgctfXYvx L5l/ihd5bG8VaWiZ5jaSf66V17ajtydBV6L5cgLcyPURhW2oLpanbo3VuakXp0rEg5ki rgmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IoXHM+O4hDWnOg96B/lgZGtFkIfBFZzCbK7uno8KvXI=; fh=QDP2V0qE671UBSS3I8PtDEY31LGUkoQV4rlz0ZFqZqU=; b=gzh4VP4Jhp100b2ZSp/+0PrrmKaOxo4rKqn+YLci56rHlHPJ982CI57UMXFydNK/Dr 3WKkQYti6zlR35CE3pA3VexyBK/9MP4vKosnw91pNd8bmY6yqaglqVIawXMXp1MQhQrr YnACmblpbRhZyX50Sad5pK7y5YoXSmPLMlGqb30CCWWs/u1aJl85Vw9CYW1InVvmxkhJ rCI+sGrlNadwtqzHBXP/f8yU1rRerUqdFq/ThOpL3Xvb3dCc6Y46H20mAmpcfluMoafE EFsljsXrvxaeAr7WUWceLF9fR2zOKbqgWkmoPTf63Uf7cBkwITPv0QY30dPhvD0YdpM2 Vv3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@windriver.com header.s=PPS06212021 header.b=l4LvchXu; arc=pass (i=1 spf=pass spfdomain=windriver.com dkim=pass dkdomain=windriver.com dmarc=pass fromdomain=windriver.com); spf=pass (google.com: domain of linux-kernel+bounces-75840-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75840-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=windriver.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f28-20020a63381c000000b005dccf9bcaa5si9009942pga.597.2024.02.21.19.17.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 19:17:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75840-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@windriver.com header.s=PPS06212021 header.b=l4LvchXu; arc=pass (i=1 spf=pass spfdomain=windriver.com dkim=pass dkdomain=windriver.com dmarc=pass fromdomain=windriver.com); spf=pass (google.com: domain of linux-kernel+bounces-75840-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75840-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=windriver.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E8E9328310F for ; Thu, 22 Feb 2024 03:15:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 45231171A5; Thu, 22 Feb 2024 03:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="l4LvchXu" Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF34F12E4A for ; Thu, 22 Feb 2024 03:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.178.238 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708571751; cv=none; b=td7hWbiZq5F2U2PiAeNw3ZQQK1/imGqX3SYkGyj6Iy4YzHiXcZcmhFC28uPPwKEfLQlslV9ks1queUBZDln1lYxUKXknAO71rjYhxpb1R3rn7GJbx+LM+DPTLg/j20XQnkNEpxHaykVEDcb+HEqrJaWSzBPrRl1Ce9WIWDdwuGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708571751; c=relaxed/simple; bh=8Ebf60YgQFc6nl1iB9fJx8bOTjo/YRpxJSkjf/BLdl8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HIvmXHi3Tj306zcEJKcmgAXp8tpSC0vMrF29jCXMBcRgL8DLVPoZp7mXgS0O1dFx+8Xn3Lxxrtxsdr8D48y9K+rVrlZOFjMSEkh8SWI9N5ceVgk8FvhYPpqMJdA/cSRpnPVSBj+7SHg/WQihn8SO5nOUVabMtajRi9esDPi9w4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=l4LvchXu; arc=none smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41M2hoBo008848; Thu, 22 Feb 2024 03:15:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=IoXHM+O4hDWnOg96B/lgZGtFkIfBFZzCbK7uno8KvXI=; b= l4LvchXu8RmafomJad5t3oSZ0hxXwGn2LcoU12wAZauTL7qWXOkNdmN8hb95guXO unX6t3X5yDsVyI9ZKeQcynSrWxJJuuPenDaI6RGO0QPBUudb8EphLOtr8Jg6zaqc M/2KpBXht0C5CvW1zjVfIgkSXY7hAR+64Fm7+EWJyQVzcVFyOs0d4imAdhDb7s0C 5/P6pKC7sSIUOR2tokYLDtni1NL53USYRkUs4PcetVP7yhjDliIesXYWKYElcXM7 pOI0n3xmAS07s4EPowClP2HwHdMQxY5XruZ1qRTeyOuzwqYK9M6UBPuxde09sxfd Ce9Qc3e4EOdwWqc2h3f3OA== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3wd218hhqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 22 Feb 2024 03:15:42 +0000 (GMT) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 21 Feb 2024 19:15:41 -0800 Received: from pek-lpd-ccm6.wrs.com (147.11.136.210) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 21 Feb 2024 19:15:40 -0800 From: Lizhi Xu To: CC: , Subject: Re: [syzbot] [net?] WARNING in mpls_gso_segment Date: Thu, 22 Feb 2024 11:15:39 +0800 Message-ID: <20240222031539.2038610-1-lizhi.xu@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <00000000000043b1310611e388aa@google.com> References: <00000000000043b1310611e388aa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: 17T5v8jlnImoTHc9Nq1SXYX4L3LS2uR1 X-Proofpoint-ORIG-GUID: 17T5v8jlnImoTHc9Nq1SXYX4L3LS2uR1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-22_01,2024-02-21_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=807 mlxscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 clxscore=1011 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402220024 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git main diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c index 533d082f0701..2ab24b2fd90f 100644 --- a/net/mpls/mpls_gso.c +++ b/net/mpls/mpls_gso.c @@ -25,11 +25,11 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff *skb, netdev_features_t mpls_features; u16 mac_len = skb->mac_len; __be16 mpls_protocol; - unsigned int mpls_hlen; + int mpls_hlen; skb_reset_network_header(skb); mpls_hlen = skb_inner_network_header(skb) - skb_network_header(skb); - if (unlikely(!mpls_hlen || mpls_hlen % MPLS_HLEN)) + if (unlikely(mpls_hlen <= 0 || mpls_hlen % MPLS_HLEN)) goto out; if (unlikely(!pskb_may_pull(skb, mpls_hlen))) goto out;