Received-SPF: pass (google.com: domain of linux-kernel+bounces-75887-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <bc21a164-77d5-0e6a-26f8-93573e875e28@amd.com>
Date: Thu, 22 Feb 2024 09:35:58 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 00/30] PREEMPT_AUTO: support lazy rescheduling
Content-Language: en-US
To: Ankur Arora <ankur.a.arora@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
 peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org,
 akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
 dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
 juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org,
 mgorman@suse.de, jpoimboe@kernel.org, mark.rutland@arm.com, jgross@suse.com,
 andrew.cooper3@citrix.com, bristot@kernel.org,
 mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
 glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
 mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org,
 David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
 jon.grimm@amd.com, bharata@amd.com, boris.ostrovsky@oracle.com,
 konrad.wilk@oracle.com
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <15fcf98c-58c5-fa08-2e21-f3b0baf058e6@amd.com> <87zfvtg2mh.ffs@tglx>
 <f1a5fe09-f4bc-0dc5-edda-6b3e690bc0e3@amd.com> <87ttm1frgf.fsf@oracle.com>
From: Raghavendra K T <raghavendra.kt@amd.com>
In-Reply-To: <87ttm1frgf.fsf@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0wrV1hJOE5MUEg5TDIrZjY1ck9zcHFYU01ucFZISEZUL3FZTlRGOWl6QkxI?=
 =?utf-8?B?VnBWc1hEY09ydGZFbGU2eEcyd1hUdDZDb3U5dng0QWpldmJkYjBKSnVPb1BF?=
 =?utf-8?B?YjY0RGdTdVlZL0ZDRXMrM1Q2V3Vscm0rNStHNVZ5UW5WUUVsU2pOVnF1OXBZ?=
 =?utf-8?B?ZmM0WXNZRkdXYzFwZW5JS25KcytJaDlxN0tVaStZN3ZNVnN4NEw3aUhneVRO?=
 =?utf-8?B?ZXdtdDVxM2djSHd1azJrVGhOY0kxTlV0KzlGYy9TajFHVDd5ampyTFUyV25K?=
 =?utf-8?B?a2FtNDRVdWNYMkJoVmxXNnBBZmYyaDBvV1BzVTBxMktJLzJPQkZNa3NuSGl3?=
 =?utf-8?B?UFBQVlNvYlhoNnFaazNUbXV0N3hJeWVld00vVHlKcXdNQWNQQVZtbzlSNC9W?=
 =?utf-8?B?RzRDZG5sVW1GaWQvS0xJMHhXS05GNGNJWVd1UG9Vb1dpRGFtR1NhYnZjQ3E0?=
 =?utf-8?B?WUhONkMweG92TFdlTDRnTkdhckMzdnVyUGN0dW1wRG5PdktvU1ZnamFnV084?=
 =?utf-8?B?Nm1RZDdGRDZ1dFlnRHNyaTRvL3RwWXJRREtmanl5VXBmMmNrODNmMG0zSXE1?=
 =?utf-8?B?U0JMQU02amhmUm01MnFWQnd0MnNnSjBMMGlaZnNOeTZRNDk5UjdvOWRxQnVN?=
 =?utf-8?B?ZVNHSmJZZzg0eHBlaTJOYm83UVF0R1Ivb0kzN2NpT2h4VWNhaWdUNUhIVmtK?=
 =?utf-8?B?SE9OQlg4SXBCQU9WMjdSU2hic2t3bGg4YTBnbDJlcFk1cWlYME9yUVBYbUxa?=
 =?utf-8?B?STgvVXVDeExVZlpFbkNZUW81TWRjTXpHUEI1MDNlTU9MTVIvbmduaC9ZSTcw?=
 =?utf-8?B?ZFVIOW82ZVFzVDVmWnhqWGZmMnlUOGp6Z0JqNjcwbHA3R20vMTZxQVp5VHc2?=
 =?utf-8?B?YUYxckt2UkcyYzdqMGpwY0tsbEg4Zjg4T09pem9ualBhdWFhMjc3LzMzRmJY?=
 =?utf-8?B?anpYRmFMT28raVBkTm1VdnZua0x6NEZWQ1REMWdvUFc3bmh5OGZrSXB5M3ZQ?=
 =?utf-8?B?SCs1TzZQS0Nac2VyZ2czdjFpd1d1TTNrY3BTMWdXVmZaNkpHbmtGTWtYZHdB?=
 =?utf-8?B?eXdGbUx4RXh5UUZkRUFYQnZJWm8xeGM2WE5CbjZsVDFKekN1ei96Q0pIYmFB?=
 =?utf-8?B?T0R0T3o5SDVZaFNGQmFyMVgvK2pzTFI3VWNtT05DUGJLREEwL1FmblplWlRH?=
 =?utf-8?B?MlluNVlyL0lXSzlycExYbDhNVzBidjEvQ1hSd3JhTnc4ZVNWWG5nWVVBQXZt?=
 =?utf-8?B?MjlSN2J5Qi9JMk1nZk51WWpWcnY2b0hWWHhRVDBoZ3F4L1JjUmc5djFSZlJE?=
 =?utf-8?B?dGVxaUw5YUFKTUllOGVrSkUzdlV3UG9VSGx3MC90V1Fmc2d2Sk8ybnd1Sld3?=
 =?utf-8?B?STFPUG51ZGhGRmhabnFaRTJiOGQ4TEVrVlQ5UUhyblJ0VmJrWnJSL2MzZ0RM?=
 =?utf-8?B?YWxqWFcrNWZJN0lzOFA5b2RZN0E1TmVXZE5wamROcUtJMzR0eFBFTWdDclNs?=
 =?utf-8?B?ckFJaC9pYktxcnR6V3d0NFlDanlFNFZtZVhoYzd1RjB6VFliMXUzendYa3ZG?=
 =?utf-8?B?NHdkdTdya1BNRGR2Nk9mWFRJaC9RMHNPMjEwMjVwVDV5UWkwMkhGQUxBNTFr?=
 =?utf-8?B?R1R0bWFVNkM3OFQ1TUs4UDZ2dWVzV1RhUjRLVjdoeWNKbU1JTmJJSFdvaUZ5?=
 =?utf-8?B?RHpwSElZYU1lNHh3N3NxVFpsaVl1cWs5WDNzblh5a1A3Q21mODEyNmUvTXR1?=
 =?utf-8?B?VFE0VVJldWFDYWd6S1VjTXcxYjkyWkd4MzhOdWt5dFZPdWlYUWZKRUkvZGRF?=
 =?utf-8?B?RklNb1MrMGU4amFLVFlEMzE4ZG94QWF3SU5IL1JUTEg4c2tyZ2RTd2NYemJP?=
 =?utf-8?B?T1lGSE10NjN5S0k3WUhBUGQ2VzF4S21NcDZJZFNXQnlQWnpEakNJN2pzTFBy?=
 =?utf-8?B?L3ZTQnFNVkRDcFpNMFRlbFpBMS9Ec2lWKzMwQU1vd0ZFSjVlL1FFYTVhRzRj?=
 =?utf-8?B?MnZta3FOdFpxaEVMVklXK2dWTUpLcUVFbVVhWTBESnVVdVFTdjRVZWhQenB5?=
 =?utf-8?B?Q1VMRTErUDd2TG82N1FGcFpTWEJCNk5Ea1pkZFEyY2s1K0xPNjdhSlNiSVlS?=
 =?utf-8?Q?CpqRfkMHvIEbqFFFZ8Y+lU/Mf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c3a3c12-740f-4338-a899-08dc335b9c9c
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5805.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 04:06:14.5920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YSgb3BCPJv5KXvO6KgTsnL2tfzI9yXwJO7DQYsplXr0Xse0Etfl/c3ldJcw+fktE30nhg8Q6zkoYdhXX7x4QIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6630

On 2/22/2024 2:46 AM, Ankur Arora wrote:
> 
> Raghavendra K T <raghavendra.kt@amd.com> writes:
> 
>> On 2/21/2024 10:45 PM, Thomas Gleixner wrote:
>>> On Wed, Feb 21 2024 at 17:53, Raghavendra K T wrote:
>>>> Configuration tested.
>>>> a) Base kernel (6.7),
>>> Which scheduling model is the baseline using?
>>>
>>
>> baseline is also PREEMPT_DYNAMIC with voluntary preemption
>>
>>>> b) patched with PREEMPT_AUTO voluntary preemption.
>>>> c) patched with PREEMPT_DYNAMIC voluntary preemption.
>>>>
>>>> Workloads I tested and their %gain,
>>>>                       case b                   case c
>>>> NAS                +2.7                    +1.9
>>>> Hashjoin,          +0			     +0
>>>> XSBench	     +1.7		     +0
>>>> Graph500,  	     -6 		     +0
>>> The Graph500 stands out. Needs some analysis.
>>>
>>
>> Sure. Will do more detailed analysis and comeback on this.
> 
> Thanks Raghu. Please keep me posted.
> 
> Also, let me try to reproduce this locally. Could you post the
> parameters that you used for the Graph500 run?
> 

This was run as part of test suite where by from output, Parameters, I 
see as :

SCALE: 27
nvtx: 134217728
edgefactor: 16
terasize: 3.43597383679999993e-02
A: 5.69999999999999951e-01
B: 1.90000000000000002e-01
C: 1.90000000000000002e-01
D: 5.00000000000000444e-02
generation_time: 4.93902114900000022e+00
construction_time: 2.55216929010000015e+01
nbfs: 64

Meanwhile since stddev for the runs I saw was little bit on higher side,
I did think results are Okay.

Rerunning with more iterations to see if there is a valid concern, if so 
I will dig more deep as Thomas pointed.
Also will post the results of run.

Thanks and Regards
- Raghu