Received-SPF: pass (google.com: domain of linux-kernel+bounces-75893-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: iad51458e:Fastmail
Date: Wed, 21 Feb 2024 20:12:09 -0800
From: Boqun Feng <boqun.feng@gmail.com>
To: Waiman Long <longman@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	George Stark <gnstark@salutedevices.com>
Subject: Re: [PATCH 3/4] locking/rwsem: Clarify that RWSEM_READER_OWNED is
 just a hint
Message-ID: <ZdbJmbltYYBPvU-3@boqun-archlinux>
References: <20240213031656.1375951-1-longman@redhat.com>
 <20240213031656.1375951-4-longman@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240213031656.1375951-4-longman@redhat.com>

On Mon, Feb 12, 2024 at 10:16:55PM -0500, Waiman Long wrote:
> Clarify in the comments that the RWSEM_READER_OWNED bit in the owner
> field is just a hint, not an authoritative state of the rwsem.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Reviewed-by: Boqun Feng <boqun.feng@gmail.com>

Regards,
Boqun

> ---
>  kernel/locking/rwsem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
> index 2340b6d90ec6..c6d17aee4209 100644
> --- a/kernel/locking/rwsem.c
> +++ b/kernel/locking/rwsem.c
> @@ -35,7 +35,7 @@
>  /*
>   * The least significant 2 bits of the owner value has the following
>   * meanings when set.
> - *  - Bit 0: RWSEM_READER_OWNED - The rwsem is owned by readers
> + *  - Bit 0: RWSEM_READER_OWNED - rwsem may be owned by readers (just a hint)
>   *  - Bit 1: RWSEM_NONSPINNABLE - Cannot spin on a reader-owned lock
>   *
>   * When the rwsem is reader-owned and a spinning writer has timed out,
> @@ -1002,8 +1002,8 @@ rwsem_down_read_slowpath(struct rw_semaphore *sem, long count, unsigned int stat
>  
>  	/*
>  	 * To prevent a constant stream of readers from starving a sleeping
> -	 * waiter, don't attempt optimistic lock stealing if the lock is
> -	 * currently owned by readers.
> +	 * writer, don't attempt optimistic lock stealing if the lock is
> +	 * very likely owned by readers.
>  	 */
>  	if ((atomic_long_read(&sem->owner) & RWSEM_READER_OWNED) &&
>  	    (rcnt > 1) && !(count & RWSEM_WRITER_LOCKED))
> -- 
> 2.39.3
>