Received-SPF: pass (google.com: domain of linux-kernel+bounces-75896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <61113ffd54a32399ebdc31fc1a57912f.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240121142946.2796-1-erick.archer@gmx.com>
References: <20240121142946.2796-1-erick.archer@gmx.com>
Subject: Re: [PATCH] clk: hisilicon: Use devm_kcalloc() instead of devm_kzalloc()
From: Stephen Boyd <sboyd@kernel.org>
Cc: Erick Archer <erick.archer@gmx.com>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
To: Conor Dooley <conor.dooley@microchip.com>, Dinh Nguyen <dinguyen@kernel.org>, Erick Archer <erick.archer@gmx.com>, Gustavo A. R. Silva <gustavoars@kernel.org>, Heiko Stuebner <heiko@sntech.de>, Michael Turquette <mturquette@baylibre.com>, Nick Alcock <nick.alcock@oracle.com>, Rob Herring <robh@kernel.org>, Uwe =?utf-8?q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Date: Wed, 21 Feb 2024 20:27:32 -0800
User-Agent: alot/0.10

Quoting Erick Archer (2024-01-21 06:29:46)
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>=20
> So, use the purpose specific devm_kcalloc() function instead of the
> argument size * count in the devm_kzalloc() function.
>=20
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-c=
oded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
> ---

Applied to clk-next