Received-SPF: pass (google.com: domain of linux-kernel+bounces-75897-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
CC: Hans de Goede <hdegoede@redhat.com>, "Winkler, Tomas"
	<tomas.winkler@intel.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/3] mei: vsc: Don't use sleeping condition in
 wait_event_timeout()
Thread-Topic: [PATCH v2 2/3] mei: vsc: Don't use sleeping condition in
 wait_event_timeout()
Thread-Index: AQHaY23/G7Ad4wSizU2laz4CmCk5ALEVyEcQ
Date: Thu, 22 Feb 2024 04:30:57 +0000
Message-ID: <MW5PR11MB5787DEE4AE33992DFED13B2D8D562@MW5PR11MB5787.namprd11.prod.outlook.com>
References: <20240219195807.517742-1-sakari.ailus@linux.intel.com>
 <20240219195807.517742-3-sakari.ailus@linux.intel.com>
In-Reply-To: <20240219195807.517742-3-sakari.ailus@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1xKjXUpRHzZw708EXalLvqN/fjPSznLILs53ZYz3Z2Whflv3GuLEI5ny6QE/?=
 =?us-ascii?Q?bKLPrSwS+IRZqM5K2cFHqXRkEYZhHi99pB4rXMXUswfUbW1UI5UqNpIg++n6?=
 =?us-ascii?Q?sLXTyeQPWRa/StNfl2aPcTQK3ESEWndxppatLTJwwKM4XEaztKdCdbrSKfDd?=
 =?us-ascii?Q?B+xuAygoMJSZP+lXqqSNx9QT3P0ksUnYxVnFFBGoonC50c6IOuJYVa19WwZU?=
 =?us-ascii?Q?RkBPykc+pddwwRYbVGmGgSWMipxpIutt7WNb+6PTgrmTShVtPioyqnX13JvZ?=
 =?us-ascii?Q?qLUsX+HzTidpYoNMj3tU3J7Hrd3G7rUt29rXapUiJO8j3aJQoXWFBfVNwNo1?=
 =?us-ascii?Q?YrYlCbITlkfaeVLI0xATYeT5FNfZzZtZVFJDU6gResKwTSF2C1GSAvfingwu?=
 =?us-ascii?Q?riU3hy6tIhggiytNKnbYfrCAEDS90yJSfu++vtayg10koGxUDW7d99UVv04F?=
 =?us-ascii?Q?OkTFFh/WY4QfnTeJzKDuf5dLPVd0jLUSLd3NLXRHlHvZH2VSH50Qo5bGqDPP?=
 =?us-ascii?Q?McMg0HZjh1YcVuaL7KDArc1Ki5lG89lGmrG8yJiwub/36j4+rhc7vdQgqwUu?=
 =?us-ascii?Q?cvY2RbHaVVxBpdXqfoUl/DqnlJ7rVA2zKyVP19Lap7ZFBX7sUXaHunhlY5zj?=
 =?us-ascii?Q?z8HmAwtU8s0CltpGH/xhg1CTvcF7SflE3jvDvJkKBZKGJv6IVdMN6ZJFacb1?=
 =?us-ascii?Q?8w9gf/Be7xH+F7S71sGauzU8wz5U3Iuu2BOd/sHg2TLBjAKlex7uA56sZwzy?=
 =?us-ascii?Q?CY6bmoK4Q1P/OGdQofCR4MpM0ZfwujTFM2uWlN55XRVy4gWucZ/1DrVwdytr?=
 =?us-ascii?Q?Se94odCo27hRache58EYxuntVG2rIg150r8qaGzVigaKmn5H21daew5c8BuF?=
 =?us-ascii?Q?uFr0n8i4tzwBUxNfU5WqVEBY4FhKn4/Dzloo39u0iAFZJd3Qvh8jyrr+uY7I?=
 =?us-ascii?Q?j+PRE1E32FKwlnWaFA88JzS79yVRCIHpJoDP9chp8MGnihiMLB3o1BwkZl7w?=
 =?us-ascii?Q?JeOrxA6U3wn96pLLSbieJLQFR+9mQ+sueAYgZWpA3dkFWLouohf5VVeRigjk?=
 =?us-ascii?Q?DYBtlA50PHevdMAswCNrL/9SMz09COR9N+citOGvGYEY5lhKXurvBaJjfoWz?=
 =?us-ascii?Q?gTf7dVq1NYNFE5q7nBUkqSLaKEOP/dOOiSUE5BVlcIWJfb8teGCEhn5nLxFy?=
 =?us-ascii?Q?neLMfwGuTA9cZ8WElMrxoC+bXIxdvpFLir1kDlG98VGZNA4KLbbqcLUQTqQL?=
 =?us-ascii?Q?vh8EixbqmCC2VOlGZQvQHfQkZkgEQc8UFxC9oU3vUuhk+FEdPARqrTMNywvo?=
 =?us-ascii?Q?NVn7IQud1w5E/758GMXGnLD9xvnJU2+yKmFxW1037Uf6pL2/XaXg17ewAir7?=
 =?us-ascii?Q?W5gYJj+HfPzyUPjOVamt3CKtOaJKHTytJ8qG9t48zmeoVQbZX29Lt/oDVoOB?=
 =?us-ascii?Q?GNNWUk+2njoJrhTIQvsI3WvKNTjL1dF2RseVTVLQ493yfAwgUYzi/+oqN96a?=
 =?us-ascii?Q?ytc9WzFZNqWhZ3Jzz1GV5Eh2uZEqrRIEJLJGklEFkPchZnazU3zGgXU4xoeS?=
 =?us-ascii?Q?efUQxX9wgAQz+vqHk97ygpzyijl1tC2O7zW0yoNo?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5787.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e919f06-f2c7-480a-baeb-08dc335f1073
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 04:30:57.0202
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Uf8d+v02ZSzaiE8Tbw+Z1DvbMq3UbRK7CgdNxFwL3ahapnKC9G9bpRlAyX5FUukXidQnplIH2zrnEEr9dDt+Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7365
X-OriginatorOrg: intel.com

> From: Sakari Ailus <sakari.ailus@linux.intel.com>
>=20
> vsc_tp_wakeup_request() called wait_event_timeout() with
> gpiod_get_value_cansleep() which may sleep, and does so as the
> implementation is that of gpio-ljca.
>=20
> Move the GPIO state check outside the call.
>=20
> Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Tested-and-Reviewed-by: Wentong Wu <wentong.wu@intel.com>

> ---
>  drivers/misc/mei/vsc-tp.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> 2b69ada9349e..7b678005652b 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -25,7 +25,8 @@
>  #define VSC_TP_ROM_BOOTUP_DELAY_MS		10
>  #define VSC_TP_ROM_XFER_POLL_TIMEOUT_US		(500 *
> USEC_PER_MSEC)
>  #define VSC_TP_ROM_XFER_POLL_DELAY_US		(20 *
> USEC_PER_MSEC)
> -#define VSC_TP_WAIT_FW_ASSERTED_TIMEOUT		(2 * HZ)
> +#define VSC_TP_WAIT_FW_POLL_TIMEOUT		(2 * HZ)
> +#define VSC_TP_WAIT_FW_POLL_DELAY_US		(20 *
> USEC_PER_MSEC)
>  #define VSC_TP_MAX_XFER_COUNT			5
>=20
>  #define VSC_TP_PACKET_SYNC			0x31
> @@ -101,13 +102,15 @@ static int vsc_tp_wakeup_request(struct vsc_tp *tp)
>  	gpiod_set_value_cansleep(tp->wakeupfw, 0);
>=20
>  	ret =3D wait_event_timeout(tp->xfer_wait,
> -				 atomic_read(&tp->assert_cnt) &&
> -				 gpiod_get_value_cansleep(tp->wakeuphost),
> -				 VSC_TP_WAIT_FW_ASSERTED_TIMEOUT);
> +				 atomic_read(&tp->assert_cnt),
> +				 VSC_TP_WAIT_FW_POLL_TIMEOUT);
>  	if (!ret)
>  		return -ETIMEDOUT;
>=20
> -	return 0;
> +	return read_poll_timeout(gpiod_get_value_cansleep, ret, ret,
> +				 VSC_TP_WAIT_FW_POLL_DELAY_US,
> +				 VSC_TP_WAIT_FW_POLL_TIMEOUT, false,
> +				 tp->wakeuphost);
>  }
>=20
>  static void vsc_tp_wakeup_release(struct vsc_tp *tp)
> --
> 2.39.2