Received-SPF: pass (google.com: domain of linux-kernel+bounces-75899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: Hans de Goede <hdegoede@redhat.com>, "Winkler, Tomas"
	<tomas.winkler@intel.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>
Subject: RE: [PATCH v2 3/3] mei: vsc: Assign pinfo fields in variable
 declaration
Thread-Topic: [PATCH v2 3/3] mei: vsc: Assign pinfo fields in variable
 declaration
Thread-Index: AQHaY24Bk28kLcAL10ONhEVbO4aOPrEVyROw
Date: Thu, 22 Feb 2024 04:32:31 +0000
Message-ID: <MW5PR11MB5787B67F0BAD9FA6162042578D562@MW5PR11MB5787.namprd11.prod.outlook.com>
References: <20240219195807.517742-1-sakari.ailus@linux.intel.com>
 <20240219195807.517742-4-sakari.ailus@linux.intel.com>
In-Reply-To: <20240219195807.517742-4-sakari.ailus@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YVlzI5uwbG0WClUtp7wIRxQdl60z7TuW24BKxQREFu98/2bNceNoWm4ioM82?=
 =?us-ascii?Q?NC3dIz2mGsTTW7SQwpIuFAnZNkGnRRImF9UgUD5B3eZk+HpTLq0CyLos5DX3?=
 =?us-ascii?Q?AVzG9Icxu0BcaC7uQhp9HPexyluFYuEBDiduLPCc2aYjg2S4lqFLwpshf6yD?=
 =?us-ascii?Q?JBEAT5853nWJapSYv7UnYGyUt0uO/wQP1c4XIX9Nxi5/OHSWk1kC2sGkoLn+?=
 =?us-ascii?Q?IrSfuWg/wQ7KSwfrKCbhRvHF5rMu1/J0YT5mDua1XMoXR1jjRgsfPaGkFbYb?=
 =?us-ascii?Q?v52c9UpmGgYkQxdGNp6rFkpVyQd+R7XbSJ02gqK0ceLXl0mX1Q1EP+lW/miH?=
 =?us-ascii?Q?UWzVIhopfIJVHqr2dcduGaKPtcWSeSQLaid6mGx5pLnJQcwqd+tab8qgcDDW?=
 =?us-ascii?Q?aNjs3A6bNYxdzBLgzFRdYxHkL6eeZtuD2z9mmmZC3gPCP7CZINa0pqLiJiNc?=
 =?us-ascii?Q?aBEHNPFxQ8rnkHCLh6YS0OIxryNdn5oV2mOwmgzms3E8bdkctA93mgvIiqDe?=
 =?us-ascii?Q?EyOQtkWV4rOnWEccdXf5zjuNG1uMiABHTqilAGaOHAzsvI7Z8beHYDKpu4ji?=
 =?us-ascii?Q?ZBQOSOZZu7lqX6u9ErLQRRJMkJxF1Njg/iEwoJ+iY0DjZlcjH9PKGp/XX8ka?=
 =?us-ascii?Q?d/YbObCIE7SNX6NC/BS0dKRYxVFiXXu8/ICZXEWW0XkjDPSOF2BYcrzMYxEo?=
 =?us-ascii?Q?S9k+GIeb8gDlux6aZwnyPnD7J4na08s5pdMr7/6k7QeQQJxgjFdfkerwzx28?=
 =?us-ascii?Q?9ddfavQKKmhVFCYJ/pIVcbqAIB+HlZChODF06245WQS+STEduZbPWBB6Fb1a?=
 =?us-ascii?Q?hMpe/etlGVh39VjoLTZ3dF91st0HmxsS3odS14IUTZ6hnPjhh60vZ/7WMbVQ?=
 =?us-ascii?Q?M7u3LhUA3Rm67R7WuRjGF7QH4EhPj1qaebUQCQ5LcbPreGQgJbW1sULx4V2V?=
 =?us-ascii?Q?q3H7FrrLo9Fxkq4gmS499CMstVsVdDYGeQsfplcg0K+FEIOTypMCtvdOt7aj?=
 =?us-ascii?Q?uJYVF0yRoiHgm8zL4X5ysAflOTS0dXcQR8pI+LrqYwGsYbDXLe9hnv5GY0lL?=
 =?us-ascii?Q?MoRVEcXDOoW5w6uwspJ47RdKeZLpA+r5Gzqc8/iz3nAP2NH7udPZbCaojjH2?=
 =?us-ascii?Q?oBeG3w9UrF2ZMcKeNe2V42LUUsEVIa3a8uBydccz0UtYDjw/p/YdPqY+a6Ak?=
 =?us-ascii?Q?Sx9ofimSyFox7dhlwehsTAXlStvrg0jLDK4AN0IIaVo8dt+no2s0uHrX+Dd8?=
 =?us-ascii?Q?h8RbrSNaxTayzQColzIX2pevrBmgQF/xX/3DDcrgSX3PmPM130hvCLivA+s7?=
 =?us-ascii?Q?TMJegYdJzWur7mO56aVM1OiW+nF5bx701NxFdJysqNC9E0xx4lgEwiXt75jE?=
 =?us-ascii?Q?cbWl/TEbhcCk8GXaOtvo8v/Tt/QkQSZTebqSUP7Qj/gbYiPazuvHxiCqC0Yq?=
 =?us-ascii?Q?2pIw8gXdXElpIaiV3OtUkeiMBEjN1TWLRr3aYoBXSZgVqRt8bVlsi492v9iy?=
 =?us-ascii?Q?mR5NrnWLZbALkcUNGn+mYCFuPlu61Yql2Wh2mcCOz7ip0gGYwE1nQ32Sgdih?=
 =?us-ascii?Q?TpXC3qjIdDUeMFfYQ2dLxhb86OQKPzCIHCGoYpsH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5787.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79ecbdd6-aa2f-4c66-5bd7-08dc335f48b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 04:32:31.4183
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +JRuF3rVJvc7xDrYvOgEyf5y10Q7t76haHKeIMavi9VjFmcMe4c7BG0gv5ocSTl8+Fa9Pa0CXMQ9eFcAgCh8tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7365
X-OriginatorOrg: intel.com

> From: Sakari Ailus <sakari.ailus@linux.intel.com>
>=20
> Assign all possible fields of pinfo in variable declaration, instead of j=
ust
> zeroing it there.
>=20
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Tested-and-Reviewed-by: Wentong Wu <wentong.wu@intel.com>

> ---
>  drivers/misc/mei/vsc-tp.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> 7b678005652b..9b4584d67a1b 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -445,11 +445,16 @@ static int vsc_tp_match_any(struct acpi_device
> *adev, void *data)
>=20
>  static int vsc_tp_probe(struct spi_device *spi)  {
> -	struct platform_device_info pinfo =3D { 0 };
> +	struct vsc_tp *tp;
> +	struct platform_device_info pinfo =3D {
> +		.name =3D "intel_vsc",
> +		.data =3D &tp,
> +		.size_data =3D sizeof(tp),
> +		.id =3D PLATFORM_DEVID_NONE,
> +	};
>  	struct device *dev =3D &spi->dev;
>  	struct platform_device *pdev;
>  	struct acpi_device *adev;
> -	struct vsc_tp *tp;
>  	int ret;
>=20
>  	tp =3D devm_kzalloc(dev, sizeof(*tp), GFP_KERNEL); @@ -501,13 +506,8
> @@ static int vsc_tp_probe(struct spi_device *spi)
>  		ret =3D -ENODEV;
>  		goto err_destroy_lock;
>  	}
> -	pinfo.fwnode =3D acpi_fwnode_handle(adev);
> -
> -	pinfo.name =3D "intel_vsc";
> -	pinfo.data =3D &tp;
> -	pinfo.size_data =3D sizeof(tp);
> -	pinfo.id =3D PLATFORM_DEVID_NONE;
>=20
> +	pinfo.fwnode =3D acpi_fwnode_handle(adev);
>  	pdev =3D platform_device_register_full(&pinfo);
>  	if (IS_ERR(pdev)) {
>  		ret =3D PTR_ERR(pdev);
> --
> 2.39.2