Received-SPF: pass (google.com: domain of linux-kernel+bounces-75901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240221174333.700197-1-tj@kernel.org> <20240221174333.700197-3-tj@kernel.org>
In-Reply-To: <20240221174333.700197-3-tj@kernel.org>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Thu, 22 Feb 2024 12:34:52 +0800
Message-ID: <CAJhGHyDJAUt8hSJNf91vosOK5TMRykudUZdiKvYYaU3co3T=6w@mail.gmail.com>
Subject: Re: [PATCH 2/7] workqueue: Implement disable/enable for (delayed)
 work items
To: Tejun Heo <tj@kernel.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, 
	allen.lkml@gmail.com, kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello, Tejun

On Thu, Feb 22, 2024 at 1:43=E2=80=AFAM Tejun Heo <tj@kernel.org> wrote:

> +/**
> + * enable_work - Enable a work item
> + * @work: work item to enable
> + *
> + * Undo disable_work[_sync]() by decrementing @work's disable count. @wo=
rk can
> + * only be queued if its disable count is 0.
> + *
> + * Must be called from a sleepable context. Returns %true if the disable=
 count
> + * reached 0. Otherwise, %false.
> + */
> +bool enable_work(struct work_struct *work)
> +{
> +       struct work_offq_data offqd;
> +       unsigned long irq_flags;
> +
> +       work_grab_pending(work, 0, &irq_flags);
> +
> +       work_offqd_unpack(&offqd, *work_data_bits(work));
> +       work_offqd_enable(&offqd);
> +       set_work_pool_and_clear_pending(work, offqd.pool_id,
> +                                       work_offqd_pack_flags(&offqd));
> +       local_irq_enable();

It can use local_irq_restore() directly or the next patch needs to be fixed=
.

The next patch making enable_work() able to be called in any context
forgets to change local_irq_enable() to local_irq_restore().

Thanks.
Lai