Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp125731rdb; Wed, 21 Feb 2024 20:35:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW5V26+fHCzRibUOOklsl++eHqseJ3vhoEmFXCHAosvlnQa3oiJ45z2KSBaWUGjn/adeabgiqj4Ta4oDKQ8e1C+gBM4zOrSqLpbR0b8NQ== X-Google-Smtp-Source: AGHT+IFipRM6MypyVqH/DJoS4vQ9kCd+IaEF7Fs1h/in0qMK4tWcJDJwxg7lta4fp5fpKugUV3hW X-Received: by 2002:a17:907:1182:b0:a3f:29c:c8fa with SMTP id uz2-20020a170907118200b00a3f029cc8famr4670820ejb.66.1708576555629; Wed, 21 Feb 2024 20:35:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708576555; cv=pass; d=google.com; s=arc-20160816; b=eTI05WDgxVCL9vbMBy51KCj5QFCxa/15GIXICnz1jTKTPvGMCpOMNKvbaOIA853X74 HRcFguk29UX8yFxX5vKZ4NK3v185O1eYk80FSdh9uuTU+pyp5M1oEJSWv5+2WILxGYDY XzVXZi2Z70QW6bApkCbqOwgEGOs4Bsm9bFuSD/kinA9kwB3pifSEVGLnSTd9ua/SYP58 AUvbLRsborOLy5oMWihnbq1dzqoZnrtl91LM6TqSZLYsCUrdv29v1K4jpOcybfa9duXW XgZoOLsMdS6TVGJ9GNq3hL45K+gE9poE+ahue4t0tjEb+XRrPP0eggUv2sltBQlZM+PG MKlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Dd5caO8ozl7kT0iui9IzlMI2kddZaEY7frmQ6rB1CWk=; fh=4+9DsDdExAQzO1ljVhVdzoX/fjL+DPqD3JnZqNy8Gxk=; b=QPGzeP2WDKeAyAc6gG9m4Ns/llZd+/CcpAHW/xAdV50hgJKCpMBPXxMQuM62eV5Do0 5zCp+VqFLMn0Pyr9rF+YYx+iSzDmC+iieGpWSn3aynTG72lI8mGc9kKa1KKhQrA0DqHv xShopshhSpqjsIsEx9ilB5sUr0ABepMsOUHV1lRl1d/5AUryvYuLY143No51h4uouCII w6GZMWZQgH24qbiXF4vd6gI1YlTHth6zDY+/K4YPDoxM23kX3HypMOfKQ2i8qdedtqqa qRrpBGptvdkcn1k9Ln625P9snc4xrF/lI4olTMuqEEhx85BVtNm7RGCF0JaqP4ShUdQ/ q/6w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gq2V4Vqm; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-75902-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75902-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id bw25-20020a170906c1d900b00a3d12d84d00si4809503ejb.22.2024.02.21.20.35.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 20:35:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75902-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gq2V4Vqm; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-75902-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75902-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3D7FF1F23819 for ; Thu, 22 Feb 2024 04:35:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89B097490; Thu, 22 Feb 2024 04:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gq2V4Vqm" Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F1BE4C7E for ; Thu, 22 Feb 2024 04:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708576548; cv=none; b=oJTQqZe6p27MHgzen4piFjUoINi+EOwzqmze63FpQt+B2RiNbTN1TevIMEHXHWke9TAJXDrWMsPjIhEB5giV8yD8+b9j0eIutSQjRacXA/aarfaHJvlryzhtiR3Jj8wybzrQEjDDE4hWJGkvkPmkPF5JQFy8PlO4iswn+NR5NRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708576548; c=relaxed/simple; bh=R+LaV9IObqXEDslRt6huejtrzOUwqWZwLScJ3hFhjoo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=vBG4pkkFRF1nXlbknuaxxTmwlcM5Zmq4z0I/jeIPfczclL3f4wQo36csHW4wal6Cu3YXBxVF/L2rGgNPYoeH/pDK0z+ScruyJkUba/1EMgy3mHsz+PU4+oHTwgo221b1ap8p4v6SUtpeIJt2p8oIGf3aaPgtnsM7iJA6Tg2KO4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gq2V4Vqm; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5a0073ae310so1121628eaf.0 for ; Wed, 21 Feb 2024 20:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708576544; x=1709181344; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Dd5caO8ozl7kT0iui9IzlMI2kddZaEY7frmQ6rB1CWk=; b=gq2V4VqmZZCL3XUy1CYzfRluSbXeUOXkDVfuCU0rud8fRK+BS6sftmdo13cD00gprw +5g9Q9BWW6RL02vEWSHzShmE4WKdeOro593dU9nOS5y1jtganxI9M/XttZvr2ehg5Rl1 jmHXAjdW5iAmUhtQW4L9gHEOhrYSqYDR59JIgR5r8RJ0nhFwjPSPDkP6PoxPZeSi5m5w k6hExnIsJDmzbn60uLFgmXNQ9tFuNknLsAGeuPMG6wu3im2HIWB4TZVU5FG8ycZUbP1H 78FaRK3pcsMtwqOmYR/p1k7uXfCU2O7xs5Q10eH9hOsmgKwrymUaaySdNzRn9ob7QVcA 9qMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708576544; x=1709181344; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dd5caO8ozl7kT0iui9IzlMI2kddZaEY7frmQ6rB1CWk=; b=lInefsTaid/P06UGgr70AnVixq4tZH2nvb5o/+8g7C+ZGNU0dSGPYbDTW5tT5TrgCN m0xHL5JNsie9hC+zKKbTpB52cmpl9A+gA2eSeBuCadvy8Jowaw82gv6FsvqDZqK8aylw YugMZlyoinqHQuzbf/nKZQgjO/eWNQv/HgdqZZ2jTr9ql6ifZ9ViW7yf3AD4XkiUD3FT A7uIqnPudhbB7CZX3u8xl7aD5nWuh7T7U39nem5IY27Jzd1TBrEAGwV33OTsMLi7nXV2 ew8yKps2WncRYnC5PFpT4k9CpZtPAs0tlcU2dIJetWVKFt8suOx0RxzCvmkYLCWRqey8 t0qg== X-Forwarded-Encrypted: i=1; AJvYcCXMK9oedffXWvhWbZ+A78Q4mWqNkGG2n1NGwQU4LEvEEm/pA6SR/G0+P7aK8/4AN1hZxTp2xy8lzxN+uTfVR+INT4vGSSpaNVwPa31h X-Gm-Message-State: AOJu0Yw6SB9ZGour69KC6DJ1IJ5e6hlJEACXw+fCaxx2/if9k1D5Sq70 J30jZslAiajdhucI2hr1NYhoWMuLk3JmUhuwOqSdFWUie6BHSGb7PtED2lh/hMbP7Z0pnnSOs8L zWfyiYcD5ZcAPZlFzPLXOUXavpbg= X-Received: by 2002:a05:6358:18c:b0:17a:ec74:b574 with SMTP id d12-20020a056358018c00b0017aec74b574mr29323834rwa.10.1708576542881; Wed, 21 Feb 2024 20:35:42 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221174333.700197-1-tj@kernel.org> <20240221174333.700197-2-tj@kernel.org> In-Reply-To: <20240221174333.700197-2-tj@kernel.org> From: Lai Jiangshan Date: Thu, 22 Feb 2024 12:35:31 +0800 Message-ID: Subject: Re: [PATCH 1/7] workqueue: Preserve OFFQ bits in cancel[_sync] paths To: Tejun Heo Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, allen.lkml@gmail.com, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, On Thu, Feb 22, 2024 at 1:43=E2=80=AFAM Tejun Heo wrote: > > /* Convenience constants - of type 'unsigned long', not 'enum'! */ > #define WORK_OFFQ_CANCELING (1ul << WORK_OFFQ_CANCELING_BIT) > +#define WORK_OFFQ_FLAG_MASK (((1ul << WORK_OFFQ_FLAG_BITS) - 1) << WO= RK_OFFQ_FLAG_SHIFT) It can use GENMASK. Thanks Lai > #define WORK_OFFQ_POOL_NONE ((1ul << WORK_OFFQ_POOL_BITS) - 1) > #define WORK_STRUCT_NO_POOL (WORK_OFFQ_POOL_NONE << WORK_OFFQ_POOL_SH= IFT) > #define WORK_STRUCT_PWQ_MASK (~((1ul << WORK_STRUCT_PWQ_SHIFT) - 1))