Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp130394rdb; Wed, 21 Feb 2024 20:51:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWd9MRJydzIj+2ayKhwqjiN0HzKCcHMVo6acGHGi7uYMx+SafwlSiCtVQ1uwIw/wU4cv9uNgtmMlYVcJSPMdiiJYzEA3Y1OYTdOpH1hSw== X-Google-Smtp-Source: AGHT+IESKj8v932c14s4KEKrnvFUEHS4aFiA7LXjFO966dvYrP84nq2cYyAfmfd4QyKAVdjgabJC X-Received: by 2002:a67:efd3:0:b0:470:5373:2389 with SMTP id s19-20020a67efd3000000b0047053732389mr3168157vsp.0.1708577515782; Wed, 21 Feb 2024 20:51:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708577515; cv=pass; d=google.com; s=arc-20160816; b=MafkcbQUDJbDasBO4s1me1dM/ya0FhFp75HtG2DPINvsmCaWnMXcDrZc3jjIJkwOav 11fGr8W5s9x/YwOSy0vKZ/T5bPmfPDjGIvTMkDcyfq9ftc7F6se74UkLVlot8AvYEC85 wxDQ3B5jqCuvncOvC3HL+5IsArClcGSOuolak0HBNk3ep2ifnb2C8mUkvY6SzPfUQ8sQ z/2s9NBAyeCDRKxb1Q2YStOS2S5QiZLSXEXDfD1dpnk5lSqoXz1qgk2fZx1CD7nN0TLx rTgfqaFiCjntCw/wp5zcH3+B7Yio4JrxmytiYtQ9ZvXvYIN0YhnIzhHYj8swo/BiuWHP 6leQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=Kqm4qtGh5X7VQ2ZIzlQV4yJvQ+ZhC2H7zx2PY73LdsA=; fh=9K08OzccwJTtv3IAdgzpyim1GkqrRcpRFEOwVWBwqjA=; b=hZdjDIqWHz5kOM1zRj4jSTr/gw5C0fvYvKNi+M690+r0yyKO90TCF6k/bDwxG8sgz9 Tg+L5mN78gSWZ+waFZX3c7nDGyjKmqmwcUPe9QoDpuJRAGuhzD6P677dEp2L6yKdlQ8v d/BlaXKs0wQIoKW1xrAMLthjhMsjlzmZIrWqOgLnxRi73baofJT+bqkwXpM+tqqDXPRI OCCn6dK3nY0XtpSCHaL+BCxxDJp0dlPUpocNdGj8QxXtMTFQVjqz/M8IacCItf2a+r3J rMoSCH8wqSp/keTQs/rLoxm08/2rcwNaWcnNf1Hb7eD8uvEn5HyRmaNDl51UyQ6gDX0W Hq6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YcQqu2kN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id r8-20020a056214212800b0068f45b756f5si11996685qvc.69.2024.02.21.20.51.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 20:51:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YcQqu2kN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 52D1D1C211A4 for ; Thu, 22 Feb 2024 04:51:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DABE1522F; Thu, 22 Feb 2024 04:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YcQqu2kN" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088AB1388; Thu, 22 Feb 2024 04:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708577507; cv=none; b=AR3HG8DHWEBOWrLL7ht9UjB3yU10/36C3ACX8n9NChwVTAEzRTV+Cr3HuPdk8YaejwiXf06xppiCKm6O5GsgA5b71qnvJyHVok+L30W4WpFQgIY1Q7yEg9RbbtpzAEe/x3zsrQbS8gKbhDk4DqTfHYCl8y0CNRauNb2zjegKyv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708577507; c=relaxed/simple; bh=Kqm4qtGh5X7VQ2ZIzlQV4yJvQ+ZhC2H7zx2PY73LdsA=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=ptSepewFnPK3XZ/pOBhv4+/EGxMwmFnzc7J5gFcxZu6mkxV3VYNjypXCv2lnx0/osHq/7d2IASGFF1pniuxo0pHMD/kDW/rIAMYsMzxAB5Dc5ffxONyC7vsKTj+HfgFoonPJCL0SaSpUyW+JafDwvUT0dtBl6SVbOUrIeTmLl5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YcQqu2kN; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89818C433C7; Thu, 22 Feb 2024 04:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708577506; bh=Kqm4qtGh5X7VQ2ZIzlQV4yJvQ+ZhC2H7zx2PY73LdsA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=YcQqu2kNN29T3Z51lNh60xwqsX+awcPkZ/MZumOPOcqIigGS17IrY2Ti7kaSaG2Uk dkiSUP0r6hgqIEIE5tVlNPnxEwVQw9sLskiVekU+ERNuN6SomAfEunI9MSGpH8bXrT /CWtzElONcF7v+TunxLiH3nNyQdLwVieANCz8oY+anTozViOtQl/G7R+ax3h5Ec6XH OlivNVgikog5occyxMUlgBhaYf4GBQi66KEAqMiw+0jHAaqTzUWpvJBSLgS6FNHAiI KxOTAidH3G833mzG5HEVXCyPHyNPFSFx8DwtFN44rjc3d3BBtEojH9e5iZeJ/xiJqj F02ZZJsDMKdGQ== Message-ID: <17ab00b5cbf2b9aefa7ee99daf305f46.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <6cd6af61e5a91598068227f1f68cfcfde1507453.1704615011.git.christophe.jaillet@wanadoo.fr> References: <6cd6af61e5a91598068227f1f68cfcfde1507453.1704615011.git.christophe.jaillet@wanadoo.fr> Subject: Re: [PATCH] clk: mediatek: mt8135: Fix an error handling path in clk_mt8135_apmixed_probe() From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org To: AngeloGioacchino Del Regno , Chen-Yu Tsai , Christophe JAILLET , Matthias Brugger , Michael Turquette Date: Wed, 21 Feb 2024 20:51:44 -0800 User-Agent: alot/0.10 Quoting Christophe JAILLET (2024-01-07 00:12:17) > If an error occurs after mtk_alloc_clk_data(), mtk_free_clk_data() should > be called, as already done in the remove function. >=20 > Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platfo= rm_driver and module") > Signed-off-by: Christophe JAILLET > --- Applied to clk-next