Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp131495rdb; Wed, 21 Feb 2024 20:56:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWeHmvY89cyTkUnYlVE1cf2JLhxUV8r3tUxgx7fC5rBDGMfgMu2XDQhT5/6E9x0BnYeXUzL4/6sGtmOouN9XlIR1rQ/jZ6F0Hz4cI+zNg== X-Google-Smtp-Source: AGHT+IEhVP5R0H9W7wTpuFSnv9oxcm0yL7FISPPYqG9heHLr7AIrdXSOyy2Qq3GapA+JfYBc6g3i X-Received: by 2002:aa7:888d:0:b0:6de:1b57:ca8c with SMTP id z13-20020aa7888d000000b006de1b57ca8cmr24816020pfe.23.1708577764423; Wed, 21 Feb 2024 20:56:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708577764; cv=pass; d=google.com; s=arc-20160816; b=Bz854ixLM7umLlULO91+5IJKzCIHj0I3JwLP+kawzr30RtoH/S/RTXCkdkfGJiN/Zq 8BuPXeJ622aPb1fLA7Zxtpqcl2xzYuR11Zn2gBEa6VT2wlfWr4GooJ8pGgEywe1qp48P 91W7QCObLEqkzKnows0qMdz8g9YQz9NwDip6uMD1SViu3Ct/lbvae/GbblnVXnFhl8yU FivbZ7TuUlCwTr19RoHE5i8udlP5F5YXhjOBoZwLtGAsU/W3rgnQpd9htibEOZ/j+/mn 6HOOQUlJtzl1RagNpgSAk+bWUzTYBcvmgRHBPQ+q10pkiNeU4PcxCGg5LKBdPMOlUc80 H79A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=h1t4l94yELDYZR6iDnJqPGq5TXMg7b84277zgKd4BYY=; fh=gUwvYML6rLpwWYw24r2TdQJ9xhu8HVA3Ml7n7mYrt6s=; b=axcglVz3oymtYmkunfWBKC/b/77BFfVCwH38Rb27echKL1AkA03v1X5vuk00qHBL6W UsaWLk2IMyG5ZTiH83BlRhpR/Nee3nx10V1GXv69e2oSJJeRIjDavfCrOiRB475zi61U kUVNC/OTiihe5zJdE8eJBfrR/TfLKjOiyhIiYtPEI0Kw0AlOO6vp+xzu8amxAQp3zDNq Na+hyd+50WC4tf0e0WJ4Ss3spBbcFFY9Sj1epXL2/1vlbBA17lN7935LACOnr+vdcjf3 bZoXQIW5vo2Jr3Tjptz0sdN6oMzx7POpS+jYIc/lG1uJtYX+2rnYEHFRFNhxVMssg9ZL sBug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CEeoHAkj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75912-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75912-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y20-20020a056a001c9400b006e4c395c9d2si1366021pfw.77.2024.02.21.20.56.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 20:56:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75912-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CEeoHAkj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75912-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75912-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9EDF0284C45 for ; Thu, 22 Feb 2024 04:56:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C7F44C8A; Thu, 22 Feb 2024 04:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CEeoHAkj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53EB1877; Thu, 22 Feb 2024 04:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708577758; cv=none; b=n9s1bze6pKH5bqvxmtJlIp5wHQyw/MHfOiu6ChjiUci7sTxKO54uON3o90n/gCNpM1xrL8kLUc9iZzLWiGtbw74MpOp4+nNcgM+aROnjWblHr+WZwPsb4wPZtVWE8cSmOTpYerT9qHavU3JcOVl8r6Qnrvt/5cm31M6WurPDJDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708577758; c=relaxed/simple; bh=h1t4l94yELDYZR6iDnJqPGq5TXMg7b84277zgKd4BYY=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=Z62G/hhn9aIt8l9Z7ZKagP4orRsAlya6ATpEzQnH6YiHImQLm9GN61+gT8SYW+eXrkLb0D2ZXk9giqvjRBItkOQUIZZ90iNRs5GrpEYBj8UbbOUcSuUZvemON5e7rIf8EHvcDjrRFO9h/FsFTRQdAJLAp6uXA89rY/LWrL74lRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CEeoHAkj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E99FC43390; Thu, 22 Feb 2024 04:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708577758; bh=h1t4l94yELDYZR6iDnJqPGq5TXMg7b84277zgKd4BYY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CEeoHAkjGC3ivSS8PwlK54FmSb1FUb2WpLTX41AbIgtFsP5HBKEyqCeRjjfVvHE13 gFbNCUczcDeVPHpc9JVHMS6AvgjLYQVjJT8je61Zqg6MPrHNmv3Ol+l4jPeyusZ3ox rWv2h0JkCmMSfff1TWv78hSXV48wjXHPyaeM1WEwFPo92v/tMl+O88GJNT8iqL1gzI /yf/3b+Qm0mqrXlfjtEbtxRjb4dRM/oj6lLGRQjgAd+J4CsrNP3H9DPl0LKtbBWLF4 Mn0qjRD4tYKDh2ojHeoXBweJme4/F1YRmndWYFTTRITqMW96Y/PkRB0+7L+vHoel+7 u/ovmx4j634SA== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: Subject: Re: [PATCH] clk: mediatek: mt7981-topckgen: flag SGM_REG_SEL as critical From: Stephen Boyd Cc: John Crispin , Steven Liu To: AngeloGioacchino Del Regno , Chen-Yu Tsai , Daniel Golle , Jianhui Zhao , Krzysztof Kozlowski , Matthias Brugger , Michael Turquette , Rob Herring , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Wed, 21 Feb 2024 20:55:55 -0800 User-Agent: alot/0.10 Quoting Daniel Golle (2024-02-17 19:11:15) > Without the SGM_REG_SEL clock enabled the cpu freezes if trying to > access registers used by MT7981 clock drivers itself. > Mark SGM_REG_SEL as critical to make sure it is always enabled to > prevent freezes on boot even if the Ethernet driver which prepares > and enables the clock is not loaded or probed at a later point. >=20 > Fixes: 813c3b53b55b ("clk: mediatek: add MT7981 clock support") > Signed-off-by: Daniel Golle > --- Applied to clk-next