Received-SPF: pass (google.com: domain of linux-kernel+bounces-75921-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 21 Feb 2024 23:05:05 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: David Gow <davidgow@google.com>
CC: Linus Torvalds <torvalds@linux-foundation.org>, Shuah Khan
	<skhan@linuxfoundation.org>, Guenter Roeck <linux@roeck-us.net>, Rae Moar
	<rmoar@google.com>, Matthew Auld <matthew.auld@intel.com>, "Arunpravin Paneer
 Selvam" <arunpravin.paneerselvam@amd.com>, Christian =?utf-8?B?S8O2bmln?=
	<christian.koenig@amd.com>, Kees Cook <keescook@chromium.org>,
	=?utf-8?B?TWHDrXJh?= Canal <mcanal@igalia.com>, Rodrigo Vivi
	<rodrigo.vivi@intel.com>, Matthew Brost <matthew.brost@intel.com>, "Willem de
 Bruijn" <willemb@google.com>, Florian Westphal <fw@strlen.de>, Cassio Neri
	<cassio.neri@gmail.com>, Javier Martinez Canillas <javierm@redhat.com>,
	Arthur Grillo <arthur.grillo@usp.br>, Brendan Higgins
	<brendan.higgins@linux.dev>, Daniel Latypov <dlatypov@google.com>, "Stephen
 Boyd" <sboyd@kernel.org>, David Airlie <airlied@gmail.com>, Maxime Ripard
	<mripard@kernel.org>, "David S . Miller" <davem@davemloft.net>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>, <linux-rtc@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
	<linux-hardening@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 8/9] drm/xe/tests: Fix printf format specifiers in
 xe_migrate test
Message-ID: <anz6qjyb2oqkz6wdy4ehnlpoujy4rz2itohpglgfqzadtonxtj@ljakgnqmfxxh>
References: <20240221092728.1281499-1-davidgow@google.com>
 <20240221092728.1281499-9-davidgow@google.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <20240221092728.1281499-9-davidgow@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SfbAQ0gMQxEEfDI9iZ+EAxYYWX/0NDm27nDBi9yi4lPaY9JbKi5LFlWPOKQA?=
 =?us-ascii?Q?UBcRI4n04FJJlG6qm4uYm4pxi5cKc1RDDbgSELNpmhsKrJ3SCTRmZj/nleGf?=
 =?us-ascii?Q?EZr8Yc4E1svg3x8eyB2saI6Y6IIL4shhBMRYly3zGNpS1Gar+n2d4D3XBgeg?=
 =?us-ascii?Q?SvD7mQq6RligappaPpuFruW2ooPDZ9vf6VcDB6xvOlUyi/1Q7klKU5Z7I0uo?=
 =?us-ascii?Q?FcYXB2DGAi9GZyPxe0khUR/JJX43MoiHJoy31dnGtEXy+uKIGWynuozlLvBo?=
 =?us-ascii?Q?qL8Mw/QrSUq8DT7VczQluCUu1qnfP9lYOrOpyQP8PjgX2avZrLTRjWmZf+tZ?=
 =?us-ascii?Q?koUANh/Z2RW/YV4Z4skwtIY06YmD5ZxDidNKcBHFrHlYr4Hjoyi2RDax6sZo?=
 =?us-ascii?Q?DFr+Zkhpq0LckVMQ/gtMM4kh53C62Mq5xy1Yu8cu9WPGuCujUOSIkC3/oNsK?=
 =?us-ascii?Q?3DVCGuMelYdBuYHSmH6PdrXxUbf2PY9Qtht4Dwnig7ZWdCQ5HV2Zqnv7K5CN?=
 =?us-ascii?Q?lFlOvAJWm8SHP5FlNFdaFgx5LsAR2/hdI5yvvYgnVD3IH3ACNV8+GcrDzoLd?=
 =?us-ascii?Q?VzJJqA/DUipGyb36wef2+BK9nhciVgVTHYE50sLL9qRZDXRmtd1hM/ibBjUe?=
 =?us-ascii?Q?s/4/GgN+GeVT8a5zSb/QUcugO9i/J6NaXk0hRW+Xkq9uCuJY3gbX/k8++TQF?=
 =?us-ascii?Q?33yabsrplHZHEBbtFeoPSe6cCOZIWCA+ZCe1fE9KIe22PdYsbqIvgzRbT5s4?=
 =?us-ascii?Q?piuLbsrWcJdId9MaCckS4o4hv4EbQsh7DTdo/sMtSFNk5577G0rud4J8ugzZ?=
 =?us-ascii?Q?rWUTJcw7jBa/GNx0Tjm8pwnDhGqPzF4OBAwMKdAu1TgtqHUW6jVxDNn79wGl?=
 =?us-ascii?Q?jAOukAzOh0RQCopBlievon7iJf6gXKNzgSX5ITljV1U2wQZ6A91tLLGsb7hL?=
 =?us-ascii?Q?FtzMh0spAE1EawguD8s7eyZmaYrCPWN3M5l/019qRzpKAiLlDrHcjIa3lgWo?=
 =?us-ascii?Q?yGN5uTMKW+wCrgi8hLIVNq240oSX2tUc+IFlV0K7NH2gCCrvNsOPspGWOWgk?=
 =?us-ascii?Q?VogF57olEeXSfj+95zF9tRVZzrRMeYHPxGSu5aUcdqm8rsMj4mH6dvGX5sDH?=
 =?us-ascii?Q?BfqHAfH3RmtxT/1Tcm2XSKJU5KTj/D/Y2QKE8ft3FbxY6w4a5hfGcUEifpNd?=
 =?us-ascii?Q?d43ZfliwqepXFAYWiNsbQSuouAuIXy7e6WD3HcnSDfzpCTdI30Qa90qkFlyz?=
 =?us-ascii?Q?cq/mtbNNzFzflCjZ+tcH48CAYVHAe1XFjz6TvuWl9DImjc4FDmzxxdvITC9G?=
 =?us-ascii?Q?I+/CqVq6zOxfaQYCrvn5dJ0JG7f+CUFWXsqCtZJOMD22CjX4XTrfoEY0alJr?=
 =?us-ascii?Q?HajnPwpj36uSAFZxd8RmzdsFJJm7h83RwdQXH8YlOx6hYPeM9IrECUQydjjj?=
 =?us-ascii?Q?JRIYiGMgWCDeV8UrTHs5TQ/cTpEYPHP6KiMKy34roTOSV4ow43tRrdq9DRC8?=
 =?us-ascii?Q?HbA/xqmEiX6LaNOsz17USkhxHESGy2D4Jbd0ojdD8ybXNZEvHA5cra8Vq3C7?=
 =?us-ascii?Q?Dx0vD/+dV8UFq3Fh8b6VeewAhzOpXgpupV3gJdnvTk8YNpmdGNSFdmuQnihy?=
 =?us-ascii?Q?xA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fab4a941-b3ab-473e-537c-08dc3363dd04
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 05:05:18.4554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C12XjWMX5obVKQmI6T3a62ZR2WWHq0x5T39fYc0e2lRUCigEunA1C6uYcRwqDSmprnyixFBvIF3/8Dh+Zn+J6Pc62FCCkx6oZXCRevyhMCE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5419
X-OriginatorOrg: intel.com

On Wed, Feb 21, 2024 at 05:27:21PM +0800, David Gow wrote:
>KUNIT_FAIL() is used to fail the xe_migrate test when an error occurs.
>However, there's a mismatch in the format specifier: '%li' is used to
>log 'err', which is an 'int'.
>
>Use '%i' instead of '%li', and for the case where we're printing an
>error pointer, just use '%pe', instead of extracting the error code
>manually with PTR_ERR(). (This also results in a nicer output when the
>error code is known.)
>
>Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>Signed-off-by: David Gow <davidgow@google.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

this has a potential to cause conflicts with upcoming work, so I think
it's better to apply this through drm-xe-next. Let me know if you agree.

thanks
Lucas De Marchi

>---
> drivers/gpu/drm/xe/tests/xe_migrate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
>index a6523df0f1d3..c347e2c29f81 100644
>--- a/drivers/gpu/drm/xe/tests/xe_migrate.c
>+++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
>@@ -114,21 +114,21 @@ static void test_copy(struct xe_migrate *m, struct xe_bo *bo,
> 						   region |
> 						   XE_BO_NEEDS_CPU_ACCESS);
> 	if (IS_ERR(remote)) {
>-		KUNIT_FAIL(test, "Failed to allocate remote bo for %s: %li\n",
>-			   str, PTR_ERR(remote));
>+		KUNIT_FAIL(test, "Failed to allocate remote bo for %s: %pe\n",
>+			   str, remote);
> 		return;
> 	}
>
> 	err = xe_bo_validate(remote, NULL, false);
> 	if (err) {
>-		KUNIT_FAIL(test, "Failed to validate system bo for %s: %li\n",
>+		KUNIT_FAIL(test, "Failed to validate system bo for %s: %i\n",
> 			   str, err);
> 		goto out_unlock;
> 	}
>
> 	err = xe_bo_vmap(remote);
> 	if (err) {
>-		KUNIT_FAIL(test, "Failed to vmap system bo for %s: %li\n",
>+		KUNIT_FAIL(test, "Failed to vmap system bo for %s: %i\n",
> 			   str, err);
> 		goto out_unlock;
> 	}
>-- 
>2.44.0.rc0.258.g7320e95886-goog
>