Received-SPF: pass (google.com: domain of linux-kernel+bounces-75950-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <500e265eb7c6a03a40e0067c8806e059.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240214183006.3403207-7-cristian.marussi@arm.com>
References: <20240214183006.3403207-1-cristian.marussi@arm.com> <20240214183006.3403207-7-cristian.marussi@arm.com>
Subject: Re: [PATCH 6/7] clk: scmi: Allocate CLK operations dynamically
From: Stephen Boyd <sboyd@kernel.org>
Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, souvik.chakravarty@arm.com, Cristian Marussi <cristian.marussi@arm.com>, Michael Turquette <mturquette@baylibre.com>, linux-clk@vger.kernel.org
To: Cristian Marussi <cristian.marussi@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date: Wed, 21 Feb 2024 21:44:14 -0800
User-Agent: alot/0.10

Quoting Cristian Marussi (2024-02-14 10:30:05)
> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
> index 5747b6d651f0..b91a0dbd2fe0 100644
> --- a/drivers/clk/clk-scmi.c
> +++ b/drivers/clk/clk-scmi.c
> @@ -158,51 +158,6 @@ static int scmi_clk_atomic_is_enabled(struct clk_hw =
*hw)
>         return !!enabled;
>  }
> =20
> -/*
> - * We can provide enable/disable/is_enabled atomic callbacks only if the
> - * underlying SCMI transport for an SCMI instance is configured to handle
> - * SCMI commands in an atomic manner.
> - *
> - * When no SCMI atomic transport support is available we instead provide=
 only
> - * the prepare/unprepare API, as allowed by the clock framework when ato=
mic
> - * calls are not available.
> - *
> - * Two distinct sets of clk_ops are provided since we could have multipl=
e SCMI
> - * instances with different underlying transport quality, so they cannot=
 be
> - * shared.
> - */
> -static const struct clk_ops scmi_clk_ops =3D {
> -       .recalc_rate =3D scmi_clk_recalc_rate,
> -       .round_rate =3D scmi_clk_round_rate,
> -       .set_rate =3D scmi_clk_set_rate,
> -       .prepare =3D scmi_clk_enable,
> -       .unprepare =3D scmi_clk_disable,
> -       .set_parent =3D scmi_clk_set_parent,
> -       .get_parent =3D scmi_clk_get_parent,
> -       .determine_rate =3D scmi_clk_determine_rate,
> -};
> -
> -static const struct clk_ops scmi_atomic_clk_ops =3D {

It's not great to move these function pointer structs out of RO memory
to RW. I'm also not convinced that it's any better to construct them at
runtime. Isn't there a constant set of possible clk configurations? Or
why can't we simply add some failures to the clk_ops functions instead?

> -       .recalc_rate =3D scmi_clk_recalc_rate,
> -       .round_rate =3D scmi_clk_round_rate,
> -       .set_rate =3D scmi_clk_set_rate,
> -       .enable =3D scmi_clk_atomic_enable,
> -       .disable =3D scmi_clk_atomic_disable,
> -       .is_enabled =3D scmi_clk_atomic_is_enabled,