Received-SPF: pass (google.com: domain of linux-kernel+bounces-75960-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Chanwoo Choi" <cw00.choi@samsung.com>
To: "'Randy Dunlap'" <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: "'Arnd Bergmann'" <arnd@arndb.de>, "'MyungJoo Ham'"
	<myungjoo.ham@samsung.com>, "'Marc Zyngier'" <maz@kernel.org>, "'Philipp
 Zabel'" <p.zabel@pengutronix.de>, "'Peter Rosin'" <peda@axentia.se>, "'Greg
 Kroah-Hartman'" <gregkh@linuxfoundation.org>
In-Reply-To: <20240213060028.9744-1-rdunlap@infradead.org>
Subject: RE: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of
 depending on it
Date: Thu, 22 Feb 2024 14:56:00 +0900
Message-ID: <001101da6553$cfee68d0$6fcb3a70$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Language: ko
Thread-Index: AQKmphEMssREiDbY/hBxrofQO+dJJQMCCGwir2VLJ9A=
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20240213060611epcas1p47134bfa5d8781c5cc1a493757a118752@epcas1p4.samsung.com>
	<20240213060028.9744-1-rdunlap@infradead.org>


> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Tuesday, February 13, 2024 3:00 PM
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Arnd Bergmann <arnd@arndb.de>;
> MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
<cw00.choi@samsung.com>;
> Marc Zyngier <maz@kernel.org>; Philipp Zabel <p.zabel@pengutronix.de>;
Peter
> Rosin <peda@axentia.se>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Subject: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of
depending
> on it
> 
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
> Relying on it being set for a dependency is risky.
> 
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
> 
> Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to
> "select".
> 
> Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2: drop Cc: Donggeun Kim <dg77.kim@samsung.com> (bounced)
> 
>  drivers/extcon/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -116,7 +116,8 @@ config EXTCON_MAX77843
> 
>  config EXTCON_MAX8997
>  	tristate "Maxim MAX8997 EXTCON Support"
> -	depends on MFD_MAX8997 && IRQ_DOMAIN
> +	depends on MFD_MAX8997
> +	select IRQ_DOMAIN
>  	help
>  	  If you say yes here you get support for the MUIC device of
>  	  Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory

Applied it. Thanks.

Best Regards,
Chanwoo Choi