Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758518AbXL3XYR (ORCPT ); Sun, 30 Dec 2007 18:24:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755082AbXL3XYF (ORCPT ); Sun, 30 Dec 2007 18:24:05 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:53998 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755066AbXL3XYE (ORCPT ); Sun, 30 Dec 2007 18:24:04 -0500 Date: Mon, 31 Dec 2007 01:23:54 +0200 From: Adrian Bunk To: Yinghai Lu Cc: Ingo Molnar , Thomas Gleixner , Andi Kleen , Andrew Morton , LKML Subject: Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2 Message-ID: <20071230232354.GA3083@does.not.exist> References: <200712291952.20455.yinghai.lu@sun.com> <20071230145115.GR16946@elte.hu> <86802c440712301248m38cd000ejf7e48f273d573edd@mail.gmail.com> <20071230220620.GC17670@does.not.exist> <86802c440712301442q476979f0hef047a45e5444c84@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <86802c440712301442q476979f0hef047a45e5444c84@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2219 Lines: 58 On Sun, Dec 30, 2007 at 02:42:41PM -0800, Yinghai Lu wrote: > On Dec 30, 2007 2:06 PM, Adrian Bunk wrote: > > On Sun, Dec 30, 2007 at 12:48:48PM -0800, Yinghai Lu wrote: > > > On Dec 30, 2007 6:51 AM, Ingo Molnar wrote: > > > > > > > > * Yinghai Lu wrote: > > > > > > > > > please check if you can replace the one in the x86-mm > > > > > > > > > > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76 > > > > > > > > > > the updated one avoid one link warning. > > > > > > > > please send delta patches instead - so that we can review the changes. > > > > > > will do that in another patch. > > > > > > > > > > > > this is the updated verison that take enable_IO_APIC as extra call for > > > > > setup_local_APIC to avoid linking warning. > > > > > > > > hm, what link warning did you get? Perhaps the following __cpuinit: > > > > > > WARNING: vmlinux.o(.text+0x163d5): Section mismatch: reference to > > > .init.text:enable_IO_APIC (between 'setup_local_APIC' and > > > 'apic_is_clustered_box') > > > > So you are doing complicated things for silencing the warning (there is > > an easier ways for achieving it), but the real bug that you will get an > > Oops when calling enable_IO_APIC() after bootup since it already got > > freed stays? > > the enable_IO_APIC is actually doing clear_IO_APIC. and it is only > called by BSP via setup_local_APIC > and it is not called again after bootup OK, this was a bit hidden inside your pointer games. Please send a patch that ignores the warning (and therefore doesn't do these pointer games), and I'll fix the warning in a followup patch. > YH cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/