Received-SPF: pass (google.com: domain of linux-kernel+bounces-76005-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 20.93.157.195 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.93.157.195; helo=westeu11-emailsignatures-cloud.codetwo.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <e315c126-619c-48a1-a5d8-001e5ed01930@topic.nl>
Date: Thu, 22 Feb 2024 08:10:25 +0100
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH 1/2] iio: adc: ti-ads1298: Fix error code in probe()
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen
 <lars@metafoo.de>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
References: <5f393a87-ca8b-4e68-a6f4-a79f75a91ccb@moroto.mountain>
Content-Language: en-US, nl
Organization: Topic
In-Reply-To: <5f393a87-ca8b-4e68-a6f4-a79f75a91ccb@moroto.mountain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 orI2Dh0n4q2VGdtEeX8ARYiPS+OjRd+hUqWbodbRjONVYsgs20K1FppZUtC9F6g3Sma4X7Cf1Mvs/28Os/NzHHAQWWngHM0R5BuzFU1gpzr3T91AE/8LbaTgG/NY8jqusmafVXDipZXi8BuXlKmiKwSCturY9iR+wBTwIV4jjrk9EqGqg6HobJ1X2sFKMRci1RuIR2SFyHFAdSra37RQhc8qtPQUW6ZMbsNJAecGnDG4ieOY5OatIyILn1nI0BuQd72gd6SqguxuMfjCf2qdyiD+j8MUFg4FKfijETvhCFhdsh3INr2WbBSVNWDGtocKjgacD17GoCnMIV1a7oCiDqyxmHi9xQvPDUU/ANHDnOedZZLnMUKYqg6/ciZgeVkY8UYbLtakjVYeUYAo88of3Mku7zo1kQ0caFCPAC2C5QkCPjst4ee4iIMttQHoBHqQX7kfIZ5ewEDcGTLm9w00TUysWvLpt1rY9ZwD0x6HNSfa223dtbipMHbqu4PXpeoI3BPaBeC7GfhrCcSE26vyPeVpaFncmzIU3/W7qJC6fgmFTm92ci0HMUOe3Ktx+haSrQHv385JYcok968Xq6ZCtTkJaTAwxWGzAKV7BsbzHQI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9730
X-CodeTwo-MessageID: a37575f4-1e39-407a-9179-1a443c50a3df.20240222071031@westeu11-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AMS0EPF00000191.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ed3ac3e0-f193-44ce-fa81-08dc33755887
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GEjA+rAuyTWxI2buB5BeFXAtqPswoOkSyfqXQvSbBBOvstcQ/WiY7j8dMFgOqPWZM2Epooh8JaBYZCVQl7WuTMknfd3Tnr6EMtSuNNarRj/kOKyprIi4qru2bM5M3NJ3z+cMfMWn5ylt9Ps5XBJTuHVjGP5A9p6m1NYHXLaG537G8Xs7HMXHXCZ1nXEdBq+pV6+hzt/hQDX8T9qaCFtYgez3qAJMPQDP7Lf9IkF3fe6YpcTsrHqK6UDYU7coxArcWhTe+sC9+EA1yaCU0WdKS7g43rd+lsRU+AfYq9pPUXQic6uyU6+R06IOzbtGczOPqk0sW1qrGbOmh1XT28zgDXFlu7pAzshbvePwj5eTGQd2L89NCEKo6KxDyYqW/Ff3u36PNoSTM4aMsHE8caUZGnGd1ws6QJ2m8rEvqMFGp88lN+zUFYEhGNFhdUOzY12+Y9cUXcPe+df4UWOAdixPlu2p6r523YjcyTSBQx2/a3KUeKZzOkTh5/Lgm4RZRwgfRAZp540SW/t6lJbMovdbVI3rDgEWGFt2DTVRRv9C8WONXcas3TyTgsIop4tV+yR+3ZsCQYX93AcNnnrWFOSl0I9bBgHTKLkjJ22zdaOnusN7Lqjh+sdOxg6pT/sQ5mnQLt30lyHr23lf7j0LLIT5/Q==
X-Forefront-Antispam-Report:
	CIP:20.93.157.195;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu11-emailsignatures-cloud.codetwo.com;PTR:westeu11-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(36860700004)(46966006);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 07:10:32.2679
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bfaa3389-ab48-43e3-2dcb-08dc33755bbe
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[20.93.157.195];Helo=[westeu11-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AMS0EPF00000191.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7207

Good catch on both patches.

If so desired, you have my

Acked-by: Mike Looijmans <mike.looijmans@topic.nl>


On 22-02-2024 07:14, Dan Carpenter wrote:
> There is a copy and paste bug here, it should be "reg_vref" instead of
> "reg_avdd".  The "priv->reg_avdd" variable is zero so it ends up
> returning success.
>
> Fixes: 00ef7708fa60 ("iio: adc: ti-ads1298: Add driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/iio/adc/ti-ads1298.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c
> index ed895a30beed..67637f1abdc7 100644
> --- a/drivers/iio/adc/ti-ads1298.c
> +++ b/drivers/iio/adc/ti-ads1298.c
> @@ -657,7 +657,7 @@ static int ads1298_probe(struct spi_device *spi)
>   	priv->reg_vref =3D devm_regulator_get_optional(dev, "vref");
>   	if (IS_ERR(priv->reg_vref)) {
>   		if (PTR_ERR(priv->reg_vref) !=3D -ENODEV)
> -			return dev_err_probe(dev, PTR_ERR(priv->reg_avdd),
> +			return dev_err_probe(dev, PTR_ERR(priv->reg_vref),
>   					     "Failed to get vref regulator\n");
>  =20
>   		priv->reg_vref =3D NULL;


--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl