Received-SPF: pass (google.com: domain of linux-kernel+bounces-76027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 22 Feb 2024 08:49:48 +0100
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn
 <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Russell King <linux@armlinux.org.uk>,
 linux-arm-kernel@lists.infradead.org, Christophe Leroy
 <christophe.leroy@csgroup.eu>, Herve Codina <herve.codina@bootlin.com>,
 Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit
 <hkallweit1@gmail.com>, Vladimir Oltean <vladimir.oltean@nxp.com>,
 =?UTF-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>, Jesse Brandeburg
 <jesse.brandeburg@intel.com>, Jonathan Corbet <corbet@lwn.net>, Marek
 =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>, Piergiorgio Beruto
 <piergiorgio.beruto@gmail.com>, Oleksij Rempel <o.rempel@pengutronix.de>,
 =?UTF-8?B?Tmljb2zDsg==?= Veronese <nicveronese@gmail.com>, Simon Horman
 <horms@kernel.org>, mwojtas@chromium.org
Subject: Re: [PATCH net-next v8 08/13] netlink: specs: add ethnl PHY_GET
 command set
Message-ID: <20240222084948.16f33760@device-28.home>
In-Reply-To: <20240221170023.452a01ca@kernel.org>
References: <20240220184217.3689988-1-maxime.chevallier@bootlin.com>
	<20240220184217.3689988-9-maxime.chevallier@bootlin.com>
	<20240221170023.452a01ca@kernel.org>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Jakub,

On Wed, 21 Feb 2024 17:00:23 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Tue, 20 Feb 2024 19:42:11 +0100 Maxime Chevallier wrote:
> > +      -
> > +        name: upstream-phy-index
> > +        type: u32 =20
>=20
> The C define appears to be called:
>=20
> 	ETHTOOL_A_PHY_UPSTREAM_INDEX,		/* u32 */
>=20
> either it needs to gain the PHY_ or the spec needs to lose the phy-,
> otherwise C code gen gets upset:

I'll do it, sorry about that.

>=20
> ethtool-user.c:689:10: error: =E2=80=98ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX=
=E2=80=99 undeclared here (not in a function); did you mean =E2=80=98ETHTOO=
L_A_PHY_UPSTREAM_INDEX=E2=80=99?
>   689 |         [ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX] =3D { .name =3D "upstr=
eam-phy-index", .type =3D YNL_PT_U32, },
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |          ETHTOOL_A_PHY_UPSTREAM_INDEX
>=20
> Unfortunately ethtool in the in-between state where we can auto-gen
> user space code (or rather most of it) but the uAPI header is not
> auto-generated so we need to take extra care to keep things in sync :(

Is there anything I run for testing, so that I can make sure this
doesn't happen again ?

Thanks,

Maxime