Received-SPF: pass (google.com: domain of linux-kernel+bounces-76060-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 22 Feb 2024 09:05:15 +0100
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
	Corey Minyard <minyard@acm.org>,
	Andrew Manley <andrew.manley@sealingtech.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: imx: when being a target, mark the last read as
 processed
Message-ID: <ZdcAOwHWWYQZe3wE@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
	Corey Minyard <minyard@acm.org>,
	Andrew Manley <andrew.manley@sealingtech.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240221193013.14233-2-wsa+renesas@sang-engineering.com>
 <kgfagzj5vez56levwam6n6tzxl2lu7efnw5x3eadl3uophxism@ph2tghrvedg5>
 <ZdZ_PsNhQ9S1Eab-@shikoro>
 <Zdb-EHnTiez6KP-K@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jkgNTKjjcVM+jmPc"
Content-Disposition: inline
In-Reply-To: <Zdb-EHnTiez6KP-K@pengutronix.de>


--jkgNTKjjcVM+jmPc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 08:56:00AM +0100, Oleksij Rempel wrote:

> > > > When being a target, NAK from the controller means that all bytes h=
ave
> > > > been transferred. So, the last byte needs also to be marked as
> > > > 'processed'. Otherwise index registers of backends may not increase.
> > > >=20
> > > > Signed-off-by: Corey Minyard <minyard@acm.org>
> > > > Tested-by: Andrew Manley <andrew.manley@sealingtech.com>
> > > > Reviewed-by: Andrew Manley <andrew.manley@sealingtech.com>
> > > > Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > [wsa: fixed comment and commit message to properly describe the cas=
e]
> > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > >=20
> > > is this a fix?
> >=20
> > In deed, it is:
> >=20
> > Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver")
>=20
> Looks good :)
> Are any action needed on my side?

Nope. All tags are still valid, I'd say, because I didn't change any code.

Thanks!


--jkgNTKjjcVM+jmPc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXXADsACgkQFA3kzBSg
KbbwkA/+LRNQhXhak4TaZVdgCFqaF4XuPEa1bzs9BwnBYsZG6iOWxmpOFVIS3PTw
/CkmYJqtfS7d8ZqePNBXVRZnOH65xX9is66PCtGt4ozPRw8D5QELzBJnsc4Em9ra
WeUofTGNtYr/0FBG+fypE8y7yf7XY3hQqeqhEq9s2+I5ONxybHu0TFxMKNgAXDjK
Ayc61UaPEOTiT+12Kg1HBWxxzX9FnqUP87JWY8x7o7tf0xN/zXuLs1wDIuH9gWZf
GSgs82aqU5mC4vz6TgZOiscwQxwYfqP8k3Ztj+53B9LzV3IeLeqiw1YGfWtM/wSU
GYUQUZdO8w79Fld5KePO/XJUU9v8mn8Ye3LF9dmtVpID3i6ByhCPIl/GX+NxGOfL
J7XFIgyGPOCq2WuEv9Gg7+OoiBLBv81CaYjPzVRAz73H59cgBDAvy/TFAAO7WYRz
wBmfC0Z8QbbnmD1sISc69HQBkdl1ymL4X/MQEn9j9/GfCGTKVH9ak/z/XFDzxJCB
aXejjwyHMKII+gm+jn3y8uGKthh0RRG7Fyzv0rZvLoqr7Qqmlq46TRz02vo97kiY
9F5YEZnNZokTJOF/xzSlgYtIMlLQTFuBBCuJ76m2ojXzHgvR3MCNPBQCtreHTfCg
B8mt1L3KFYmVwyHeAd7ARxs32a3NmMUxGv7zVy9SHh9E0x0GCq4=
=XJvn
-----END PGP SIGNATURE-----

--jkgNTKjjcVM+jmPc--