Received-SPF: pass (google.com: domain of linux-kernel+bounces-76174-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 10:03:46 +0100
Message-ID: <87ttm06fbh.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <broonie@kernel.org>,
	<tiwai@suse.com>,
	<linux-sound@vger.kernel.org>,
	<alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH 0/9] ALSA: cs35l56: Apply calibration from EFI
In-Reply-To: <20240221150507.1039979-1-rf@opensource.cirrus.com>
References: <20240221150507.1039979-1-rf@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Wed, 21 Feb 2024 16:04:58 +0100,
Richard Fitzgerald wrote:
> 
> Factory calibration of the speakers stores the calibration information
> into an EFI variable.
> 
> This set of patches adds support for applying speaker calibration
> data from that EFI variable.
> 
> Patch #1 and #2 are bugfixes that are prerequisites.
> 
> The HDA patches #7 and #8 depend on the ASoC patches.
> 
> Patch #9 is a KUnit test for the new cs-amp-lib library.
> 
> Richard Fitzgerald (8):
>   ASoC: wm_adsp: Fix missing mutex_lock in wm_adsp_write_ctl()
>   ASoC: wm_adsp: Add wm_adsp_start() and wm_adsp_stop()
>   ASoC: cs-amp-lib: Add helpers for factory calibration data
>   ASoC: cs35l56: Add helper functions for amp calibration
>   ASoC: cs35l56: Apply amp calibration from EFI data
>   ALSA: hda: hda_cs_dsp_ctl: Add helper function to write calibration
>   ALSA: hda: cs35l56: Apply amp calibration from EFI data
>   ASoC: cs-amp-lib: Add KUnit test for calibration helpers
> 
> Simon Trimmer (1):
>   ALSA: hda: hda_cs_dsp_ctl: Only call notify when a control has been
>     added to a card

I guess it's better to be merged through ASoC tree.
Feel free to my review tag

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi